Patchwork [0/6] hardy CVEs

login
register
mail settings
Submitter Paolo Pisati
Date July 1, 2011, 2:53 p.m.
Message ID <4E0DDF6F.3040500@canonical.com>
Download mbox | patch
Permalink /patch/102912/
State New
Headers show

Comments

Paolo Pisati - July 1, 2011, 2:53 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

CVE-2011-0711, CVE-2010-4249, CVE-2011-1170, CVE-2011-1171,
CVE-2011-1172 and CVE-2011-1173.

4249 came from lucid/master and applied cleanly, while the rest
had modifications or no ack whatsoever.

Alex Elder (1):
  xfs: zero proper structure size for geometry calls CVE-2011-0711

Eric Dumazet (1):
  af_unix: limit unix_tot_inflight CVE-2010-4249

Vasiliy Kulikov (4):
  netfilter: ip_tables: fix infoleak to userspace CVE-2011-1171
  econet: 4 byte infoleak to the network CVE-2011-1173
  netfilter: arp_tables: fix infoleak to userspace CVE-2011-1170
  ipv6: netfilter: ip6_tables: fix infoleak to userspace CVE-2011-1172

 fs/xfs/linux-2.6/xfs_ioctl.c    |   11 ++++++++---
 net/econet/af_econet.c          |    2 +-
 net/ipv4/netfilter/arp_tables.c |    3 +++
 net/ipv4/netfilter/ip_tables.c  |    3 +++
 net/ipv6/netfilter/ip6_tables.c |    3 +++
 net/unix/garbage.c              |    7 +++++++
 6 files changed, 25 insertions(+), 4 deletions(-)

- --
bye,
p.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJODd9vAAoJEMupOQaAohtU/FUH/3LRXH+A/TM03gXdCTMZdTDt
OZpwiUDRm9K1U8x/Dtvzo7Pyn8d55rpN/hg1Q6cBJuZk9a5et70Hao8lyq+c1fR8
vmyUwi6aTdqEBPhADLWURHJuSJsZT5mXu0gFd5tUL70x3WaSdjsvCKEdHgPajSJT
+ErbXL7i9MHNY2viM9Fh0F7a3isMge0pJULC68QkWRKMT4t/R70ET6ku5NHnZKEz
CrxT3kxYfvxC7qhj7uaQP2JDuHeZlAohfANjcOpn6OA4EAq69/1WhzzigyL4TF9r
4eEP/uaMch8ImoUd+w+oiUbNiVo71cY9TtC/lwli0dMcoIhxTR7M3GOwKs6BsAo=
=gkcB
-----END PGP SIGNATURE-----

Patch

From da5b4408dedc50d6755c478cceb3df0c782230c8 Mon Sep 17 00:00:00 2001
From: Vasiliy Kulikov <segoon@openwall.com>
Date: Tue, 15 Mar 2011 13:37:13 +0100
Subject: [PATCH 6/6] ipv6: netfilter: ip6_tables: fix infoleak to userspace CVE-2011-1172

BugLink: http://bugs.launchpad.net/bugs/801483

Structures ip6t_replace, compat_ip6t_replace, and xt_get_revision are
copied from userspace.  Fields of these structs that are
zero-terminated strings are not checked.  When they are used as argument
to a format string containing "%s" in request_module(), some sensitive
information is leaked to userspace via argument of spawned modprobe
process.

The first bug was introduced before the git epoch;  the second was
introduced in 3bc3fe5e (v2.6.25-rc1);  the third is introduced by
6b7d31fc (v2.6.15-rc1).  To trigger the bug one should have
CAP_NET_ADMIN.

CVE-2011-1172

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 net/ipv6/netfilter/ip6_tables.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
index acaba15..68fb45e 100644
--- a/net/ipv6/netfilter/ip6_tables.c
+++ b/net/ipv6/netfilter/ip6_tables.c
@@ -1047,6 +1047,7 @@  do_replace(void __user *user, unsigned int len)
 		return -ENOMEM;
 	if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
 		return -ENOMEM;
+	tmp.name[sizeof(tmp.name)-1] = 0;
 
 	newinfo = xt_alloc_table_info(tmp.size);
 	if (!newinfo)
@@ -1162,6 +1163,7 @@  do_add_counters(void __user *user, unsigned int len)
 
 	if (copy_from_user(&tmp, user, sizeof(tmp)) != 0)
 		return -EFAULT;
+	tmp.name[sizeof(tmp.name)-1] = 0;
 
 	if (len != sizeof(tmp) + tmp.num_counters*sizeof(struct xt_counters))
 		return -EINVAL;
@@ -1313,6 +1315,7 @@  do_ip6t_get_ctl(struct sock *sk, int cmd, void __user *user, int *len)
 			ret = -EFAULT;
 			break;
 		}
+		rev.name[sizeof(rev.name)-1] = 0;
 
 		if (cmd == IP6T_SO_GET_REVISION_TARGET)
 			target = 1;
-- 
1.7.4.1