| Message ID | 20190121233102.13705-1-okaya@kernel.org |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | [for,next] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS | expand |
On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote: > There is an unresolved dependency as follows: > > IWLWIFI_LEDS selects MAC80211_LEDS. > MAC80211_LEDS depends on MAC80211. > > It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 > (n) > > WARNING: unmet direct dependencies detected for MAC80211_LEDS > Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && > LEDS_CLASS [=y] > Selected by [y]: > - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && > WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || > LEDS_CLASS [=y]=IWLWIFI [=y]) > > Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this > configuration. > > Signed-off-by: Sinan Kaya <okaya@kernel.org> > --- Thanks for your patch! But we already have another patch to fix this issued queued for 5.0-rc4 (it's currently in wireless-drivers.git): https://patchwork.kernel.org/patch/10762079/ -- Cheers, Luca.
On 1/22/2019 5:15 AM, Luciano Coelho wrote: > On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote: >> There is an unresolved dependency as follows: >> >> IWLWIFI_LEDS selects MAC80211_LEDS. >> MAC80211_LEDS depends on MAC80211. >> >> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 >> (n) >> >> WARNING: unmet direct dependencies detected for MAC80211_LEDS >> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && >> LEDS_CLASS [=y] >> Selected by [y]: >> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && >> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || >> LEDS_CLASS [=y]=IWLWIFI [=y]) >> >> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this >> configuration. >> >> Signed-off-by: Sinan Kaya <okaya@kernel.org> >> --- > > Thanks for your patch! But we already have another patch to fix this > issued queued for 5.0-rc4 (it's currently in wireless-drivers.git): > > https://patchwork.kernel.org/patch/10762079/ Is it possible to queue this up soon? There is an effort to clean up linux-next against randconfig failures and this issue showed up there. > > -- > Cheers, > Luca. > >
Sinan Kaya <okaya@kernel.org> writes: > On 1/22/2019 5:15 AM, Luciano Coelho wrote: >> On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote: >>> There is an unresolved dependency as follows: >>> >>> IWLWIFI_LEDS selects MAC80211_LEDS. >>> MAC80211_LEDS depends on MAC80211. >>> >>> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 >>> (n) >>> >>> WARNING: unmet direct dependencies detected for MAC80211_LEDS >>> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && >>> LEDS_CLASS [=y] >>> Selected by [y]: >>> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && >>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || >>> LEDS_CLASS [=y]=IWLWIFI [=y]) >>> >>> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this >>> configuration. >>> >>> Signed-off-by: Sinan Kaya <okaya@kernel.org> >>> --- >> >> Thanks for your patch! But we already have another patch to fix this >> issued queued for 5.0-rc4 (it's currently in wireless-drivers.git): >> >> https://patchwork.kernel.org/patch/10762079/ > > Is it possible to queue this up soon? There is an effort to clean up > linux-next against randconfig failures and this issue showed up there. It already should be in linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1 But it's not in Linus' tree, yet.
On 1/22/2019 11:17 AM, Kalle Valo wrote: > Sinan Kaya <okaya@kernel.org> writes: > >> On 1/22/2019 5:15 AM, Luciano Coelho wrote: >>> On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote: >>>> There is an unresolved dependency as follows: >>>> >>>> IWLWIFI_LEDS selects MAC80211_LEDS. >>>> MAC80211_LEDS depends on MAC80211. >>>> >>>> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 >>>> (n) >>>> >>>> WARNING: unmet direct dependencies detected for MAC80211_LEDS >>>> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && >>>> LEDS_CLASS [=y] >>>> Selected by [y]: >>>> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && >>>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || >>>> LEDS_CLASS [=y]=IWLWIFI [=y]) >>>> >>>> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this >>>> configuration. >>>> >>>> Signed-off-by: Sinan Kaya <okaya@kernel.org> >>>> --- >>> >>> Thanks for your patch! But we already have another patch to fix this >>> issued queued for 5.0-rc4 (it's currently in wireless-drivers.git): >>> >>> https://patchwork.kernel.org/patch/10762079/ >> >> Is it possible to queue this up soon? There is an effort to clean up >> linux-next against randconfig failures and this issue showed up there. > > It already should be in linux-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1 > > But it's not in Linus' tree, yet. > Thanks, let me grab a recent linux-next tag.
diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig index 491ca3c8b43c..74f0d0bbed34 100644 --- a/drivers/net/wireless/intel/iwlwifi/Kconfig +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig @@ -46,7 +46,7 @@ if IWLWIFI config IWLWIFI_LEDS bool - depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI + depends on MAC80211 && (LEDS_CLASS=y || LEDS_CLASS=IWLWIFI) select LEDS_TRIGGERS select MAC80211_LEDS default y
There is an unresolved dependency as follows: IWLWIFI_LEDS selects MAC80211_LEDS. MAC80211_LEDS depends on MAC80211. It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 (n) WARNING: unmet direct dependencies detected for MAC80211_LEDS Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && LEDS_CLASS [=y] Selected by [y]: - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y]) Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this configuration. Signed-off-by: Sinan Kaya <okaya@kernel.org> --- drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)