| Message ID | 20190121145847.30223-1-stefan@agner.ch |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: fec: get regulator optional | expand |
On Mon, 2019-01-21 at 15:58 +0100, Stefan Agner wrote: > According to the device tree binding the phy-supply property is > optional. Use the regulator_get_optional API accordingly. The > code already handles NULL just fine. > > This gets rid of the following warning: > fec 2188000.ethernet: 2188000.ethernet supply phy not found, using > dummy regulator > > Signed-off-by: Stefan Agner <stefan@agner.ch> Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > drivers/net/ethernet/freescale/fec_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index 6db69ba30dcd..c8315d880c8c 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -3479,7 +3479,7 @@ fec_probe(struct platform_device *pdev) > if (ret) > goto failed_clk_ipg; > > - fep->reg_phy = devm_regulator_get(&pdev->dev, "phy"); > + fep->reg_phy = devm_regulator_get_optional(&pdev->dev, "phy"); > if (!IS_ERR(fep->reg_phy)) { > ret = regulator_enable(fep->reg_phy); > if (ret) {
From: Stefan Agner <stefan@agner.ch> Sent: Monday, January 21, 2019 10:59 PM > According to the device tree binding the phy-supply property is optional. Use > the regulator_get_optional API accordingly. The code already handles NULL > just fine. > > This gets rid of the following warning: > fec 2188000.ethernet: 2188000.ethernet supply phy not found, using > dummy regulator > > Signed-off-by: Stefan Agner <stefan@agner.ch> Thanks. Acked-by: Fugang Duan <fugang.duan@nxp.com> > --- > drivers/net/ethernet/freescale/fec_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index 6db69ba30dcd..c8315d880c8c 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -3479,7 +3479,7 @@ fec_probe(struct platform_device *pdev) > if (ret) > goto failed_clk_ipg; > > - fep->reg_phy = devm_regulator_get(&pdev->dev, "phy"); > + fep->reg_phy = devm_regulator_get_optional(&pdev->dev, "phy"); > if (!IS_ERR(fep->reg_phy)) { > ret = regulator_enable(fep->reg_phy); > if (ret) { > -- > 2.20.1
From: Stefan Agner <stefan@agner.ch> Date: Mon, 21 Jan 2019 15:58:47 +0100 > According to the device tree binding the phy-supply property is > optional. Use the regulator_get_optional API accordingly. The > code already handles NULL just fine. > > This gets rid of the following warning: > fec 2188000.ethernet: 2188000.ethernet supply phy not found, using dummy regulator > > Signed-off-by: Stefan Agner <stefan@agner.ch> Applied.
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 6db69ba30dcd..c8315d880c8c 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3479,7 +3479,7 @@ fec_probe(struct platform_device *pdev) if (ret) goto failed_clk_ipg; - fep->reg_phy = devm_regulator_get(&pdev->dev, "phy"); + fep->reg_phy = devm_regulator_get_optional(&pdev->dev, "phy"); if (!IS_ERR(fep->reg_phy)) { ret = regulator_enable(fep->reg_phy); if (ret) {
According to the device tree binding the phy-supply property is optional. Use the regulator_get_optional API accordingly. The code already handles NULL just fine. This gets rid of the following warning: fec 2188000.ethernet: 2188000.ethernet supply phy not found, using dummy regulator Signed-off-by: Stefan Agner <stefan@agner.ch> --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)