Patchwork [v6,02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster

login
register
mail settings
Submitter Feiran Zheng
Date July 1, 2011, 4:55 a.m.
Message ID <1309496142-14228-3-git-send-email-famcool@gmail.com>
Download mbox | patch
Permalink /patch/102864/
State New
Headers show

Comments

Feiran Zheng - July 1, 2011, 4:55 a.m.
In get_whole_cluster, the offset is not aligned to cluster when reading
from backing_hd. When the first write to child is not at the cluster
boundary, wrong address data from parent is copied to child.

Signed-off-by: Fam Zheng <famcool@gmail.com>
---
 block/vmdk.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

Patch

diff --git a/block/vmdk.c b/block/vmdk.c
index f26137d..557e01e 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -519,21 +519,23 @@  static int get_whole_cluster(BlockDriverState *bs,
     /* 128 sectors * 512 bytes each = grain size 64KB */
     uint8_t  whole_grain[extent->cluster_sectors * 512];
 
-    // we will be here if it's first write on non-exist grain(cluster).
-    // try to read from parent image, if exist
+    /* we will be here if it's first write on non-exist grain(cluster).
+     * try to read from parent image, if exist */
     if (bs->backing_hd) {
         int ret;
 
         if (!vmdk_is_cid_valid(bs))
             return -1;
 
+        /* floor offset to cluster */
+        offset -= offset % (extent->cluster_sectors * 512);
         ret = bdrv_read(bs->backing_hd, offset >> 9, whole_grain,
                 extent->cluster_sectors);
         if (ret < 0) {
             return -1;
         }
 
-        //Write grain only into the active image
+        /* Write grain only into the active image */
         ret = bdrv_write(extent->file, cluster_offset, whole_grain,
                 extent->cluster_sectors);
         if (ret < 0) {