Show locallease in /proc/mounts for cifs shares mounted with locallease feature.
diff mbox series

Message ID 20190121015159.30188-1-lsahlber@redhat.com
State New
Headers show
Series
  • Show locallease in /proc/mounts for cifs shares mounted with locallease feature.
Related show

Commit Message

Ronnie Sahlberg Jan. 21, 2019, 1:51 a.m. UTC
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Steve French Jan. 21, 2019, 5:47 a.m. UTC | #1
Makes sense - but don't we need to update the man page as well - I
don't see it in there either.

And wouldn't hurt to note a use case where it could be helpful?!

On Sun, Jan 20, 2019 at 7:52 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
>
> Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
> Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> ---
>  fs/cifs/cifsfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index 62d48d486d8f..775cbb39f3b7 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -489,6 +489,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
>                 seq_puts(s, ",seal");
>         if (tcon->nocase)
>                 seq_puts(s, ",nocase");
> +       if (tcon->local_lease)
> +               seq_puts(s, ",locallease");
>         if (tcon->retry)
>                 seq_puts(s, ",hard");
>         else
> --
> 2.13.6
>
Kenneth Dsouza Jan. 21, 2019, 1:02 p.m. UTC | #2
On Mon, Jan 21, 2019 at 1:22 PM Steve French <smfrench@gmail.com> wrote:
>
> Makes sense - but don't we need to update the man page as well - I
> don't see it in there either.
>
> And wouldn't hurt to note a use case where it could be helpful?!
>

 Aurélien has documented the locallease and other mount options in the
below patch.
https://git.samba.org/?p=cifs-utils.git;a=commit;h=7325a01abc529d68756bae90cf23233392626939


> On Sun, Jan 20, 2019 at 7:52 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
> >
> > Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
> > Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> > ---
> >  fs/cifs/cifsfs.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> > index 62d48d486d8f..775cbb39f3b7 100644
> > --- a/fs/cifs/cifsfs.c
> > +++ b/fs/cifs/cifsfs.c
> > @@ -489,6 +489,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
> >                 seq_puts(s, ",seal");
> >         if (tcon->nocase)
> >                 seq_puts(s, ",nocase");
> > +       if (tcon->local_lease)
> > +               seq_puts(s, ",locallease");
> >         if (tcon->retry)
> >                 seq_puts(s, ",hard");
> >         else
> > --
> > 2.13.6
> >
>
>
> --
> Thanks,
>
> Steve
Steve French Jan. 21, 2019, 4:46 p.m. UTC | #3
Aah - didn't see it in master.  We should update the ones in the
'next' branch to master.  Not controversial ones.

On Mon, Jan 21, 2019 at 7:02 AM Kenneth Dsouza <kdsouza@redhat.com> wrote:
>
> On Mon, Jan 21, 2019 at 1:22 PM Steve French <smfrench@gmail.com> wrote:
> >
> > Makes sense - but don't we need to update the man page as well - I
> > don't see it in there either.
> >
> > And wouldn't hurt to note a use case where it could be helpful?!
> >
>
>  Aurélien has documented the locallease and other mount options in the
> below patch.
> https://git.samba.org/?p=cifs-utils.git;a=commit;h=7325a01abc529d68756bae90cf23233392626939
>
>
> > On Sun, Jan 20, 2019 at 7:52 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
> > >
> > > Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
> > > Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> > > ---
> > >  fs/cifs/cifsfs.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> > > index 62d48d486d8f..775cbb39f3b7 100644
> > > --- a/fs/cifs/cifsfs.c
> > > +++ b/fs/cifs/cifsfs.c
> > > @@ -489,6 +489,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
> > >                 seq_puts(s, ",seal");
> > >         if (tcon->nocase)
> > >                 seq_puts(s, ",nocase");
> > > +       if (tcon->local_lease)
> > > +               seq_puts(s, ",locallease");
> > >         if (tcon->retry)
> > >                 seq_puts(s, ",hard");
> > >         else
> > > --
> > > 2.13.6
> > >
> >
> >
> > --
> > Thanks,
> >
> > Steve
Steve French Jan. 21, 2019, 4:51 p.m. UTC | #4
On Mon, Jan 21, 2019 at 10:46 AM Steve French <smfrench@gmail.com> wrote:
>
> Aah - didn't see it in master.  We should update the ones in the
> 'next' branch to master.  Not controversial ones.

To clarify - what I meant was that the three patches that have been in
'next' branch of cifs-utils are safe, not-controversial and seem like
they should be in master


> On Mon, Jan 21, 2019 at 7:02 AM Kenneth Dsouza <kdsouza@redhat.com> wrote:
> >
> > On Mon, Jan 21, 2019 at 1:22 PM Steve French <smfrench@gmail.com> wrote:
> > >
> > > Makes sense - but don't we need to update the man page as well - I
> > > don't see it in there either.
> > >
> > > And wouldn't hurt to note a use case where it could be helpful?!
> > >
> >
> >  Aurélien has documented the locallease and other mount options in the
> > below patch.
> > https://git.samba.org/?p=cifs-utils.git;a=commit;h=7325a01abc529d68756bae90cf23233392626939
> >
> >
> > > On Sun, Jan 20, 2019 at 7:52 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
> > > >
> > > > Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
> > > > Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> > > > ---
> > > >  fs/cifs/cifsfs.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> > > > index 62d48d486d8f..775cbb39f3b7 100644
> > > > --- a/fs/cifs/cifsfs.c
> > > > +++ b/fs/cifs/cifsfs.c
> > > > @@ -489,6 +489,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
> > > >                 seq_puts(s, ",seal");
> > > >         if (tcon->nocase)
> > > >                 seq_puts(s, ",nocase");
> > > > +       if (tcon->local_lease)
> > > > +               seq_puts(s, ",locallease");
> > > >         if (tcon->retry)
> > > >                 seq_puts(s, ",hard");
> > > >         else
> > > > --
> > > > 2.13.6
> > > >
> > >
> > >
> > > --
> > > Thanks,
> > >
> > > Steve
>
>
>
> --
> Thanks,
>
> Steve
Steve French April 2, 2019, 3:11 p.m. UTC | #5
I had missed this one.

merged into cifs-2.6.git for-next (target for next merge window, 5.2
unless you think it needs to go in faster for an important user issue)

Let me know if you see any other patches I have missed in for-next

On Mon, Jan 21, 2019 at 7:02 AM Kenneth Dsouza <kdsouza@redhat.com> wrote:
>
> On Mon, Jan 21, 2019 at 1:22 PM Steve French <smfrench@gmail.com> wrote:
> >
> > Makes sense - but don't we need to update the man page as well - I
> > don't see it in there either.
> >
> > And wouldn't hurt to note a use case where it could be helpful?!
> >
>
>  Aurélien has documented the locallease and other mount options in the
> below patch.
> https://git.samba.org/?p=cifs-utils.git;a=commit;h=7325a01abc529d68756bae90cf23233392626939
>
>
> > On Sun, Jan 20, 2019 at 7:52 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
> > >
> > > Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
> > > Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> > > ---
> > >  fs/cifs/cifsfs.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> > > index 62d48d486d8f..775cbb39f3b7 100644
> > > --- a/fs/cifs/cifsfs.c
> > > +++ b/fs/cifs/cifsfs.c
> > > @@ -489,6 +489,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
> > >                 seq_puts(s, ",seal");
> > >         if (tcon->nocase)
> > >                 seq_puts(s, ",nocase");
> > > +       if (tcon->local_lease)
> > > +               seq_puts(s, ",locallease");
> > >         if (tcon->retry)
> > >                 seq_puts(s, ",hard");
> > >         else
> > > --
> > > 2.13.6
> > >
> >
> >
> > --
> > Thanks,
> >
> > Steve

Patch
diff mbox series

diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 62d48d486d8f..775cbb39f3b7 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -489,6 +489,8 @@  cifs_show_options(struct seq_file *s, struct dentry *root)
 		seq_puts(s, ",seal");
 	if (tcon->nocase)
 		seq_puts(s, ",nocase");
+	if (tcon->local_lease)
+		seq_puts(s, ",locallease");
 	if (tcon->retry)
 		seq_puts(s, ",hard");
 	else