From patchwork Mon Jan 21 07:11:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 1028283 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=i2se.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43jjR73H57z9sML for ; Mon, 21 Jan 2019 18:12:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727545AbfAUHMC (ORCPT ); Mon, 21 Jan 2019 02:12:02 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:39327 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727556AbfAUHMB (ORCPT ); Mon, 21 Jan 2019 02:12:01 -0500 Received: from localhost.localdomain ([37.4.249.120]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MD9jV-1gtyBr0WEz-009BRr; Mon, 21 Jan 2019 08:11:50 +0100 From: Stefan Wahren To: Linus Walleij , Bartosz Golaszewski , Eric Anholt Cc: Peter Robinson , Lukas Wunner , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH RFC V2 4/4] gpiolib: Take MUX usage into account Date: Mon, 21 Jan 2019 08:11:25 +0100 Message-Id: <1548054685-3781-5-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1548054685-3781-1-git-send-email-stefan.wahren@i2se.com> References: <1548054685-3781-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K1:wFSm5DiGB8t/6R0BFr7+f1DoAMk0jM+igrHUt1F1dd0LeSuTJwV UViS5qURs2CsTwS3qlJCVt8ZQ7i5nL5E9UF8GmtwjUl/A/b0BZ8TQIGz69VloA6Mz6eh/zs 28UWl3l1NAJYbfnfyjztWnIgH58KowfMAu0o8hupfPzIEutwTqYDOrjiTR6D4/XxdA/iJjF lEdKkN8sqIVlXLDfnfANA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:d+GCDvMmv+8=:UJzj/QDxv+GmBEY4ZYSKgC GakJbrgitRBZxcxFYsLLCtfSZiC9JPF/6SoFcugT6PdXF5SD6VI8QGY84IdjkaRy8JvmHDuU4 D3Qn7cdeFpqZK1Fji2S7youT32rVfZclH1iUiuMcY4dJydo8BOop2Mxy7nm1NN86FRa6GB9Dv SZIn+loFaUnAnkcrdQaK8gGj2agokXZ1SpSMfsLHsJmSSYHDy7heKOtJt0NRKnK/o5lKDpPGm B/HHT8uzW5cigIVk7TfQ5FBxjkTm31vU37/GN2ZnUZhFRf8JBkoEcm5ZHxx9eftC+YP7gIxik JdmRdv6x8D231RTwyj+30hgORp9OnYMdRyGkY4w+d8Zk7KrG3WzioBBNykUlwaxDVTJhEcaxi RjO9gGLhSjprW2+cmIIkBhSPhKuf54FjxxMHn9zaBv9UbfOSdqHCb+H/qg15VtEGJ/5vIQPf6 FNIEyxmY/7TuusBXXhqS6y3Ha3BiFPa/ZJrd2/RGk7hwz7kR1rZODfAwDuEMPW5rCkXKVDUTE fYO2veFOdkD0NDZ7X0qRGmBy4tt5df6wP0PRmwcY4w9A5jW5UsVXBn5bVqB66YroQUymoKp40 H6z5cdAa+bOT/zao2GOJLhCjslyIL0Ysfmqk5ZGHGgqv6XI/C+3f2Yo/52EkZkvk2lfXGCsGJ L7ZT1r9wHJxv5nnL5E7xLTAQ9bGy2wfRtkj86/8R3CxsuJxeQJAhyt/1qPT0HjZjeHumd37hd jSfZGr2OPXyPz4lVcIxKnjCLzfISTIelCh/BOt747rrSs9TZ45L5spHLPwg= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The user space like gpioinfo only see the GPIO usage but not the MUX usage (e.g. I2C or SPI usage) of a pin. As a user we want to know which pin is free/safe to use. So take the MUX usage of strict pinmux controllers into account to get a more realistic view for ioctl GPIO_GET_LINEINFO_IOCTL. Signed-off-by: Stefan Wahren --- drivers/gpio/gpiolib.c | 3 ++- drivers/pinctrl/core.c | 23 +++++++++++++++++++++++ drivers/pinctrl/pinmux.c | 18 ++++++++++++++++++ drivers/pinctrl/pinmux.h | 7 +++++++ include/linux/pinctrl/consumer.h | 6 ++++++ 5 files changed, 56 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1651d7f..da3b008 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1075,7 +1075,8 @@ static long gpio_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) test_bit(FLAG_IS_HOGGED, &desc->flags) || test_bit(FLAG_USED_AS_IRQ, &desc->flags) || test_bit(FLAG_EXPORT, &desc->flags) || - test_bit(FLAG_SYSFS, &desc->flags)) + test_bit(FLAG_SYSFS, &desc->flags) || + pinctrl_gpio_is_in_use(chip->base + lineinfo.line_offset)) lineinfo.flags |= GPIOLINE_FLAG_KERNEL; if (test_bit(FLAG_IS_OUT, &desc->flags)) lineinfo.flags |= GPIOLINE_FLAG_IS_OUT; diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index c6ff4d5..6e097e4 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -760,6 +760,29 @@ int pinctrl_get_group_selector(struct pinctrl_dev *pctldev, return -EINVAL; } +bool pinctrl_gpio_is_in_use(unsigned gpio) +{ + struct pinctrl_dev *pctldev; + struct pinctrl_gpio_range *range; + bool result; + int pin; + + if (pinctrl_get_device_gpio_range(gpio, &pctldev, &range)) + return false; + + mutex_lock(&pctldev->mutex); + + /* Convert to the pin controllers number space */ + pin = gpio_to_pin(range, gpio); + + result = pinmux_is_in_use(pctldev, pin); + + mutex_unlock(&pctldev->mutex); + + return result; +} +EXPORT_SYMBOL_GPL(pinctrl_gpio_is_in_use); + /** * pinctrl_gpio_request() - request a single pin to be used as GPIO * @gpio: the GPIO pin number from the GPIO subsystem number space diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 4d0cc18..c1f6d46 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -71,6 +71,24 @@ int pinmux_validate_map(const struct pinctrl_map *map, int i) return 0; } +bool pinmux_is_in_use(struct pinctrl_dev *pctldev, unsigned pin) +{ + struct pin_desc *desc = pin_desc_get(pctldev, pin); + const struct pinmux_ops *ops = pctldev->desc->pmxops; + + if (!desc) { + dev_err(pctldev->dev, + "pin %u is not registered so it cannot be requested\n", + pin); + return false; + } + + if (ops->strict && desc->mux_usecount) + return true; + + return ops->strict && !!desc->gpio_owner; +} + /** * pin_request() - request a single pin to be muxed in, typically for GPIO * @pin: the pin number in the global pin space diff --git a/drivers/pinctrl/pinmux.h b/drivers/pinctrl/pinmux.h index 3319535..1da2a75 100644 --- a/drivers/pinctrl/pinmux.h +++ b/drivers/pinctrl/pinmux.h @@ -16,6 +16,8 @@ int pinmux_check_ops(struct pinctrl_dev *pctldev); int pinmux_validate_map(const struct pinctrl_map *map, int i); +bool pinmux_is_in_use(struct pinctrl_dev *pctldev, unsigned pin); + int pinmux_request_gpio(struct pinctrl_dev *pctldev, struct pinctrl_gpio_range *range, unsigned pin, unsigned gpio); @@ -43,6 +45,11 @@ static inline int pinmux_validate_map(const struct pinctrl_map *map, int i) return 0; } +static inline bool pinmux_is_in_use(struct pinctrl_dev *pctldev, unsigned pin) +{ + return false; +} + static inline int pinmux_request_gpio(struct pinctrl_dev *pctldev, struct pinctrl_gpio_range *range, unsigned pin, unsigned gpio) diff --git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consumer.h index 0412cc9..0093a2b 100644 --- a/include/linux/pinctrl/consumer.h +++ b/include/linux/pinctrl/consumer.h @@ -25,6 +25,7 @@ struct device; #ifdef CONFIG_PINCTRL /* External interface to pin control */ +extern bool pinctrl_gpio_is_in_use(unsigned gpio); extern int pinctrl_gpio_request(unsigned gpio); extern void pinctrl_gpio_free(unsigned gpio); extern int pinctrl_gpio_direction_input(unsigned gpio); @@ -62,6 +63,11 @@ static inline int pinctrl_pm_select_idle_state(struct device *dev) #else /* !CONFIG_PINCTRL */ +static inline bool pinctrl_gpio_is_in_use(unsigned gpio) +{ + return 0; +} + static inline int pinctrl_gpio_request(unsigned gpio) { return 0;