Patchwork [RFC,4/4] Partially revert "savevm: fix corruption in vmstate_subsection_load()."

login
register
mail settings
Submitter Paolo Bonzini
Date June 30, 2011, 3:46 p.m.
Message ID <1309448777-1447-5-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/102777/
State New
Headers show

Comments

Paolo Bonzini - June 30, 2011, 3:46 p.m.
This reverts the additional check in commit eb60260d (but not the
assertions).

The new format does not require the check, and with the old format
it traded one kind of bogus failure for a different kind of silent
failure.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 savevm.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

Patch

diff --git a/savevm.c b/savevm.c
index 654770a..6c726ec 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1679,10 +1679,6 @@  static int vmstate_subsection_load(QEMUFile *f, const VMStateDescription *vmsd,
 {
     const VMStateSubsection *sub = vmsd->subsections;
 
-    if (!sub || !sub->needed) {
-        return 0;
-    }
-
     while (qemu_peek_byte(f) == QEMU_VM_SUBSECTION) {
         char idstr[256];
         int ret;