[1/6] intel-gmmlib: new package.
diff mbox series

Message ID 20190118201045.13947-2-lpdev@cordier.org
State Superseded
Headers show
Series
  • *** Add Intel QuickSync support to ffmpeg ***
Related show

Commit Message

Louis-Paul Cordier Jan. 18, 2019, 8:10 p.m. UTC
Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
---
 package/Config.in                      |  1 +
 package/intel-gmmlib/Config.in         |  8 ++++++++
 package/intel-gmmlib/intel-gmmlib.hash |  2 ++
 package/intel-gmmlib/intel-gmmlib.mk   | 21 +++++++++++++++++++++
 4 files changed, 32 insertions(+)
 create mode 100644 package/intel-gmmlib/Config.in
 create mode 100644 package/intel-gmmlib/intel-gmmlib.hash
 create mode 100644 package/intel-gmmlib/intel-gmmlib.mk

Comments

Baruch Siach Jan. 19, 2019, 6:29 p.m. UTC | #1
Hi Louis-Paul,

On Fri, Jan 18 2019, Louis-Paul Cordier wrote:
> Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
> ---
>  package/Config.in                      |  1 +
>  package/intel-gmmlib/Config.in         |  8 ++++++++
>  package/intel-gmmlib/intel-gmmlib.hash |  2 ++
>  package/intel-gmmlib/intel-gmmlib.mk   | 21 +++++++++++++++++++++
>  4 files changed, 32 insertions(+)
>  create mode 100644 package/intel-gmmlib/Config.in
>  create mode 100644 package/intel-gmmlib/intel-gmmlib.hash
>  create mode 100644 package/intel-gmmlib/intel-gmmlib.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 5036421a73..9082ed9956 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1265,6 +1265,7 @@ menu "Graphics"
>  	source "package/harfbuzz/Config.in"
>  	source "package/ijs/Config.in"
>  	source "package/imlib2/Config.in"
> +	source "package/intel-gmmlib/Config.in"
>  	source "package/irrlicht/Config.in"
>  	source "package/jasper/Config.in"
>  	source "package/jpeg/Config.in"
> diff --git a/package/intel-gmmlib/Config.in b/package/intel-gmmlib/Config.in
> new file mode 100644
> index 0000000000..8d9fab7ce3
> --- /dev/null
> +++ b/package/intel-gmmlib/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_INTEL_GMMLIB
> +	bool "intel-gmmlib"
> +	depends on BR2_x86_64
> +	help
> +	  The Intel(R) Graphics Memory Management Library provides
> +	  device specific and buffer management for the Intel(R)
> +	  Graphics Compute Runtime for OpenCL(TM) and the Intel(R)
> +	  Media Driver for VAAPI.
> diff --git a/package/intel-gmmlib/intel-gmmlib.hash b/package/intel-gmmlib/intel-gmmlib.hash
> new file mode 100644
> index 0000000000..7e3b3dfd3f
> --- /dev/null
> +++ b/package/intel-gmmlib/intel-gmmlib.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256 e3114d7ddd429f1b9aa43a1b1d0086d881fbf4d90e4a90ab8577c369d2e3a5e1  intel-gmmlib-18.3.0.tar.gz
> diff --git a/package/intel-gmmlib/intel-gmmlib.mk b/package/intel-gmmlib/intel-gmmlib.mk
> new file mode 100644
> index 0000000000..206ea6db86
> --- /dev/null
> +++ b/package/intel-gmmlib/intel-gmmlib.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# intel-gmmlib
> +#
> +################################################################################
> +
> +INTEL_GMMLIB_VERSION = 18.3.0
> +INTEL_GMMLIB_SITE = https://github.com/intel/gmmlib/archive
> +INTEL_GMMLIB_LICENSE = MIT
> +INTEL_GMMLIB_LICENSE_FILES = COPYING
> +
> +INTEL_GMMLIB_INSTALL_STAGING = YES
> +INTEL_GMMLIB_SUPPORTS_IN_SOURCE_BUILD = NO
> +
> +INTEL_GMMLIB_CONF_OPTS += -DRUN_TEST_SUITE=OFF
> +
> +define INTEL_GMMLIB_INSTALL_TARGET_CMDS
> +	cp -a $(STAGING_DIR)/usr/lib/libigdgmm* $(TARGET_DIR)/lib

This is unusual. Can't you use the default install make target like the
staging install? Why do you install in /lib on target when upstream
installs in /usr/lib on staging?

If this is all intended please explain why in a comment.

baruch

> +endef
> +
> +$(eval $(cmake-package))
Louis-Paul Cordier Jan. 21, 2019, 1:11 p.m. UTC | #2
Hi,



The default install target is installing a bunch of header files on the target, while unecessary. Maybe Buildroot scripts are cleaning them before creating the image?



Concerning the /lib folder, it is an error indeed. It must be in /usr/lib. Any other suggestions? This is my first contribution to the Buildroot project ;)



Thank you for your feedback!



De : Baruch Siach <baruch@tkos.co.il>
À : Louis-Paul Cordier <lpdev@cordier.org>
Sujet : Re: [Buildroot] [PATCH 1/6] intel-gmmlib: new package.
Date : 19/01/2019 19:29:31 Europe/Paris
Copie à : buildroot@buildroot.org;
   Bernd Kuhls <bernd.kuhls@t-online.de>;
   Mahyar Koshkouei <mahyar.koshkouei@gmail.com>

Hi Louis-Paul,

On Fri, Jan 18 2019, Louis-Paul Cordier wrote:
> Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
> ---
> package/Config.in | 1 +
> package/intel-gmmlib/Config.in | 8 ++++++++
> package/intel-gmmlib/intel-gmmlib.hash | 2 ++
> package/intel-gmmlib/intel-gmmlib.mk | 21 +++++++++++++++++++++
> 4 files changed, 32 insertions(+)
> create mode 100644 package/intel-gmmlib/Config.in
> create mode 100644 package/intel-gmmlib/intel-gmmlib.hash
> create mode 100644 package/intel-gmmlib/intel-gmmlib.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 5036421a73..9082ed9956 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1265,6 +1265,7 @@ menu "Graphics"
> source "package/harfbuzz/Config.in"
> source "package/ijs/Config.in"
> source "package/imlib2/Config.in"
> + source "package/intel-gmmlib/Config.in"
> source "package/irrlicht/Config.in"
> source "package/jasper/Config.in"
> source "package/jpeg/Config.in"
> diff --git a/package/intel-gmmlib/Config.in b/package/intel-gmmlib/Config.in
> new file mode 100644
> index 0000000000..8d9fab7ce3
> --- /dev/null
> +++ b/package/intel-gmmlib/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_INTEL_GMMLIB
> + bool "intel-gmmlib"
> + depends on BR2_x86_64
> + help
> + The Intel(R) Graphics Memory Management Library provides
> + device specific and buffer management for the Intel(R)
> + Graphics Compute Runtime for OpenCL(TM) and the Intel(R)
> + Media Driver for VAAPI.
> diff --git a/package/intel-gmmlib/intel-gmmlib.hash b/package/intel-gmmlib/intel-gmmlib.hash
> new file mode 100644
> index 0000000000..7e3b3dfd3f
> --- /dev/null
> +++ b/package/intel-gmmlib/intel-gmmlib.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256 e3114d7ddd429f1b9aa43a1b1d0086d881fbf4d90e4a90ab8577c369d2e3a5e1 intel-gmmlib-18.3.0.tar.gz
> diff --git a/package/intel-gmmlib/intel-gmmlib.mk b/package/intel-gmmlib/intel-gmmlib.mk
> new file mode 100644
> index 0000000000..206ea6db86
> --- /dev/null
> +++ b/package/intel-gmmlib/intel-gmmlib.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# intel-gmmlib
> +#
> +################################################################################
> +
> +INTEL_GMMLIB_VERSION = 18.3.0
> +INTEL_GMMLIB_SITE = https://github.com/intel/gmmlib/archive
> +INTEL_GMMLIB_LICENSE = MIT
> +INTEL_GMMLIB_LICENSE_FILES = COPYING
> +
> +INTEL_GMMLIB_INSTALL_STAGING = YES
> +INTEL_GMMLIB_SUPPORTS_IN_SOURCE_BUILD = NO
> +
> +INTEL_GMMLIB_CONF_OPTS += -DRUN_TEST_SUITE=OFF
> +
> +define INTEL_GMMLIB_INSTALL_TARGET_CMDS
> + cp -a $(STAGING_DIR)/usr/lib/libigdgmm* $(TARGET_DIR)/lib

This is unusual. Can't you use the default install make target like the
staging install? Why do you install in /lib on target when upstream
installs in /usr/lib on staging?

If this is all intended please explain why in a comment.

baruch

> +endef
> +
> +$(eval $(cmake-package))
Baruch Siach Jan. 22, 2019, 12:57 p.m. UTC | #3
Hi Louis-Paul,

Please avoid top-posting.

On Mon, Jan 21 2019, lpdev wrote:
> The default install target is installing a bunch of header files on
> the target, while unecessary. Maybe Buildroot scripts are cleaning
> them before creating the image?

Correct. See the target-finalize target definition in the top level
Makefile.

> Concerning the /lib folder, it is an error indeed. It must be in
> /usr/lib. Any other suggestions?

Just leave the libraries where upstream install target put them.

> This is my first contribution to the Buildroot project ;)

Thanks for you contribution. This is not bad for first time.

Good luck,
baruch

>> Thank you for your feedback!
>
> De : Baruch Siach <baruch@tkos.co.il>
> À : Louis-Paul Cordier <lpdev@cordier.org>
> Sujet : Re: [Buildroot] [PATCH 1/6] intel-gmmlib: new package.
> Date : 19/01/2019 19:29:31 Europe/Paris
> Copie à : buildroot@buildroot.org;
> Bernd Kuhls <bernd.kuhls@t-online.de>;
> Mahyar Koshkouei <mahyar.koshkouei@gmail.com>
>
> Hi Louis-Paul,
>
> On Fri, Jan 18 2019, Louis-Paul Cordier wrote:
>> Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
>> ---
>> package/Config.in | 1 +
>> package/intel-gmmlib/Config.in | 8 ++++++++
>> package/intel-gmmlib/intel-gmmlib.hash | 2 ++
>> package/intel-gmmlib/intel-gmmlib.mk | 21 +++++++++++++++++++++
>> 4 files changed, 32 insertions(+)
>> create mode 100644 package/intel-gmmlib/Config.in
>> create mode 100644 package/intel-gmmlib/intel-gmmlib.hash
>> create mode 100644 package/intel-gmmlib/intel-gmmlib.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 5036421a73..9082ed9956 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -1265,6 +1265,7 @@ menu "Graphics"
>> source "package/harfbuzz/Config.in"
>> source "package/ijs/Config.in"
>> source "package/imlib2/Config.in"
>> + source "package/intel-gmmlib/Config.in"
>> source "package/irrlicht/Config.in"
>> source "package/jasper/Config.in"
>> source "package/jpeg/Config.in"
>> diff --git a/package/intel-gmmlib/Config.in b/package/intel-gmmlib/Config.in
>> new file mode 100644
>> index 0000000000..8d9fab7ce3
>> --- /dev/null
>> +++ b/package/intel-gmmlib/Config.in
>> @@ -0,0 +1,8 @@
>> +config BR2_PACKAGE_INTEL_GMMLIB
>> + bool "intel-gmmlib"
>> + depends on BR2_x86_64
>> + help
>> + The Intel(R) Graphics Memory Management Library provides
>> + device specific and buffer management for the Intel(R)
>> + Graphics Compute Runtime for OpenCL(TM) and the Intel(R)
>> + Media Driver for VAAPI.
>> diff --git a/package/intel-gmmlib/intel-gmmlib.hash b/package/intel-gmmlib/intel-gmmlib.hash
>> new file mode 100644
>> index 0000000000..7e3b3dfd3f
>> --- /dev/null
>> +++ b/package/intel-gmmlib/intel-gmmlib.hash
>> @@ -0,0 +1,2 @@
>> +# Locally computed
>> +sha256 e3114d7ddd429f1b9aa43a1b1d0086d881fbf4d90e4a90ab8577c369d2e3a5e1 intel-gmmlib-18.3.0.tar.gz
>> diff --git a/package/intel-gmmlib/intel-gmmlib.mk b/package/intel-gmmlib/intel-gmmlib.mk
>> new file mode 100644
>> index 0000000000..206ea6db86
>> --- /dev/null
>> +++ b/package/intel-gmmlib/intel-gmmlib.mk
>> @@ -0,0 +1,21 @@
>> +################################################################################
>> +#
>> +# intel-gmmlib
>> +#
>> +################################################################################
>> +
>> +INTEL_GMMLIB_VERSION = 18.3.0
>> +INTEL_GMMLIB_SITE = https://github.com/intel/gmmlib/archive
>> +INTEL_GMMLIB_LICENSE = MIT
>> +INTEL_GMMLIB_LICENSE_FILES = COPYING
>> +
>> +INTEL_GMMLIB_INSTALL_STAGING = YES
>> +INTEL_GMMLIB_SUPPORTS_IN_SOURCE_BUILD = NO
>> +
>> +INTEL_GMMLIB_CONF_OPTS += -DRUN_TEST_SUITE=OFF
>> +
>> +define INTEL_GMMLIB_INSTALL_TARGET_CMDS
>> + cp -a $(STAGING_DIR)/usr/lib/libigdgmm* $(TARGET_DIR)/lib
>
> This is unusual. Can't you use the default install make target like the
> staging install? Why do you install in /lib on target when upstream
> installs in /usr/lib on staging?
>
> If this is all intended please explain why in a comment.
>
> baruch
>
>> +endef
>> +
>> +$(eval $(cmake-package))


--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Louis-Paul Cordier Jan. 28, 2019, 7:57 p.m. UTC | #4
On Jan 22 2019, at 1:57 pm, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Louis-Paul,
>
> Please avoid top-posting.
> On Mon, Jan 21 2019, lpdev wrote:
> > The default install target is installing a bunch of header files on
> > the target, while unecessary. Maybe Buildroot scripts are cleaning
> > them before creating the image?
>
>
> Correct. See the target-finalize target definition in the top level
> Makefile.
>
> > Concerning the /lib folder, it is an error indeed. It must be in
> > /usr/lib. Any other suggestions?
>
>
> Just leave the libraries where upstream install target put them.
> > This is my first contribution to the Buildroot project ;)
> Thanks for you contribution. This is not bad for first time.
> Good luck,
> baruch
>
> > > Thank you for your feedback!
> > De : Baruch Siach <baruch@tkos.co.il>
> > À : Louis-Paul Cordier <lpdev@cordier.org>
> > Sujet : Re: [Buildroot] [PATCH 1/6] intel-gmmlib: new package.
> > Date : 19/01/2019 19:29:31 Europe/Paris
> > Copie à : buildroot@buildroot.org;
> > Bernd Kuhls <bernd.kuhls@t-online.de>;
> > Mahyar Koshkouei <mahyar.koshkouei@gmail.com>
> >
> > Hi Louis-Paul,
> > On Fri, Jan 18 2019, Louis-Paul Cordier wrote:
> > > Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
> > > ---
> > > package/Config.in | 1 +
> > > package/intel-gmmlib/Config.in | 8 ++++++++
> > > package/intel-gmmlib/intel-gmmlib.hash | 2 ++
> > > package/intel-gmmlib/intel-gmmlib.mk | 21 +++++++++++++++++++++
> > > 4 files changed, 32 insertions(+)
> > > create mode 100644 package/intel-gmmlib/Config.in
> > > create mode 100644 package/intel-gmmlib/intel-gmmlib.hash
> > > create mode 100644 package/intel-gmmlib/intel-gmmlib.mk
> > >
> > > diff --git a/package/Config.in b/package/Config.in
> > > index 5036421a73..9082ed9956 100644
> > > --- a/package/Config.in
> > > +++ b/package/Config.in
> > > @@ -1265,6 +1265,7 @@ menu "Graphics"
> > > source "package/harfbuzz/Config.in"
> > > source "package/ijs/Config.in"
> > > source "package/imlib2/Config.in"
> > > + source "package/intel-gmmlib/Config.in"
> > > source "package/irrlicht/Config.in"
> > > source "package/jasper/Config.in"
> > > source "package/jpeg/Config.in"
> > > diff --git a/package/intel-gmmlib/Config.in b/package/intel-gmmlib/Config.in
> > > new file mode 100644
> > > index 0000000000..8d9fab7ce3
> > > --- /dev/null
> > > +++ b/package/intel-gmmlib/Config.in
> > > @@ -0,0 +1,8 @@
> > > +config BR2_PACKAGE_INTEL_GMMLIB
> > > + bool "intel-gmmlib"
> > > + depends on BR2_x86_64
> > > + help
> > > + The Intel(R) Graphics Memory Management Library provides
> > > + device specific and buffer management for the Intel(R)
> > > + Graphics Compute Runtime for OpenCL(TM) and the Intel(R)
> > > + Media Driver for VAAPI.
> > > diff --git a/package/intel-gmmlib/intel-gmmlib.hash b/package/intel-gmmlib/intel-gmmlib.hash
> > > new file mode 100644
> > > index 0000000000..7e3b3dfd3f
> > > --- /dev/null
> > > +++ b/package/intel-gmmlib/intel-gmmlib.hash
> > > @@ -0,0 +1,2 @@
> > > +# Locally computed
> > > +sha256 e3114d7ddd429f1b9aa43a1b1d0086d881fbf4d90e4a90ab8577c369d2e3a5e1 intel-gmmlib-18.3.0.tar.gz
> > > diff --git a/package/intel-gmmlib/intel-gmmlib.mk b/package/intel-gmmlib/intel-gmmlib.mk
> > > new file mode 100644
> > > index 0000000000..206ea6db86
> > > --- /dev/null
> > > +++ b/package/intel-gmmlib/intel-gmmlib.mk
> > > @@ -0,0 +1,21 @@
> > > +################################################################################
> > > +#
> > > +# intel-gmmlib
> > > +#
> > > +################################################################################
> > > +
> > > +INTEL_GMMLIB_VERSION = 18.3.0
> > > +INTEL_GMMLIB_SITE = https://github.com/intel/gmmlib/archive
> > > +INTEL_GMMLIB_LICENSE = MIT
> > > +INTEL_GMMLIB_LICENSE_FILES = COPYING
> > > +
> > > +INTEL_GMMLIB_INSTALL_STAGING = YES
> > > +INTEL_GMMLIB_SUPPORTS_IN_SOURCE_BUILD = NO
> > > +
> > > +INTEL_GMMLIB_CONF_OPTS += -DRUN_TEST_SUITE=OFF
> > > +
> > > +define INTEL_GMMLIB_INSTALL_TARGET_CMDS
> > > + cp -a $(STAGING_DIR)/usr/lib/libigdgmm* $(TARGET_DIR)/lib
> >
> >
> > This is unusual. Can't you use the default install make target like the
> > staging install? Why do you install in /lib on target when upstream
> > installs in /usr/lib on staging?
> >
> > If this is all intended please explain why in a comment.
> > baruch
> > > +endef
> > > +
> > > +$(eval $(cmake-package))
> >
>
>
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
>

Thank you for your feedback. I will fix everything on tomorrow. Any hope to see these patches in the upcoming 2019.02?
Louis-Paul
<br><div class="gmail_quote_attribution">On Jan 22 2019, at 1:57 pm, Baruch Siach &lt;baruch@tkos.co.il&gt; wrote:</div><blockquote><div><div>Hi Louis-Paul,</div><br><div>Please avoid top-posting.</div><br><div>On Mon, Jan 21 2019, lpdev wrote:</div><blockquote><div>The default install target is installing a bunch of header files on</div><div>the target, while unecessary. Maybe Buildroot scripts are cleaning</div><div>them before creating the image?</div></blockquote><br><div>Correct. See the target-finalize target definition in the top level</div><div>Makefile.</div><br><blockquote><div>Concerning the /lib folder, it is an error indeed. It must be in</div><div>/usr/lib. Any other suggestions?</div></blockquote><br><div>Just leave the libraries where upstream install target put them.</div><br><blockquote><div>This is my first contribution to the Buildroot project ;)</div></blockquote><br><div>Thanks for you contribution. This is not bad for first time.</div><br><div>Good luck,</div><div>baruch</div><br><blockquote><blockquote><div>Thank you for your feedback!</div></blockquote><br><div>De : Baruch Siach &lt;baruch@tkos.co.il&gt;</div><div>À : Louis-Paul Cordier &lt;lpdev@cordier.org&gt;</div><div>Sujet : Re: [Buildroot] [PATCH 1/6] intel-gmmlib: new package.</div><div>Date : 19/01/2019 19:29:31 Europe/Paris</div><div>Copie à : buildroot@buildroot.org;</div><div>Bernd Kuhls &lt;bernd.kuhls@t-online.de&gt;;</div><div>Mahyar Koshkouei &lt;mahyar.koshkouei@gmail.com&gt;</div><br><div>Hi Louis-Paul,</div><br><div>On Fri, Jan 18 2019, Louis-Paul Cordier wrote:</div><blockquote><div>Signed-off-by: Louis-Paul Cordier &lt;lpdev@cordier.org&gt;</div><div>---</div><div>package/Config.in | 1 +</div><div>package/intel-gmmlib/Config.in | 8 ++++++++</div><div>package/intel-gmmlib/intel-gmmlib.hash | 2 ++</div><div>package/intel-gmmlib/intel-gmmlib.mk | 21 +++++++++++++++++++++</div><div>4 files changed, 32 insertions(+)</div><div>create mode 100644 package/intel-gmmlib/Config.in</div><div>create mode 100644 package/intel-gmmlib/intel-gmmlib.hash</div><div>create mode 100644 package/intel-gmmlib/intel-gmmlib.mk</div><br><div>diff --git a/package/Config.in b/package/Config.in</div><div>index 5036421a73..9082ed9956 100644</div><div>--- a/package/Config.in</div><div>+++ b/package/Config.in</div><div>@@ -1265,6 +1265,7 @@ menu "Graphics"</div><div>source "package/harfbuzz/Config.in"</div><div>source "package/ijs/Config.in"</div><div>source "package/imlib2/Config.in"</div><div>+ source "package/intel-gmmlib/Config.in"</div><div>source "package/irrlicht/Config.in"</div><div>source "package/jasper/Config.in"</div><div>source "package/jpeg/Config.in"</div><div>diff --git a/package/intel-gmmlib/Config.in b/package/intel-gmmlib/Config.in</div><div>new file mode 100644</div><div>index 0000000000..8d9fab7ce3</div><div>--- /dev/null</div><div>+++ b/package/intel-gmmlib/Config.in</div><div>@@ -0,0 +1,8 @@</div><div>+config BR2_PACKAGE_INTEL_GMMLIB</div><div>+ bool "intel-gmmlib"</div><div>+ depends on BR2_x86_64</div><div>+ help</div><div>+ The Intel(R) Graphics Memory Management Library provides</div><div>+ device specific and buffer management for the Intel(R)</div><div>+ Graphics Compute Runtime for OpenCL(TM) and the Intel(R)</div><div>+ Media Driver for VAAPI.</div><div>diff --git a/package/intel-gmmlib/intel-gmmlib.hash b/package/intel-gmmlib/intel-gmmlib.hash</div><div>new file mode 100644</div><div>index 0000000000..7e3b3dfd3f</div><div>--- /dev/null</div><div>+++ b/package/intel-gmmlib/intel-gmmlib.hash</div><div>@@ -0,0 +1,2 @@</div><div>+# Locally computed</div><div>+sha256 e3114d7ddd429f1b9aa43a1b1d0086d881fbf4d90e4a90ab8577c369d2e3a5e1 intel-gmmlib-18.3.0.tar.gz</div><div>diff --git a/package/intel-gmmlib/intel-gmmlib.mk b/package/intel-gmmlib/intel-gmmlib.mk</div><div>new file mode 100644</div><div>index 0000000000..206ea6db86</div><div>--- /dev/null</div><div>+++ b/package/intel-gmmlib/intel-gmmlib.mk</div><div>@@ -0,0 +1,21 @@</div><div>+################################################################################</div><div>+#</div><div>+# intel-gmmlib</div><div>+#</div><div>+################################################################################</div><div>+</div><div>+INTEL_GMMLIB_VERSION = 18.3.0</div><div>+INTEL_GMMLIB_SITE = https://github.com/intel/gmmlib/archive</div><div>+INTEL_GMMLIB_LICENSE = MIT</div><div>+INTEL_GMMLIB_LICENSE_FILES = COPYING</div><div>+</div><div>+INTEL_GMMLIB_INSTALL_STAGING = YES</div><div>+INTEL_GMMLIB_SUPPORTS_IN_SOURCE_BUILD = NO</div><div>+</div><div>+INTEL_GMMLIB_CONF_OPTS += -DRUN_TEST_SUITE=OFF</div><div>+</div><div>+define INTEL_GMMLIB_INSTALL_TARGET_CMDS</div><div>+ cp -a $(STAGING_DIR)/usr/lib/libigdgmm* $(TARGET_DIR)/lib</div></blockquote><br><div>This is unusual. Can't you use the default install make target like the</div><div>staging install? Why do you install in /lib on target when upstream</div><div>installs in /usr/lib on staging?</div><br><div>If this is all intended please explain why in a comment.</div><br><div>baruch</div><br><blockquote><div>+endef</div><div>+</div><div>+$(eval $(cmake-package))</div></blockquote></blockquote><br><br><div>--</div><div>http://baruch.siach.name/blog/ ~. .~ Tk Open Systems</div><div>=}------------------------------------------------ooO--U--Ooo------------{=</div><div>- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -</div></div></blockquote><br><div>Thank you for your feedback. I will fix everything on tomorrow. Any hope to see these patches in the upcoming 2019.02?</div><br><div>Louis-Paul</div>
Baruch Siach Jan. 30, 2019, 8:36 a.m. UTC | #5
Hi Louis-Paul,

On Mon, Jan 28, 2019 at 08:57:52PM +0100, LP C wrote:
> Thank you for your feedback. I will fix everything on tomorrow. Any hope to 
> see these patches in the upcoming 2019.02?

The schedule for 2019.02 is a little tight. Especially since the packages you 
add are not so simple. A few more iterations will probably be needed.

baruch

Patch
diff mbox series

diff --git a/package/Config.in b/package/Config.in
index 5036421a73..9082ed9956 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1265,6 +1265,7 @@  menu "Graphics"
 	source "package/harfbuzz/Config.in"
 	source "package/ijs/Config.in"
 	source "package/imlib2/Config.in"
+	source "package/intel-gmmlib/Config.in"
 	source "package/irrlicht/Config.in"
 	source "package/jasper/Config.in"
 	source "package/jpeg/Config.in"
diff --git a/package/intel-gmmlib/Config.in b/package/intel-gmmlib/Config.in
new file mode 100644
index 0000000000..8d9fab7ce3
--- /dev/null
+++ b/package/intel-gmmlib/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_INTEL_GMMLIB
+	bool "intel-gmmlib"
+	depends on BR2_x86_64
+	help
+	  The Intel(R) Graphics Memory Management Library provides
+	  device specific and buffer management for the Intel(R)
+	  Graphics Compute Runtime for OpenCL(TM) and the Intel(R)
+	  Media Driver for VAAPI.
diff --git a/package/intel-gmmlib/intel-gmmlib.hash b/package/intel-gmmlib/intel-gmmlib.hash
new file mode 100644
index 0000000000..7e3b3dfd3f
--- /dev/null
+++ b/package/intel-gmmlib/intel-gmmlib.hash
@@ -0,0 +1,2 @@ 
+# Locally computed
+sha256 e3114d7ddd429f1b9aa43a1b1d0086d881fbf4d90e4a90ab8577c369d2e3a5e1  intel-gmmlib-18.3.0.tar.gz
diff --git a/package/intel-gmmlib/intel-gmmlib.mk b/package/intel-gmmlib/intel-gmmlib.mk
new file mode 100644
index 0000000000..206ea6db86
--- /dev/null
+++ b/package/intel-gmmlib/intel-gmmlib.mk
@@ -0,0 +1,21 @@ 
+################################################################################
+#
+# intel-gmmlib
+#
+################################################################################
+
+INTEL_GMMLIB_VERSION = 18.3.0
+INTEL_GMMLIB_SITE = https://github.com/intel/gmmlib/archive
+INTEL_GMMLIB_LICENSE = MIT
+INTEL_GMMLIB_LICENSE_FILES = COPYING
+
+INTEL_GMMLIB_INSTALL_STAGING = YES
+INTEL_GMMLIB_SUPPORTS_IN_SOURCE_BUILD = NO
+
+INTEL_GMMLIB_CONF_OPTS += -DRUN_TEST_SUITE=OFF
+
+define INTEL_GMMLIB_INSTALL_TARGET_CMDS
+	cp -a $(STAGING_DIR)/usr/lib/libigdgmm* $(TARGET_DIR)/lib
+endef
+
+$(eval $(cmake-package))