Patchwork mtd: tmio_nand: fix build error

login
register
mail settings
Submitter Axel Lin
Date June 30, 2011, 4:34 a.m.
Message ID <1309408494.10500.1.camel@phoenix>
Download mbox | patch
Permalink /patch/102701/
State New
Headers show

Comments

Axel Lin - June 30, 2011, 4:34 a.m.
Fix a mistake introduced by commit 33f4a3b
"mtd: tmio_nand.c: use mtd_device_parse_register"

  CC [M]  drivers/mtd/nand/tmio_nand.o
drivers/mtd/nand/tmio_nand.c:461:35: error: macro "mtd_device_register" passed 5 arguments, but takes just 3
drivers/mtd/nand/tmio_nand.c: In function 'tmio_probe':
drivers/mtd/nand/tmio_nand.c:459: error: 'mtd_device_register' undeclared (first use in this function)
drivers/mtd/nand/tmio_nand.c:459: error: (Each undeclared identifier is reported only once
drivers/mtd/nand/tmio_nand.c:459: error: for each function it appears in.)
make[3]: *** [drivers/mtd/nand/tmio_nand.o] Error 1
make[2]: *** [drivers/mtd/nand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/mtd/nand/tmio_nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Dmitry Eremin-Solenikov - June 30, 2011, 8:23 a.m.
On 6/30/11, Axel Lin <axel.lin@gmail.com> wrote:
> Fix a mistake introduced by commit 33f4a3b
> "mtd: tmio_nand.c: use mtd_device_parse_register"

Already sumbited 27 June 2011. Strangely Artem remains silent.

>   CC [M]  drivers/mtd/nand/tmio_nand.o
> drivers/mtd/nand/tmio_nand.c:461:35: error: macro "mtd_device_register"
> passed 5 arguments, but takes just 3
> drivers/mtd/nand/tmio_nand.c: In function 'tmio_probe':
> drivers/mtd/nand/tmio_nand.c:459: error: 'mtd_device_register' undeclared
> (first use in this function)
> drivers/mtd/nand/tmio_nand.c:459: error: (Each undeclared identifier is
> reported only once
> drivers/mtd/nand/tmio_nand.c:459: error: for each function it appears in.)
> make[3]: *** [drivers/mtd/nand/tmio_nand.o] Error 1
> make[2]: *** [drivers/mtd/nand] Error 2
> make[1]: *** [drivers/mtd] Error 2
> make: *** [drivers] Error 2
Artem Bityutskiy - June 30, 2011, 12:08 p.m.
On Thu, 2011-06-30 at 12:23 +0400, Dmitry Eremin-Solenikov wrote:
> On 6/30/11, Axel Lin <axel.lin@gmail.com> wrote:
> > Fix a mistake introduced by commit 33f4a3b
> > "mtd: tmio_nand.c: use mtd_device_parse_register"
> 
> Already sumbited 27 June 2011. Strangely Artem remains silent.

I handle my mailbox in FIFO order (with exceptions) so I have not
reached your patch yet. Now I've merged it with one of your previous
patches to keep the kernel bisectable.

Thanks!
Dmitry Eremin-Solenikov - June 30, 2011, 12:41 p.m.
On 6/30/11, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Thu, 2011-06-30 at 12:23 +0400, Dmitry Eremin-Solenikov wrote:
>> On 6/30/11, Axel Lin <axel.lin@gmail.com> wrote:
>> > Fix a mistake introduced by commit 33f4a3b
>> > "mtd: tmio_nand.c: use mtd_device_parse_register"
>>
>> Already sumbited 27 June 2011. Strangely Artem remains silent.
>
> I handle my mailbox in FIFO order (with exceptions) so I have not
> reached your patch yet. Now I've merged it with one of your previous
> patches to keep the kernel bisectable.

Thanks and sorry if my comment offended you! It's just I see most of
MLs/patches in threads, so I was a bit puzzled.

Patch

diff --git a/drivers/mtd/nand/tmio_nand.c b/drivers/mtd/nand/tmio_nand.c
index d476857..beebd95 100644
--- a/drivers/mtd/nand/tmio_nand.c
+++ b/drivers/mtd/nand/tmio_nand.c
@@ -456,7 +456,7 @@  static int tmio_probe(struct platform_device *dev)
 		goto err_scan;
 	}
 	/* Register the partitions */
-	retval = mtd_device_register(mtd, NULL, 0,
+	retval = mtd_device_parse_register(mtd, NULL, 0,
 			data ? data->partition : NULL,
 			data ? data->num_partitions : 0);
 	if (!retval)