| Message ID | 20190117185628.21862-9-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Acceptance Tests: target architecture support | expand |
On Thu, Jan 17, 2019 at 01:56:18PM -0500, Cleber Rosa wrote: > Given that the test is specific to x86_64 and pc, and new tests are > going to be added to the same class, let's rename it accordingly. > Also, let's make the class documentation not architecture specific. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Caio Carrara <ccarrara@redhat.com> > --- > tests/acceptance/boot_linux_console.py | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 46b20bdfe2..89df7f6e4f 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -15,16 +15,19 @@ from avocado_qemu import Test > > class BootLinuxConsole(Test): > """ > - Boots a x86_64 Linux kernel and checks that the console is operational > - and the kernel command line is properly passed from QEMU to the kernel > + Boots a Linux kernel and checks that the console is operational and the > + kernel command line is properly passed from QEMU to the kernel > > :avocado: enable > - :avocado: tags=arch:x86_64 > """ > > timeout = 60 > > - def test(self): > + def test_x86_64_pc(self): > + """ > + :avocado: tags=arch:x86_64 > + :avocado: tags=machine:pc > + """ > kernel_url = ('https://mirrors.kernel.org/fedora/releases/28/' > 'Everything/x86_64/os/images/pxeboot/vmlinuz') > kernel_hash = '238e083e114c48200f80d889f7e32eeb2793e02a' > -- > 2.20.1 >
On 1/17/19 7:56 PM, Cleber Rosa wrote: > Given that the test is specific to x86_64 and pc, and new tests are > going to be added to the same class, let's rename it accordingly. > Also, let's make the class documentation not architecture specific. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/boot_linux_console.py | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 46b20bdfe2..89df7f6e4f 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -15,16 +15,19 @@ from avocado_qemu import Test > > class BootLinuxConsole(Test): > """ > - Boots a x86_64 Linux kernel and checks that the console is operational > - and the kernel command line is properly passed from QEMU to the kernel > + Boots a Linux kernel and checks that the console is operational and the > + kernel command line is properly passed from QEMU to the kernel > > :avocado: enable > - :avocado: tags=arch:x86_64 > """ > > timeout = 60 > > - def test(self): > + def test_x86_64_pc(self): > + """ > + :avocado: tags=arch:x86_64 > + :avocado: tags=machine:pc > + """ > kernel_url = ('https://mirrors.kernel.org/fedora/releases/28/' > 'Everything/x86_64/os/images/pxeboot/vmlinuz') > kernel_hash = '238e083e114c48200f80d889f7e32eeb2793e02a' > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index 46b20bdfe2..89df7f6e4f 100644 --- a/tests/acceptance/boot_linux_console.py +++ b/tests/acceptance/boot_linux_console.py @@ -15,16 +15,19 @@ from avocado_qemu import Test class BootLinuxConsole(Test): """ - Boots a x86_64 Linux kernel and checks that the console is operational - and the kernel command line is properly passed from QEMU to the kernel + Boots a Linux kernel and checks that the console is operational and the + kernel command line is properly passed from QEMU to the kernel :avocado: enable - :avocado: tags=arch:x86_64 """ timeout = 60 - def test(self): + def test_x86_64_pc(self): + """ + :avocado: tags=arch:x86_64 + :avocado: tags=machine:pc + """ kernel_url = ('https://mirrors.kernel.org/fedora/releases/28/' 'Everything/x86_64/os/images/pxeboot/vmlinuz') kernel_hash = '238e083e114c48200f80d889f7e32eeb2793e02a'
Given that the test is specific to x86_64 and pc, and new tests are going to be added to the same class, let's rename it accordingly. Also, let's make the class documentation not architecture specific. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/acceptance/boot_linux_console.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)