From patchwork Thu Jan 17 03:22:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tristram.Ha@microchip.com X-Patchwork-Id: 1026393 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=microchip.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43g8Wr6Tslz9sCh for ; Thu, 17 Jan 2019 14:22:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbfAQDWN (ORCPT ); Wed, 16 Jan 2019 22:22:13 -0500 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:43666 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727855AbfAQDWL (ORCPT ); Wed, 16 Jan 2019 22:22:11 -0500 X-IronPort-AV: E=Sophos;i="5.56,488,1539673200"; d="scan'208";a="25425780" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Jan 2019 20:22:10 -0700 Received: from localhost.localdomain (10.10.76.4) by chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id 14.3.352.0; Wed, 16 Jan 2019 20:22:09 -0700 From: To: Sergio Paracuellos , Marek Vasut , Andrew Lunn , Florian Fainelli , Pavel Machek , Dan Carpenter CC: Tristram Ha , , , Subject: [PATCH RFC 3/4] net: dsa: microchip: remove ksz9477_get_port_addr Date: Wed, 16 Jan 2019 19:22:05 -0800 Message-ID: <1547695326-31553-4-git-send-email-Tristram.Ha@microchip.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1547695326-31553-1-git-send-email-Tristram.Ha@microchip.com> References: <1547695326-31553-1-git-send-email-Tristram.Ha@microchip.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tristram Ha Remove ksz9477_get_port_addr as it is considered too slow and the macro PORT_CTRL_ADDR can be used directly. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz9477.c | 11 +---------- drivers/net/dsa/microchip/ksz_priv.h | 1 - 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 14b6371..3cf8ad7 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -2,12 +2,9 @@ /* * Microchip KSZ9477 switch driver main logic * - * Copyright (C) 2017-2018 Microchip Technology Inc. + * Copyright (C) 2017-2019 Microchip Technology Inc. */ -#include -#include -#include #include #include #include @@ -1157,11 +1154,6 @@ static int ksz9477_setup(struct dsa_switch *ds) .port_mirror_del = ksz9477_port_mirror_del, }; -static u32 ksz9477_get_port_addr(int port, int offset) -{ - return PORT_CTRL_ADDR(port, offset); -} - static int ksz9477_switch_detect(struct ksz_device *dev) { u8 data8; @@ -1278,7 +1270,6 @@ static void ksz9477_switch_exit(struct ksz_device *dev) } static const struct ksz_dev_ops ksz9477_dev_ops = { - .get_port_addr = ksz9477_get_port_addr, .cfg_port_member = ksz9477_cfg_port_member, .flush_dyn_mac_table = ksz9477_flush_dyn_mac_table, .port_setup = ksz9477_port_setup, diff --git a/drivers/net/dsa/microchip/ksz_priv.h b/drivers/net/dsa/microchip/ksz_priv.h index 526cd0f..00ab370 100644 --- a/drivers/net/dsa/microchip/ksz_priv.h +++ b/drivers/net/dsa/microchip/ksz_priv.h @@ -115,7 +115,6 @@ struct alu_struct { }; struct ksz_dev_ops { - u32 (*get_port_addr)(int port, int offset); void (*cfg_port_member)(struct ksz_device *dev, int port, u8 member); void (*flush_dyn_mac_table)(struct ksz_device *dev, int port); void (*port_setup)(struct ksz_device *dev, int port, bool cpu_port);