| Message ID | 20190117014936.48117-4-yangbo.lu@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | External trigger stamp fifo support for ptp_qoriq | expand |
On Thu, Jan 17, 2019 at 09:49:34AM +0800, Yangbo Lu wrote: > Documented "fsl,extts-fifo" property. > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > --- > Changes for v2: > - Modified binding description. > --- > .../devicetree/bindings/ptp/ptp-qoriq.txt | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ptp/ptp-qoriq.txt b/Documentation/devicetree/bindings/ptp/ptp-qoriq.txt > index c5d0e79..101fe5f 100644 > --- a/Documentation/devicetree/bindings/ptp/ptp-qoriq.txt > +++ b/Documentation/devicetree/bindings/ptp/ptp-qoriq.txt > @@ -17,6 +17,7 @@ Clock Properties: > - fsl,tmr-fiper1 Fixed interval period pulse generator. > - fsl,tmr-fiper2 Fixed interval period pulse generator. > - fsl,max-adj Maximum frequency adjustment in parts per billion. > + - fsl,extts-fifo Required if hardware uses external trigger stamp FIFO. Does this take a Boolean value? Please explain the semantics. Thanks, Richard
On Thu, Jan 17, 2019 at 05:34:34PM -0800, Richard Cochran wrote: > > @@ -17,6 +17,7 @@ Clock Properties: > > - fsl,tmr-fiper1 Fixed interval period pulse generator. > > - fsl,tmr-fiper2 Fixed interval period pulse generator. > > - fsl,max-adj Maximum frequency adjustment in parts per billion. > > + - fsl,extts-fifo Required if hardware uses external trigger stamp FIFO. > > Does this take a Boolean value? Please explain the semantics. How about this instead? The presence of this property indicates hardware support for the external trigger stamp FIFO. Thanks, Richard
Hi, > -----Original Message----- > From: Richard Cochran <richardcochran@gmail.com> > Sent: Friday, January 18, 2019 9:39 AM > To: Y.b. Lu <yangbo.lu@nxp.com> > Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; David S . Miller <davem@davemloft.net>; > Rob Herring <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org> > Subject: Re: [v2, 3/5] dt-binding: ptp_qoriq: document "fsl,extts-fifo" property > > On Thu, Jan 17, 2019 at 05:34:34PM -0800, Richard Cochran wrote: > > > @@ -17,6 +17,7 @@ Clock Properties: > > > - fsl,tmr-fiper1 Fixed interval period pulse generator. > > > - fsl,tmr-fiper2 Fixed interval period pulse generator. > > > - fsl,max-adj Maximum frequency adjustment in parts per billion. > > > + - fsl,extts-fifo Required if hardware uses external trigger stamp FIFO. > > > > Does this take a Boolean value? Please explain the semantics. > > How about this instead? > > The presence of this property indicates hardware support for > the external trigger stamp FIFO. [Y.b. Lu] Yes. This is a Boolean value. Thanks for good suggestion and I will use this instead. > > > Thanks, > Richard
diff --git a/Documentation/devicetree/bindings/ptp/ptp-qoriq.txt b/Documentation/devicetree/bindings/ptp/ptp-qoriq.txt index c5d0e79..101fe5f 100644 --- a/Documentation/devicetree/bindings/ptp/ptp-qoriq.txt +++ b/Documentation/devicetree/bindings/ptp/ptp-qoriq.txt @@ -17,6 +17,7 @@ Clock Properties: - fsl,tmr-fiper1 Fixed interval period pulse generator. - fsl,tmr-fiper2 Fixed interval period pulse generator. - fsl,max-adj Maximum frequency adjustment in parts per billion. + - fsl,extts-fifo Required if hardware uses external trigger stamp FIFO. These properties set the operational parameters for the PTP clock. You must choose these carefully for the clock to work right.
Documented "fsl,extts-fifo" property. Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> --- Changes for v2: - Modified binding description. --- .../devicetree/bindings/ptp/ptp-qoriq.txt | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)