From patchwork Wed Jun 29 08:37:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 102538 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 27B0AB6F57 for ; Wed, 29 Jun 2011 18:38:17 +1000 (EST) Received: (qmail 14741 invoked by alias); 29 Jun 2011 08:38:13 -0000 Received: (qmail 14592 invoked by uid 22791); 29 Jun 2011 08:38:11 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, TW_BJ X-Spam-Check-By: sourceware.org Received: from c2bthomr10.btconnect.com (HELO mail.btconnect.com) (213.123.20.128) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Jun 2011 08:37:56 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2bthomr10.btconnect.com with ESMTP id DLO99977; Wed, 29 Jun 2011 09:37:54 +0100 (BST) Cc: GCC Patches , Mike Stump , Nicola Pero Message-Id: <54655CE7-9BC3-4EC6-A2DB-47C1C336D70E@sandoe-acoustics.co.uk> From: Iain Sandoe To: Rainer Orth In-Reply-To: <459A6915-7EB3-49EC-81C8-46EC2A59745E@sandoe-acoustics.co.uk> Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: [testsuite, objc] Don't XFAIL objc.dg/torture/forward-1.m Date: Wed, 29 Jun 2011 09:37:53 +0100 References: <459A6915-7EB3-49EC-81C8-46EC2A59745E@sandoe-acoustics.co.uk> X-Mirapoint-IP-Reputation: reputation=Fair-1, source=Queried, refid=tid=0001.0A0B0303.4E0AE462.004A, actions=tag X-Junkmail-Premium-Raw: score=7/50, refid=2.7.2:2011.6.29.73915:17:7.586, ip=81.138.1.83, rules=__HAS_MSGID, __SANE_MSGID, __MSGID_APPLEMAIL, __TO_MALFORMED_2, __CT, __CT_TEXT_PLAIN, __CTE, __MIME_VERSION, __MIME_VERSION_APPLEMAIL, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __HAS_X_MAILER, __X_MAILER_APPLEMAIL, __ANY_URI, __URI_NO_WWW, __URI_NO_PATH, BODYTEXTP_SIZE_3000_LESS, BODY_SIZE_2000_2999, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, __USER_AGENT_APPLEMAIL, RDNS_SUSP, BODY_SIZE_7000_LESS X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0206.4E0AE463.010A, ss=1, fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=multiengine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 28 Jun 2011, at 18:01, Iain Sandoe wrote: > On 28 Jun 2011, at 17:47, Rainer Orth wrote: > >> objc.dg/torture/forward-1.m now seems to XPASS everywhere, creating >> an >> annoying amount of testsuite noise. Dominique provided the following >> patch in PR libobjc/Bug 36610. >> >> Tested with the appropriate runtest invocations on i386-pc- >> solaris2.10 >> (both multilibs), sparc-sun-solaris2.10 (both multilibs), >> alpha-dec-osf5.1b, mips-sgi-irix6.5 (both multilibs), >> powerpc-apple-darwin9.8.0 (32-bit only). >> >> Ok for mainline? >> >> Thanks. >> Rainer >> >> >> 2011-06-28 Dominique d'Humieres >> >> * objc.dg/torture/forward-1.m: Remove dg-xfail-run-if, dg-skip-if. >> >> Index: gcc/testsuite/objc.dg/torture/forward-1.m >> =================================================================== >> --- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175589) >> +++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy) >> @@ -1,7 +1,5 @@ >> /* { dg-do run } */ >> /* See if -forward:: is able to work. */ >> -/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } && >> ilp32 } } { "-fgnu-runtime" } { "" } } */ > >> -/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* && >> { lp64 } } { "-fnext-runtime" } { "" } } */ > > actually, looking at this, it should likely read (untested): > > /* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* && > { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ > > and should stay in place to protect the test-cases for m64 on *-*- > darwin8* > > (not that there's ever likely to be an m64 objc2 on darwin 8.. but) Just FTR, this works for me on powerpc-apple-darwin9 Iain #include #include Index: gcc/testsuite/objc.dg/torture/forward-1.m =================================================================== --- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175578) +++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy) @@ -1,7 +1,6 @@ /* { dg-do run } */ /* See if -forward:: is able to work. */ -/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } && ilp32 } } { "-fgnu-runtime" } { "" } } */ -/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* && { lp64 } } { "-fnext-runtime" } { "" } } */ +/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */