Patchwork [20/32] uninorth-agp section mess

login
register
mail settings
Submitter Al Viro
Date Nov. 22, 2008, 5:36 p.m.
Message ID <E1L3wPK-0006Ym-Kq@ZenIV.linux.org.uk>
Download mbox | patch
Permalink /patch/10245/
State Accepted
Commit b0385146bcdd24b0390c2b60fd05a083888835db
Headers show

Comments

Al Viro - Nov. 22, 2008, 5:36 p.m.
'aperture' is declared devinitdata (the whole word of it) and
is used from ->fetch_size() which can, AFAICS, be used on
!HOTPLUG after init time.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 drivers/char/agp/uninorth-agp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Benjamin Herrenschmidt - Nov. 22, 2008, 9:52 p.m.
On Sat, 2008-11-22 at 17:36 +0000, Al Viro wrote:
> 'aperture' is declared devinitdata (the whole word of it) and
> is used from ->fetch_size() which can, AFAICS, be used on
> !HOTPLUG after init time.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/char/agp/uninorth-agp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -27,7 +27,7 @@
>  static int uninorth_rev;
>  static int is_u3;
>  
> -static char __devinitdata *aperture = NULL;
> +static char *aperture = NULL;
>  
>  static int uninorth_fetch_size(void)
>  {
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Patch

diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
--- a/drivers/char/agp/uninorth-agp.c
+++ b/drivers/char/agp/uninorth-agp.c
@@ -27,7 +27,7 @@ 
 static int uninorth_rev;
 static int is_u3;
 
-static char __devinitdata *aperture = NULL;
+static char *aperture = NULL;
 
 static int uninorth_fetch_size(void)
 {