Patchwork ext4: Documenatation: remove acl and user_xattr mount options

login
register
mail settings
Submitter Lukas Czerner
Date June 28, 2011, 3:21 p.m.
Message ID <1309274477-451-1-git-send-email-lczerner@redhat.com>
Download mbox | patch
Permalink /patch/102405/
State Not Applicable
Headers show

Comments

Lukas Czerner - June 28, 2011, 3:21 p.m.
Acl and user_xattr mount options are no longer needed since those
features are enabled by default if configured in (seee commit
ea6633369458992241599c9d9ebadffaeddec164). We can not easily
deprecate mount options itself (since it is probably too early),
but we can remove it from documentation first.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
 Documentation/filesystems/ext4.txt |   25 +++++++++++--------------
 1 files changed, 11 insertions(+), 14 deletions(-)
Lukas Czerner - Aug. 11, 2011, 2:56 p.m.
On Tue, 28 Jun 2011, Lukas Czerner wrote:

> Acl and user_xattr mount options are no longer needed since those
> features are enabled by default if configured in (seee commit
> ea6633369458992241599c9d9ebadffaeddec164). We can not easily
> deprecate mount options itself (since it is probably too early),
> but we can remove it from documentation first.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

Hi Ted,

any chance picking that up ?

Thanks!
-Lukas

> ---
>  Documentation/filesystems/ext4.txt |   25 +++++++++++--------------
>  1 files changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
> index 3ae9bc9..9544e2c 100644
> --- a/Documentation/filesystems/ext4.txt
> +++ b/Documentation/filesystems/ext4.txt
> @@ -209,22 +209,19 @@ oldalloc		This disables the Orlov block allocator and enables
>  			performance - we'd like to get some feedback if it's
>  			the contrary for you.
>  
> -user_xattr		Enables Extended User Attributes.  Additionally, you
> -			need to have extended attribute support enabled in the
> -			kernel configuration (CONFIG_EXT4_FS_XATTR).  See the
> -			attr(5) manual page and http://acl.bestbits.at/ to
> -			learn more about extended attributes.
> -
> -nouser_xattr		Disables Extended User Attributes.
> -
> -acl			Enables POSIX Access Control Lists support.
> -			Additionally, you need to have ACL support enabled in
> -			the kernel configuration (CONFIG_EXT4_FS_POSIX_ACL).
> -			See the acl(5) manual page and http://acl.bestbits.at/
> -			for more information.
> +nouser_xattr		Disables Extended User Attributes. If you have extended
> +			attribute support enabled in the kernel configuration
> +			(CONFIG_EXT4_FS_XATTR), extended attribute support
> +			is enabled by default on mount. See the attr(5) manual
> +			page and http://acl.bestbits.at/ for more information
> +			about extended attributes.
>  
>  noacl			This option disables POSIX Access Control List
> -			support.
> +			support. If ACL support is enabled in the kernel
> +			configuration (CONFIG_EXT4_FS_POSIX_ACL), ACL is
> +			enabled by default on mount. See the acl(5) manual
> +			page and http://acl.bestbits.at/ for more information
> +			about acl.
>  
>  bsddf		(*)	Make 'df' act like BSD.
>  minixdf			Make 'df' act like Minix.
>
Lukas Czerner - Sept. 1, 2011, 8:38 a.m.
On Thu, 11 Aug 2011, Lukas Czerner wrote:

> On Tue, 28 Jun 2011, Lukas Czerner wrote:
> 
> > Acl and user_xattr mount options are no longer needed since those
> > features are enabled by default if configured in (seee commit
> > ea6633369458992241599c9d9ebadffaeddec164). We can not easily
> > deprecate mount options itself (since it is probably too early),
> > but we can remove it from documentation first.
> > 
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> 
> Hi Ted,
> 
> any chance picking that up ?
> 
> Thanks!
> -Lukas

ping^2

> 
> > ---
> >  Documentation/filesystems/ext4.txt |   25 +++++++++++--------------
> >  1 files changed, 11 insertions(+), 14 deletions(-)
> > 
> > diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
> > index 3ae9bc9..9544e2c 100644
> > --- a/Documentation/filesystems/ext4.txt
> > +++ b/Documentation/filesystems/ext4.txt
> > @@ -209,22 +209,19 @@ oldalloc		This disables the Orlov block allocator and enables
> >  			performance - we'd like to get some feedback if it's
> >  			the contrary for you.
> >  
> > -user_xattr		Enables Extended User Attributes.  Additionally, you
> > -			need to have extended attribute support enabled in the
> > -			kernel configuration (CONFIG_EXT4_FS_XATTR).  See the
> > -			attr(5) manual page and http://acl.bestbits.at/ to
> > -			learn more about extended attributes.
> > -
> > -nouser_xattr		Disables Extended User Attributes.
> > -
> > -acl			Enables POSIX Access Control Lists support.
> > -			Additionally, you need to have ACL support enabled in
> > -			the kernel configuration (CONFIG_EXT4_FS_POSIX_ACL).
> > -			See the acl(5) manual page and http://acl.bestbits.at/
> > -			for more information.
> > +nouser_xattr		Disables Extended User Attributes. If you have extended
> > +			attribute support enabled in the kernel configuration
> > +			(CONFIG_EXT4_FS_XATTR), extended attribute support
> > +			is enabled by default on mount. See the attr(5) manual
> > +			page and http://acl.bestbits.at/ for more information
> > +			about extended attributes.
> >  
> >  noacl			This option disables POSIX Access Control List
> > -			support.
> > +			support. If ACL support is enabled in the kernel
> > +			configuration (CONFIG_EXT4_FS_POSIX_ACL), ACL is
> > +			enabled by default on mount. See the acl(5) manual
> > +			page and http://acl.bestbits.at/ for more information
> > +			about acl.
> >  
> >  bsddf		(*)	Make 'df' act like BSD.
> >  minixdf			Make 'df' act like Minix.
> > 
> 
>
Lukas Czerner - Oct. 5, 2011, 2:33 p.m.
On Thu, 1 Sep 2011, Lukas Czerner wrote:

> On Thu, 11 Aug 2011, Lukas Czerner wrote:
> 
> > On Tue, 28 Jun 2011, Lukas Czerner wrote:
> > 
> > > Acl and user_xattr mount options are no longer needed since those
> > > features are enabled by default if configured in (seee commit
> > > ea6633369458992241599c9d9ebadffaeddec164). We can not easily
> > > deprecate mount options itself (since it is probably too early),
> > > but we can remove it from documentation first.
> > > 
> > > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> > 
> > Hi Ted,
> > 
> > any chance picking that up ?
> > 
> > Thanks!
> > -Lukas
> 
> ping^2

ping^3 
> 
> > 
> > > ---
> > >  Documentation/filesystems/ext4.txt |   25 +++++++++++--------------
> > >  1 files changed, 11 insertions(+), 14 deletions(-)
> > > 
> > > diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
> > > index 3ae9bc9..9544e2c 100644
> > > --- a/Documentation/filesystems/ext4.txt
> > > +++ b/Documentation/filesystems/ext4.txt
> > > @@ -209,22 +209,19 @@ oldalloc		This disables the Orlov block allocator and enables
> > >  			performance - we'd like to get some feedback if it's
> > >  			the contrary for you.
> > >  
> > > -user_xattr		Enables Extended User Attributes.  Additionally, you
> > > -			need to have extended attribute support enabled in the
> > > -			kernel configuration (CONFIG_EXT4_FS_XATTR).  See the
> > > -			attr(5) manual page and http://acl.bestbits.at/ to
> > > -			learn more about extended attributes.
> > > -
> > > -nouser_xattr		Disables Extended User Attributes.
> > > -
> > > -acl			Enables POSIX Access Control Lists support.
> > > -			Additionally, you need to have ACL support enabled in
> > > -			the kernel configuration (CONFIG_EXT4_FS_POSIX_ACL).
> > > -			See the acl(5) manual page and http://acl.bestbits.at/
> > > -			for more information.
> > > +nouser_xattr		Disables Extended User Attributes. If you have extended
> > > +			attribute support enabled in the kernel configuration
> > > +			(CONFIG_EXT4_FS_XATTR), extended attribute support
> > > +			is enabled by default on mount. See the attr(5) manual
> > > +			page and http://acl.bestbits.at/ for more information
> > > +			about extended attributes.
> > >  
> > >  noacl			This option disables POSIX Access Control List
> > > -			support.
> > > +			support. If ACL support is enabled in the kernel
> > > +			configuration (CONFIG_EXT4_FS_POSIX_ACL), ACL is
> > > +			enabled by default on mount. See the acl(5) manual
> > > +			page and http://acl.bestbits.at/ for more information
> > > +			about acl.
> > >  
> > >  bsddf		(*)	Make 'df' act like BSD.
> > >  minixdf			Make 'df' act like Minix.
> > > 
> > 
> > 
> 
>
Theodore Ts'o - Oct. 8, 2011, 6:02 p.m.
On Tue, Jun 28, 2011 at 05:21:17PM +0200, Lukas Czerner wrote:
> Acl and user_xattr mount options are no longer needed since those
> features are enabled by default if configured in (seee commit
> ea6633369458992241599c9d9ebadffaeddec164). We can not easily
> deprecate mount options itself (since it is probably too early),
> but we can remove it from documentation first.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
index 3ae9bc9..9544e2c 100644
--- a/Documentation/filesystems/ext4.txt
+++ b/Documentation/filesystems/ext4.txt
@@ -209,22 +209,19 @@  oldalloc		This disables the Orlov block allocator and enables
 			performance - we'd like to get some feedback if it's
 			the contrary for you.
 
-user_xattr		Enables Extended User Attributes.  Additionally, you
-			need to have extended attribute support enabled in the
-			kernel configuration (CONFIG_EXT4_FS_XATTR).  See the
-			attr(5) manual page and http://acl.bestbits.at/ to
-			learn more about extended attributes.
-
-nouser_xattr		Disables Extended User Attributes.
-
-acl			Enables POSIX Access Control Lists support.
-			Additionally, you need to have ACL support enabled in
-			the kernel configuration (CONFIG_EXT4_FS_POSIX_ACL).
-			See the acl(5) manual page and http://acl.bestbits.at/
-			for more information.
+nouser_xattr		Disables Extended User Attributes. If you have extended
+			attribute support enabled in the kernel configuration
+			(CONFIG_EXT4_FS_XATTR), extended attribute support
+			is enabled by default on mount. See the attr(5) manual
+			page and http://acl.bestbits.at/ for more information
+			about extended attributes.
 
 noacl			This option disables POSIX Access Control List
-			support.
+			support. If ACL support is enabled in the kernel
+			configuration (CONFIG_EXT4_FS_POSIX_ACL), ACL is
+			enabled by default on mount. See the acl(5) manual
+			page and http://acl.bestbits.at/ for more information
+			about acl.
 
 bsddf		(*)	Make 'df' act like BSD.
 minixdf			Make 'df' act like Minix.