| Message ID | 20190112175812.27068-2-eblake@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | nbd: add qemu-nbd --list | expand |
On Sat, Jan 12, 2019 at 11:57:54AM -0600, Eric Blake wrote: > The next commit will add an EXAMPLES section to qemu-nbd.8; > for that to work, we need to recognize EXAMPLES in texi2pod. > We also need to add a dependency from all man pages against > the generator script, since a change to the generator may > cause the resulting man page to differ. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > v3: add generic dependency for all man pages in $(DOCS) instead of > per-line editing [Vladimir] > --- > Makefile | 2 ++ > scripts/texi2pod.pl | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index a9ac16d94e8..e2d3ace190a 100644 > --- a/Makefile > +++ b/Makefile > @@ -857,6 +857,8 @@ docs/interop/qemu-qmp-ref.dvi docs/interop/qemu-qmp-ref.html \ > docs/interop/qemu-qmp-ref.txt docs/interop/qemu-qmp-ref.7: \ > docs/interop/qemu-qmp-ref.texi docs/interop/qemu-qmp-qapi.texi > > +$(filter %.1 %.7 %.8,$(DOCS)): scripts/texi2pod.pl Much simpler, and adds the dependencies for all applicable $(DOCS) targets as was suggested by Vladimir previously, so: Reviewed-by: Richard W.M. Jones <rjones@redhat.com> Rich. > # Reports/Analysis > > %/coverage-report.html: > diff --git a/scripts/texi2pod.pl b/scripts/texi2pod.pl > index 39ce584a322..839b7917cf7 100755 > --- a/scripts/texi2pod.pl > +++ b/scripts/texi2pod.pl > @@ -398,7 +398,7 @@ $sects{NAME} = "$fn \- $tl\n"; > $sects{FOOTNOTES} .= "=back\n" if exists $sects{FOOTNOTES}; > > for $sect (qw(NAME SYNOPSIS DESCRIPTION OPTIONS ENVIRONMENT FILES > - BUGS NOTES FOOTNOTES SEEALSO AUTHOR COPYRIGHT)) { > + BUGS NOTES FOOTNOTES EXAMPLES SEEALSO AUTHOR COPYRIGHT)) { > if(exists $sects{$sect}) { > $head = $sect; > $head =~ s/SEEALSO/SEE ALSO/; > -- > 2.20.1
diff --git a/Makefile b/Makefile index a9ac16d94e8..e2d3ace190a 100644 --- a/Makefile +++ b/Makefile @@ -857,6 +857,8 @@ docs/interop/qemu-qmp-ref.dvi docs/interop/qemu-qmp-ref.html \ docs/interop/qemu-qmp-ref.txt docs/interop/qemu-qmp-ref.7: \ docs/interop/qemu-qmp-ref.texi docs/interop/qemu-qmp-qapi.texi +$(filter %.1 %.7 %.8,$(DOCS)): scripts/texi2pod.pl + # Reports/Analysis %/coverage-report.html: diff --git a/scripts/texi2pod.pl b/scripts/texi2pod.pl index 39ce584a322..839b7917cf7 100755 --- a/scripts/texi2pod.pl +++ b/scripts/texi2pod.pl @@ -398,7 +398,7 @@ $sects{NAME} = "$fn \- $tl\n"; $sects{FOOTNOTES} .= "=back\n" if exists $sects{FOOTNOTES}; for $sect (qw(NAME SYNOPSIS DESCRIPTION OPTIONS ENVIRONMENT FILES - BUGS NOTES FOOTNOTES SEEALSO AUTHOR COPYRIGHT)) { + BUGS NOTES FOOTNOTES EXAMPLES SEEALSO AUTHOR COPYRIGHT)) { if(exists $sects{$sect}) { $head = $sect; $head =~ s/SEEALSO/SEE ALSO/;
The next commit will add an EXAMPLES section to qemu-nbd.8; for that to work, we need to recognize EXAMPLES in texi2pod. We also need to add a dependency from all man pages against the generator script, since a change to the generator may cause the resulting man page to differ. Signed-off-by: Eric Blake <eblake@redhat.com> --- v3: add generic dependency for all man pages in $(DOCS) instead of per-line editing [Vladimir] --- Makefile | 2 ++ scripts/texi2pod.pl | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)