[v1,2/8] dt-bindings: phy: qcom-ufs: Add resets property
diff mbox series

Message ID 20190111230129.127037-3-evgreen@chromium.org
State Not Applicable
Headers show
Series
  • phy: qcom-ufs: Enable regulators to be off in suspend
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Evan Green Jan. 11, 2019, 11:01 p.m. UTC
Add a resets property to the PHY that represents the PHY reset
register in the UFS controller itself. This better describes the
complete specification of the PHY, and allows the PHY to perform
its initialization in a single function, rather than relying on
back-channel sequencing of initialization through the PHY framework.

Signed-off-by: Evan Green <evgreen@chromium.org>
---

 Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Boyd Jan. 16, 2019, 9:29 p.m. UTC | #1
Quoting Evan Green (2019-01-11 15:01:23)
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
> index 21d9a93db2e97..985f5e99ab332 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
> +++ b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
> @@ -29,6 +29,7 @@ Optional properties:
>  - vdda-pll-max-microamp : specifies max. load that can be drawn from pll supply
>  - vddp-ref-clk-supply   : phandle to UFS device ref_clk pad power supply
>  - vddp-ref-clk-max-microamp : specifies max. load that can be drawn from this supply
> +- resets : specifies the PHY reset in the UFS controller

Nitpick: Can you also add it to the example?
Rob Herring Jan. 22, 2019, 12:26 a.m. UTC | #2
On Fri, 11 Jan 2019 15:01:23 -0800, Evan Green wrote:
> Add a resets property to the PHY that represents the PHY reset
> register in the UFS controller itself. This better describes the
> complete specification of the PHY, and allows the PHY to perform
> its initialization in a single function, rather than relying on
> back-channel sequencing of initialization through the PHY framework.
> 
> Signed-off-by: Evan Green <evgreen@chromium.org>
> ---
> 
>  Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Evan Green Jan. 22, 2019, 6:34 p.m. UTC | #3
On Wed, Jan 16, 2019 at 1:29 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Evan Green (2019-01-11 15:01:23)
> > diff --git a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
> > index 21d9a93db2e97..985f5e99ab332 100644
> > --- a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
> > +++ b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
> > @@ -29,6 +29,7 @@ Optional properties:
> >  - vdda-pll-max-microamp : specifies max. load that can be drawn from pll supply
> >  - vddp-ref-clk-supply   : phandle to UFS device ref_clk pad power supply
> >  - vddp-ref-clk-max-microamp : specifies max. load that can be drawn from this supply
> > +- resets : specifies the PHY reset in the UFS controller
>
> Nitpick: Can you also add it to the example?
>

Sure, will do.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
index 21d9a93db2e97..985f5e99ab332 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
+++ b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
@@ -29,6 +29,7 @@  Optional properties:
 - vdda-pll-max-microamp : specifies max. load that can be drawn from pll supply
 - vddp-ref-clk-supply   : phandle to UFS device ref_clk pad power supply
 - vddp-ref-clk-max-microamp : specifies max. load that can be drawn from this supply
+- resets : specifies the PHY reset in the UFS controller
 
 Example: