Patchwork Exclude duplicated checking for iface-up. This flags is checked in 'is_skb_forwardable' function, which is subroutine of 'dev_forward_skb'.

login
register
mail settings
Submitter alex.bluesman.smirnov@gmail.com
Date June 28, 2011, 1:30 p.m.
Message ID <1309267844-29334-1-git-send-email-alex.bluesman.smirnov@gmail.com>
Download mbox | patch
Permalink /patch/102379/
State Accepted
Delegated to: David Miller
Headers show

Comments

alex.bluesman.smirnov@gmail.com - June 28, 2011, 1:30 p.m.
From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>

Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
---
 drivers/net/veth.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
WANG Cong - June 30, 2011, 12:07 p.m.
On Tue, 28 Jun 2011 17:30:44 +0400, alex.bluesman.smirnov wrote:

> From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
> 

Please add the description here, instead of in $subject.

> Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
> ---

The patch itself looks fine,

Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - July 1, 2011, 6:55 a.m.
From: alex.bluesman.smirnov@gmail.com
Date: Tue, 28 Jun 2011 17:30:44 +0400

> From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
> 
> Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>

Applied.

Please put the verbose patch description in the body of your
email message, right before the signoffs, not in the subject.

The subject provides a "summary" not the entire description.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 3b99f64..fb2fd37 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -163,9 +163,6 @@  static netdev_tx_t veth_xmit(struct sk_buff *skb, struct net_device *dev)
 	stats = this_cpu_ptr(priv->stats);
 	rcv_stats = this_cpu_ptr(rcv_priv->stats);
 
-	if (!(rcv->flags & IFF_UP))
-		goto tx_drop;
-
 	/* don't change ip_summed == CHECKSUM_PARTIAL, as that
 	   will cause bad checksum on forwarded packets */
 	if (skb->ip_summed == CHECKSUM_NONE)