Fix cgroup_lib.sh helper

Message ID 20190111161017.52307-1-cristian.marussi@arm.com
State Accepted
Headers show
Series
  • Fix cgroup_lib.sh helper
Related show

Commit Message

Cristian Marussi Jan. 11, 2019, 4:10 p.m.
A typo compromised get_cgroup_mountpoint() effectiveness
leading to cgroup_regression test_5 systematic failure.

Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
 testcases/kernel/controllers/cgroup_lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Petr Vorel Jan. 14, 2019, 12:42 p.m. | #1
Hi Cristian,

...
>  	mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
> -	[ -z "$mountpoint" ] && return 1
> +	[ -z "$mntpoint" ] && return 1
Thanks for fix, merged.

I'm sorry, that was introduced by me, while do some changes in your commit.


Kind regards,
Petr
Cristian Marussi Jan. 14, 2019, 1:11 p.m. | #2
Hi

On 14/01/2019 12:42, Petr Vorel wrote:
> Hi Cristian,
> 
> ...
>>  	mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
>> -	[ -z "$mountpoint" ] && return 1
>> +	[ -z "$mntpoint" ] && return 1
> Thanks for fix, merged.
> 
> I'm sorry, that was introduced by me, while do some changes in your commit.

No problem.
> 
> 
> Kind regards,
> Petr
> 

Thanks

Regards

Cristian

Patch

diff --git a/testcases/kernel/controllers/cgroup_lib.sh b/testcases/kernel/controllers/cgroup_lib.sh
index 8c19c6c3e..45ab51b87 100644
--- a/testcases/kernel/controllers/cgroup_lib.sh
+++ b/testcases/kernel/controllers/cgroup_lib.sh
@@ -16,7 +16,7 @@  get_cgroup_mountpoint()
 	[ $# -eq 0 ] && tst_brk TBROK "get_cgroup_mountpoint: subsystem not defined"
 
 	mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
-	[ -z "$mountpoint" ] && return 1
+	[ -z "$mntpoint" ] && return 1
 
 	echo $mntpoint
 	return 0