[RESEND,v1,2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
diff mbox series

Message ID 1547207400-28307-3-git-send-email-aisheng.dong@nxp.com
State Not Applicable
Headers show
Series
  • dt-binding: clk: prepare for imx8qm clock support
Related show

Checks

Context Check Description
robh/checkpatch warning "total: 0 errors, 1 warnings, 9 lines checked"

Commit Message

Dong Aisheng Jan. 11, 2019, 11:56 a.m. UTC
Add imx8qm scu clock support

Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Rob Herring Jan. 21, 2019, 11:27 p.m. UTC | #1
On Fri, Jan 11, 2019 at 11:56:00AM +0000, Aisheng Dong wrote:
> Add imx8qm scu clock support
> 
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 5ec6dca..b6a883e 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -71,7 +71,8 @@ This binding uses the common clock binding[1].
>  
>  Required properties:
>  - compatible:		Should be one of:
> -			  "fsl,imx8qxp-clock"
> +			  "fsl,imx8qm-clock",
> +			  "fsl,imx8qxp-clock".

No need for the punctuation here. The whole point of one per line is to 
have 1 line changes. Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

>  			followed by "fsl,scu-clk"
>  - #clock-cells:		Should be 1. Contains the Clock ID value.
>  - clocks:		List of clock specifiers, must contain an entry for
> -- 
> 2.7.4
>
Dong Aisheng Jan. 22, 2019, 12:58 p.m. UTC | #2
> >  Required properties:
> >  - compatible:		Should be one of:
> > -			  "fsl,imx8qxp-clock"
> > +			  "fsl,imx8qm-clock",
> > +			  "fsl,imx8qxp-clock".
> 
> No need for the punctuation here. The whole point of one per line is to have 1
> line changes. Otherwise,
> 

Got it, thanks.
I will update it later.

> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> >  			followed by "fsl,scu-clk"
> >  - #clock-cells:		Should be 1. Contains the Clock ID value.
> >  - clocks:		List of clock specifiers, must contain an entry for
> > --
> > 2.7.4
> >
Stephen Boyd Jan. 22, 2019, 7:06 p.m. UTC | #3
Quoting Aisheng Dong (2019-01-11 03:56:00)
> Add imx8qm scu clock support
> 
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index 5ec6dca..b6a883e 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -71,7 +71,8 @@  This binding uses the common clock binding[1].
 
 Required properties:
 - compatible:		Should be one of:
-			  "fsl,imx8qxp-clock"
+			  "fsl,imx8qm-clock",
+			  "fsl,imx8qxp-clock".
 			followed by "fsl,scu-clk"
 - #clock-cells:		Should be 1. Contains the Clock ID value.
 - clocks:		List of clock specifiers, must contain an entry for