[net] selftests: tc-testing: drop test on missing tunnel key id

Message ID e019296fdc30c6d1503c2ad40a884d5b797f5cb6.1547203333.git.dcaratti@redhat.com
State Accepted
Delegated to: David Miller
Headers show
Series
  • [net] selftests: tc-testing: drop test on missing tunnel key id
Related show

Commit Message

Davide Caratti Jan. 11, 2019, 10:49 a.m.
After merge of commit 80ef0f22ceda ("net/sched: act_tunnel_key: Allow
key-less tunnels"), act_tunnel_key does not reject anymore requests to
install 'set' rules where the key id is missing. Therefore, drop the
following TDC testcase:

 ba4e - Add tunnel_key set action with missing mandatory id parameter

because it's going to become a systematic fail as soon as userspace
iproute2 will start supporting key-less tunnels.

Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
 .../tc-tests/actions/tunnel_key.json          | 29 -------------------
 1 file changed, 29 deletions(-)

Comments

David Miller Jan. 16, 2019, 5:56 a.m. | #1
From: Davide Caratti <dcaratti@redhat.com>
Date: Fri, 11 Jan 2019 11:49:58 +0100

> After merge of commit 80ef0f22ceda ("net/sched: act_tunnel_key: Allow
> key-less tunnels"), act_tunnel_key does not reject anymore requests to
> install 'set' rules where the key id is missing. Therefore, drop the
> following TDC testcase:
> 
>  ba4e - Add tunnel_key set action with missing mandatory id parameter
> 
> because it's going to become a systematic fail as soon as userspace
> iproute2 will start supporting key-less tunnels.
> 
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>

Applied.

Patch

diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/tunnel_key.json b/tools/testing/selftests/tc-testing/tc-tests/actions/tunnel_key.json
index 10b2d894e436..af5e99d27229 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/tunnel_key.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/tunnel_key.json
@@ -81,35 +81,6 @@ 
 	    ]
         ]
     },
-    {
-        "id": "ba4e",
-        "name": "Add tunnel_key set action with missing mandatory id parameter",
-        "category": [
-            "actions",
-            "tunnel_key"
-        ],
-        "setup": [
-            [
-                "$TC actions flush action tunnel_key",
-                0,
-                1,
-                255
-            ]
-        ],
-        "cmdUnderTest": "$TC actions add action tunnel_key set src_ip 10.10.10.1 dst_ip 20.20.20.2",
-        "expExitCode": "255",
-        "verifyCmd": "$TC actions list action tunnel_key",
-        "matchPattern": "action order [0-9]+: tunnel_key set.*src_ip 10.10.10.1.*dst_ip 20.20.20.2",
-        "matchCount": "0",
-        "teardown": [
-	    [
-		"$TC actions flush action tunnel_key",
-		0,
-		1,
-		255
-	    ]
-        ]
-    },
     {
         "id": "a5e0",
         "name": "Add tunnel_key set action with invalid src_ip parameter",