Patchwork [2/3,v2] XFS TESTS: Fix 252 Failure: Update 252 Golden Output

login
register
mail settings
Submitter Allison Henderson
Date June 28, 2011, 4:27 a.m.
Message ID <1309235247-32650-3-git-send-email-achender@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/102318/
State Not Applicable
Headers show

Comments

Allison Henderson - June 28, 2011, 4:27 a.m.
New filtered golden output for test 252

Signed-off-by: Allison Henderson <achender@linux.vnet.ibm.com>
---
:100644 100644 930c924... fcfd121... M	252.out
 252.out |  272 +++++++++++++++++++++++++++++++++++++++------------------------
 1 files changed, 170 insertions(+), 102 deletions(-)
Dave Chinner - June 28, 2011, 5:09 a.m.
On Mon, Jun 27, 2011 at 09:27:26PM -0700, Allison Henderson wrote:
> New filtered golden output for test 252
> 
> Signed-off-by: Allison Henderson <achender@linux.vnet.ibm.com>
> ---
> :100644 100644 930c924... fcfd121... M	252.out
>  252.out |  272 +++++++++++++++++++++++++++++++++++++++------------------------
>  1 files changed, 170 insertions(+), 102 deletions(-)
> 
> diff --git a/252.out b/252.out
> index 930c924..fcfd121 100644
> --- a/252.out
> +++ b/252.out
> @@ -1,239 +1,307 @@
>  QA output created by 252
>  	1. into a hole
> +daa100df6e6711906b61c9ab5aa16032
>  	2. into allocated space
> -0: [0..7]: data
> +0: [0..7]: extent
>  1: [8..23]: hole
> -2: [24..39]: data
> +2: [24..39]: extent
> +cc58a7417c2d7763adc45b6fcd3fa024

I don't really like the way this weakens the test for XFS. With this
change, the test no longer is checking that unwritten extent
behaviour is correct.

Rather than weakening the test, perhaps it would be better to
execute 252 for XFS only (with the md5sums added), and then
duplicate it to a new test for all filesystems to run with the
weaker result checking that using the new filter function gives us.
With the amount of common code the two tests share, it should be
trivial to do this....

Cheers,

Dave.
Allison Henderson - June 28, 2011, 5:26 a.m.
On 06/27/2011 10:09 PM, Dave Chinner wrote:
> On Mon, Jun 27, 2011 at 09:27:26PM -0700, Allison Henderson wrote:
>> New filtered golden output for test 252
>>
>> Signed-off-by: Allison Henderson<achender@linux.vnet.ibm.com>
>> ---
>> :100644 100644 930c924... fcfd121... M	252.out
>>   252.out |  272 +++++++++++++++++++++++++++++++++++++++------------------------
>>   1 files changed, 170 insertions(+), 102 deletions(-)
>>
>> diff --git a/252.out b/252.out
>> index 930c924..fcfd121 100644
>> --- a/252.out
>> +++ b/252.out
>> @@ -1,239 +1,307 @@
>>   QA output created by 252
>>   	1. into a hole
>> +daa100df6e6711906b61c9ab5aa16032
>>   	2. into allocated space
>> -0: [0..7]: data
>> +0: [0..7]: extent
>>   1: [8..23]: hole
>> -2: [24..39]: data
>> +2: [24..39]: extent
>> +cc58a7417c2d7763adc45b6fcd3fa024
>
> I don't really like the way this weakens the test for XFS. With this
> change, the test no longer is checking that unwritten extent
> behaviour is correct.
>
> Rather than weakening the test, perhaps it would be better to
> execute 252 for XFS only (with the md5sums added), and then
> duplicate it to a new test for all filesystems to run with the
> weaker result checking that using the new filter function gives us.
> With the amount of common code the two tests share, it should be
> trivial to do this....
>

Alrighty, that sounds pretty straight forward, as long as every one is 
in agreement.  I think that would help retain the tests effectiveness. 
Eric, Josef, what are your thoughts?

Allison Henderson

> Cheers,
>
> Dave.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Sandeen - June 28, 2011, 1:29 p.m.
On 6/28/11 12:26 AM, Allison Henderson wrote:
> On 06/27/2011 10:09 PM, Dave Chinner wrote:
>> On Mon, Jun 27, 2011 at 09:27:26PM -0700, Allison Henderson wrote:
>>> New filtered golden output for test 252
>>>
>>> Signed-off-by: Allison Henderson<achender@linux.vnet.ibm.com>
>>> ---
>>> :100644 100644 930c924... fcfd121... M    252.out
>>>   252.out |  272 +++++++++++++++++++++++++++++++++++++++------------------------
>>>   1 files changed, 170 insertions(+), 102 deletions(-)
>>>
>>> diff --git a/252.out b/252.out
>>> index 930c924..fcfd121 100644
>>> --- a/252.out
>>> +++ b/252.out
>>> @@ -1,239 +1,307 @@
>>>   QA output created by 252
>>>       1. into a hole
>>> +daa100df6e6711906b61c9ab5aa16032
>>>       2. into allocated space
>>> -0: [0..7]: data
>>> +0: [0..7]: extent
>>>   1: [8..23]: hole
>>> -2: [24..39]: data
>>> +2: [24..39]: extent
>>> +cc58a7417c2d7763adc45b6fcd3fa024
>>
>> I don't really like the way this weakens the test for XFS. With this
>> change, the test no longer is checking that unwritten extent
>> behaviour is correct.
>>
>> Rather than weakening the test, perhaps it would be better to
>> execute 252 for XFS only (with the md5sums added), and then
>> duplicate it to a new test for all filesystems to run with the
>> weaker result checking that using the new filter function gives us.
>> With the amount of common code the two tests share, it should be
>> trivial to do this....
>>
> 
> Alrighty, that sounds pretty straight forward, as long as every one
> is in agreement. I think that would help retain the tests
> effectiveness. Eric, Josef, what are your thoughts?

Yeah, I agree, I share Dave's concerns and that sounds like a good
way to go.

Thanks,
-Eric

> Allison Henderson
> 
>> Cheers,
>>
>> Dave.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Allison Henderson - June 28, 2011, 3:03 p.m.
On 06/28/2011 06:29 AM, Eric Sandeen wrote:
> On 6/28/11 12:26 AM, Allison Henderson wrote:
>> On 06/27/2011 10:09 PM, Dave Chinner wrote:
>>> On Mon, Jun 27, 2011 at 09:27:26PM -0700, Allison Henderson wrote:
>>>> New filtered golden output for test 252
>>>>
>>>> Signed-off-by: Allison Henderson<achender@linux.vnet.ibm.com>
>>>> ---
>>>> :100644 100644 930c924... fcfd121... M    252.out
>>>>    252.out |  272 +++++++++++++++++++++++++++++++++++++++------------------------
>>>>    1 files changed, 170 insertions(+), 102 deletions(-)
>>>>
>>>> diff --git a/252.out b/252.out
>>>> index 930c924..fcfd121 100644
>>>> --- a/252.out
>>>> +++ b/252.out
>>>> @@ -1,239 +1,307 @@
>>>>    QA output created by 252
>>>>        1. into a hole
>>>> +daa100df6e6711906b61c9ab5aa16032
>>>>        2. into allocated space
>>>> -0: [0..7]: data
>>>> +0: [0..7]: extent
>>>>    1: [8..23]: hole
>>>> -2: [24..39]: data
>>>> +2: [24..39]: extent
>>>> +cc58a7417c2d7763adc45b6fcd3fa024
>>>
>>> I don't really like the way this weakens the test for XFS. With this
>>> change, the test no longer is checking that unwritten extent
>>> behaviour is correct.
>>>
>>> Rather than weakening the test, perhaps it would be better to
>>> execute 252 for XFS only (with the md5sums added), and then
>>> duplicate it to a new test for all filesystems to run with the
>>> weaker result checking that using the new filter function gives us.
>>> With the amount of common code the two tests share, it should be
>>> trivial to do this....
>>>
>>
>> Alrighty, that sounds pretty straight forward, as long as every one
>> is in agreement. I think that would help retain the tests
>> effectiveness. Eric, Josef, what are your thoughts?
>
> Yeah, I agree, I share Dave's concerns and that sounds like a good
> way to go.
>
> Thanks,
> -Eric

Ok I will get an update sent out with these adjustments, and also the 
checksum wrapper that Dave mentioned in the 1/3 patch.  Thanks all
for your reviews!

Allison Henderson

>
>> Allison Henderson
>>
>>> Cheers,
>>>
>>> Dave.
>>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/252.out b/252.out
index 930c924..fcfd121 100644
--- a/252.out
+++ b/252.out
@@ -1,239 +1,307 @@ 
 QA output created by 252
 	1. into a hole
+daa100df6e6711906b61c9ab5aa16032
 	2. into allocated space
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	3. into unwritten space
-0: [0..7]: unwritten
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: unwritten
+2: [24..39]: extent
+daa100df6e6711906b61c9ab5aa16032
 	4. hole -> data
 0: [0..23]: hole
-1: [24..31]: data
+1: [24..31]: extent
 2: [32..39]: hole
+cc63069677939f69a6e8f68cae6a6dac
 	5. hole -> unwritten
 0: [0..23]: hole
-1: [24..31]: unwritten
+1: [24..31]: extent
 2: [32..39]: hole
+daa100df6e6711906b61c9ab5aa16032
 	6. data -> hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..39]: hole
+1b3779878366498b28c702ef88c4a773
 	7. data -> unwritten
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..31]: unwritten
+2: [24..31]: extent
 3: [32..39]: hole
+1b3779878366498b28c702ef88c4a773
 	8. unwritten -> hole
-0: [0..7]: unwritten
+0: [0..7]: extent
 1: [8..39]: hole
+daa100df6e6711906b61c9ab5aa16032
 	9. unwritten -> data
-0: [0..7]: unwritten
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..31]: data
+2: [24..31]: extent
 3: [32..39]: hole
+cc63069677939f69a6e8f68cae6a6dac
 	10. hole -> data -> hole
+daa100df6e6711906b61c9ab5aa16032
 	11. data -> hole -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	12. unwritten -> data -> unwritten
-0: [0..7]: unwritten
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: unwritten
+2: [32..39]: extent
+daa100df6e6711906b61c9ab5aa16032
 	13. data -> unwritten -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	14. data -> hole @ EOF
-0: [0..23]: data
+0: [0..23]: extent
 1: [24..39]: hole
+e1f024eedd27ea6b1c3e9b841c850404
 	15. data -> hole @ 0
 0: [0..15]: hole
-1: [16..39]: data
+1: [16..39]: extent
+eecb7aa303d121835de05028751d301c
 	16. data -> cache cold ->hole
 0: [0..15]: hole
-1: [16..39]: data
+1: [16..39]: extent
+eecb7aa303d121835de05028751d301c
 	17. data -> hole in single block file
-0: [0..7]: data
+0: [0..7]: extent
+13535fd4d496bf0b74bb2335aa4d1b31
 	1. into a hole
+daa100df6e6711906b61c9ab5aa16032
 	2. into allocated space
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	3. into unwritten space
-0: [0..7]: unwritten
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: unwritten
+2: [24..39]: extent
+daa100df6e6711906b61c9ab5aa16032
 	4. hole -> data
 0: [0..23]: hole
-1: [24..31]: data
+1: [24..31]: extent
 2: [32..39]: hole
+cc63069677939f69a6e8f68cae6a6dac
 	5. hole -> unwritten
 0: [0..23]: hole
-1: [24..31]: unwritten
+1: [24..31]: extent
 2: [32..39]: hole
+daa100df6e6711906b61c9ab5aa16032
 	6. data -> hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..39]: hole
+1b3779878366498b28c702ef88c4a773
 	7. data -> unwritten
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..31]: unwritten
+2: [24..31]: extent
 3: [32..39]: hole
+1b3779878366498b28c702ef88c4a773
 	8. unwritten -> hole
-0: [0..7]: unwritten
+0: [0..7]: extent
 1: [8..39]: hole
+daa100df6e6711906b61c9ab5aa16032
 	9. unwritten -> data
-0: [0..7]: unwritten
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..31]: data
+2: [24..31]: extent
 3: [32..39]: hole
+cc63069677939f69a6e8f68cae6a6dac
 	10. hole -> data -> hole
+daa100df6e6711906b61c9ab5aa16032
 	11. data -> hole -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	12. unwritten -> data -> unwritten
-0: [0..7]: unwritten
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: unwritten
+2: [32..39]: extent
+daa100df6e6711906b61c9ab5aa16032
 	13. data -> unwritten -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	14. data -> hole @ EOF
-0: [0..23]: data
+0: [0..23]: extent
 1: [24..39]: hole
+e1f024eedd27ea6b1c3e9b841c850404
 	15. data -> hole @ 0
 0: [0..15]: hole
-1: [16..39]: data
+1: [16..39]: extent
+eecb7aa303d121835de05028751d301c
 	16. data -> cache cold ->hole
 0: [0..15]: hole
-1: [16..39]: data
+1: [16..39]: extent
+eecb7aa303d121835de05028751d301c
 	17. data -> hole in single block file
-0: [0..7]: data
+0: [0..7]: extent
+13535fd4d496bf0b74bb2335aa4d1b31
 	1. into a hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..39]: hole
+5a58e46082be047d0f13bee7974015b9
 	2. into allocated space
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	3. into unwritten space
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	4. hole -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	5. hole -> unwritten
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	6. data -> hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	7. data -> unwritten
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	8. unwritten -> hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	9. unwritten -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	10. hole -> data -> hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	11. data -> hole -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	12. unwritten -> data -> unwritten
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	13. data -> unwritten -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	14. data -> hole @ EOF
-0: [0..23]: data
+0: [0..23]: extent
 1: [24..39]: hole
+e1f024eedd27ea6b1c3e9b841c850404
 	15. data -> hole @ 0
 0: [0..15]: hole
-1: [16..39]: data
+1: [16..39]: extent
+eecb7aa303d121835de05028751d301c
 	16. data -> cache cold ->hole
 0: [0..15]: hole
-1: [16..39]: data
+1: [16..39]: extent
+eecb7aa303d121835de05028751d301c
 	17. data -> hole in single block file
-0: [0..7]: data
+0: [0..7]: extent
+13535fd4d496bf0b74bb2335aa4d1b31
 	1. into a hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..39]: hole
+5a58e46082be047d0f13bee7974015b9
 	2. into allocated space
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	3. into unwritten space
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	4. hole -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	5. hole -> unwritten
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	6. data -> hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	7. data -> unwritten
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	8. unwritten -> hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	9. unwritten -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..23]: hole
-2: [24..39]: data
+2: [24..39]: extent
+cc58a7417c2d7763adc45b6fcd3fa024
 	10. hole -> data -> hole
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	11. data -> hole -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	12. unwritten -> data -> unwritten
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	13. data -> unwritten -> data
-0: [0..7]: data
+0: [0..7]: extent
 1: [8..31]: hole
-2: [32..39]: data
+2: [32..39]: extent
+f6aeca13ec49e5b266cd1c913cd726e3
 	14. data -> hole @ EOF
-0: [0..23]: data
+0: [0..23]: extent
 1: [24..39]: hole
+e1f024eedd27ea6b1c3e9b841c850404
 	15. data -> hole @ 0
 0: [0..15]: hole
-1: [16..39]: data
+1: [16..39]: extent
+eecb7aa303d121835de05028751d301c
 	16. data -> cache cold ->hole
 0: [0..15]: hole
-1: [16..39]: data
+1: [16..39]: extent
+eecb7aa303d121835de05028751d301c
 	17. data -> hole in single block file
-0: [0..7]: data
+0: [0..7]: extent
+13535fd4d496bf0b74bb2335aa4d1b31