Patchwork [2/2] EXT4: Punch Hole Optimizations: Removed un-needed ext4_ext_remove_space param

login
register
mail settings
Submitter Allison Henderson
Date June 27, 2011, 10:49 p.m.
Message ID <1309214991-31141-3-git-send-email-achender@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/102288/
State Accepted
Headers show

Comments

Allison Henderson - June 27, 2011, 10:49 p.m.
This patch removes the extra parameter in the ext4_ext_remove_space
routine which is no longer needed.

Signed-off-by: Allison Henderson <achender@linux.vnet.ibm.com>
---
v1->v2
Added patch 2/2 to remove uneeded parameter

v2->v3
Rebased to apply onto latest ext4 code

:100644 100644 dc5a077... 3579822... M	fs/ext4/extents.c
 fs/ext4/extents.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
Theodore Ts'o - July 18, 2011, 3:23 a.m.
On Mon, Jun 27, 2011 at 03:49:51PM -0700, Allison Henderson wrote:
> This patch removes the extra parameter in the ext4_ext_remove_space
> routine which is no longer needed.
> 
> Signed-off-by: Allison Henderson <achender@linux.vnet.ibm.com>

Thanks, added to the ext4 tree.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index dc5a077..3579822 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2534,8 +2534,7 @@  ext4_ext_more_to_rm(struct ext4_ext_path *path)
 	return 1;
 }
 
-static int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start,
-				ext4_lblk_t end)
+static int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start)
 {
 	struct super_block *sb = inode->i_sb;
 	int depth = ext_depth(inode);
@@ -2575,7 +2574,7 @@  again:
 		if (i == depth) {
 			/* this is leaf block */
 			err = ext4_ext_rm_leaf(handle, inode, path,
-					start, end);
+					start, EXT_MAX_BLOCKS - 1);
 			/* root level has p_bh == NULL, brelse() eats this */
 			brelse(path[i].p_bh);
 			path[i].p_bh = NULL;
@@ -3718,7 +3717,7 @@  void ext4_ext_truncate(struct inode *inode)
 
 	last_block = (inode->i_size + sb->s_blocksize - 1)
 			>> EXT4_BLOCK_SIZE_BITS(sb);
-	err = ext4_ext_remove_space(inode, last_block, EXT_MAX_BLOCKS - 1);
+	err = ext4_ext_remove_space(inode, last_block);
 
 	/* In a multi-transaction truncate, we only make the final
 	 * transaction synchronous.