From patchwork Thu Jan 10 12:15:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 1022870 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="KpoEYD4V"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43b4gz2Bm7z9sDL for ; Thu, 10 Jan 2019 23:15:11 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727958AbfAJMPK (ORCPT ); Thu, 10 Jan 2019 07:15:10 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:44792 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727847AbfAJMPK (ORCPT ); Thu, 10 Jan 2019 07:15:10 -0500 Received: by mail-lf1-f67.google.com with SMTP id z13so8121037lfe.11 for ; Thu, 10 Jan 2019 04:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MlLtCmDcbH5nNEkEnU/NkwX+N13og6JNg3kr1P9qqL4=; b=KpoEYD4VD4gGwKm8SVK6XKDPr1n4cYfYuMFCEcifEPzHtQ+L/XwkwEDnUklJV+8uEh lvKmdYXKbD6R3ZFHd8a9VWNE+NMsAFZ56k+tXC1E8tcWiVVeZEK2Plye4aZC/58Oc6VO jcoJK0iCwvJeAZGc4zbvJptTaYbI+QB4H1muI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MlLtCmDcbH5nNEkEnU/NkwX+N13og6JNg3kr1P9qqL4=; b=KqBs/plMkgooV3PHQpAYObrvThxmxJQxtTry6YXR1S/HCsbrbHq8f/UA4w4gCkFoz0 FNf/AQArvs0RfMMga1VJ8fcKnbMnz6FjE21tlHithrURTSHAqP1ZYSir33zbunFCujuv fpffZFQRUMlsnbDbZNQWLr3dLomluyIQVJwZctu3uKcOnP5rC0E4VoyuftwFLH8mJ9iQ BaS4nI8eHCJxYVTSVNv5Vfg0y7Blg+SHzb28KEf7aVmH3LkA+aKiKD+sUlaLvblhji4L E1AYWrYrBBtENjG5OX5lvU6Y9QnwQqxIluMNIVk2bzlSx1xT80ihv7wVLBSNonMLIX1X XP4w== X-Gm-Message-State: AJcUukf7U4gYOCouB4e0SKzewhWd8ki5294AbMdMzYkzw42sGBn5B0V/ s3N3ftMSymrwU/nVn0/XXYnYWw== X-Google-Smtp-Source: ALg8bN6vPkIt3yWFMnlsbv8hrJy9g6SiKXE4EIVsapvFszeSZaG4gnthCZIzl9BSK009ya1OdyVbWA== X-Received: by 2002:a19:a104:: with SMTP id k4mr5889921lfe.36.1547122507908; Thu, 10 Jan 2019 04:15:07 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id d24-v6sm15141282ljg.2.2019.01.10.04.15.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 04:15:06 -0800 (PST) From: Linus Walleij To: Mark Brown , linux-spi@vger.kernel.org Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , linuxarm@huawei.com, Linus Walleij , Janek Kotas Subject: [PATCH] spi: Support high CS when using descriptors Date: Thu, 10 Jan 2019 13:15:03 +0100 Message-Id: <20190110121503.25436-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org All controllers using GPIO descriptors can by definition support high CS connections, so just enforce this when registering an SPI controller. This fixes a regression where controllers were missing SPI_CS_HIGH, the drivers would fail like this: spi spi0.0: setup: unsupported mode bits 4 cdns-spi fd0b0000.spi: can't setup spi0.0, status -22 This is because as using descriptors moves the CS inversion logic over to gpiolib, all such controllers are registered with CS active high. Cc: Janek Kotas Reported-by: Janek Kotas Fixes: f3186dd87669 ("spi: Optionally use GPIO descriptors for CS GPIOs") Signed-off-by: Linus Walleij --- Janek, it'd be great if you could test this patch and confirm that it makes the DW driver tick again. --- drivers/spi/spi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 06b9139664a3..31696f2fc8d5 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2336,6 +2336,11 @@ int spi_register_controller(struct spi_controller *ctlr) status = spi_get_gpio_descs(ctlr); if (status) return status; + /* + * A controller using GPIO descriptors always + * supports SPI_CS_HIGH if need be. + */ + ctlr->mode_bits |= SPI_CS_HIGH; } else { /* Legacy code path for GPIOs from DT */ status = of_spi_register_master(ctlr);