jffs2: compare xattr name length first during xattr de-duplication

Message ID 20190110032620.14366-1-houtao1@huawei.com
State New
Delegated to: Richard Weinberger
Headers show
Series
  • jffs2: compare xattr name length first during xattr de-duplication
Related show

Commit Message

Hou Tao Jan. 10, 2019, 3:26 a.m.
So unnecessary strcmp can be voided.

Signed-off-by: Hou Tao <houtao1@huawei.com>
---
 fs/jffs2/xattr.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c
index da3e18503c65..52aa73afbe10 100644
--- a/fs/jffs2/xattr.c
+++ b/fs/jffs2/xattr.c
@@ -668,6 +668,7 @@  static int check_xattr_ref_inode(struct jffs2_sb_info *c, struct jffs2_inode_cac
 					goto out;
 			}
 			if (ref->xd->xprefix == cmp->xd->xprefix
+			    && ref->xd->name_len == cmp->xd->name_len
 			    && !strcmp(ref->xd->xname, cmp->xd->xname)) {
 				if (ref->xseqno > cmp->xseqno) {
 					*pcmp = cmp->next;