From patchwork Thu Jan 10 03:08:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Dickinson X-Patchwork-Id: 1022669 X-Patchwork-Delegate: hauke@hauke-m.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=thecshore.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k9sOHgeu"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=thecshore.com header.i=@thecshore.com header.b="Y1DTKoY2"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43ZrYZ6wR4z9sDL for ; Thu, 10 Jan 2019 14:08:50 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ZhH7BVWDpME2RT0RiovbX5Ua26Gmi8ftbeUYBYrUbMg=; b=k9sOHgeuiDM0BL SbBRCKRY0763Zs8e9OoJiNpZufCxnJM5xNVsnD+cxbzGwUqVE7ljGoRLYSQ+nUPdQPpB3qV1HH5Yt BGCnsAx9aUYr9Uo0HEls1/RxuzXcKFE/TJyvrPnUcniuvKg6QTJdymiLU/JZYZ7RVVvUf8DlnZ1an S+R6bwHmEttNxFS2z6P3tSoXTzZEbEjwewzWnaYF54Rf6/dHI+JH5N6QT21/RJyXIuYgTZKw15tyW Zi5rWf66vBtHPwG0ctuTKjlVtA2hS2gNVYONByRrplH01dgfhPzX7SqSisUoKhEJmYUmT6sGHsFwF Tb8PM6mKOVX5i2odqcYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghQi1-0008I4-Fq; Thu, 10 Jan 2019 03:08:41 +0000 Received: from mailb.thecshore.com ([2607:5300:201:3100::157d]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghQhx-0008He-HE for openwrt-devel@lists.openwrt.org; Thu, 10 Jan 2019 03:08:38 +0000 Received: from finalmail.lan (finalmail.lan [10.50.50.83]) by mailb.lan (Postfix) with ESMTPS id 902D21A92 for ; Wed, 9 Jan 2019 22:08:31 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailb.lan 902D21A92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thecshore.com; s=mailb; t=1547089711; bh=6goN4lRweMjoeYKZayZQraixP13Eeqy63/9PH3vI19E=; h=From:To:Cc:Subject:Date:From; b=Y1DTKoY28i+Y/bbD1F7BnWAjQbdGYwMjysZ3H1qdi41BtjBlinNEtfS97VT4pw7uj 7nVq5I9exjSuH9p1/3fv8SjZiooQNDK/jT5xneKTh56ieYHC8WR7D8kGm5pbTjYpGU aR3R1B8ebOoWizZ1vL8kR310Ssqcg+aifhwc3Axs= X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.101.0 at mailb.thecshore.com Received: from openwrtbuild.lan (danielpm.lan [10.50.50.61]) by finalmail.lan (Postfix) with ESMTPS id 1B357121B; Wed, 9 Jan 2019 22:08:31 -0500 (EST) Received: from daniel by openwrtbuild.lan with local (Exim 4.89) (envelope-from ) id 1ghQhq-000382-Ug; Wed, 09 Jan 2019 22:08:30 -0500 From: cshored@thecshore.com To: openwrt-devel@lists.openwrt.org Date: Wed, 9 Jan 2019 22:08:26 -0500 Message-Id: <20190110030826.11926-1-cshored@thecshore.com> X-Mailer: git-send-email 2.11.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190109_190837_647247_6AA83705 X-CRM114-Status: UNSURE ( 5.75 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [OpenWrt-Devel] [PATCH] config: kernel: Fix missing symbol on brcm2708 with CGROUPS X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel F. Dickinson" MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: "Daniel F. Dickinson" When CGROUP block io is enabled a new symbol is exposed and needs to be set or unset else kernel oldconfig hangs waiting for input during normal OpenWrt builds. Therefore add sane defaults for this symbol in that case. Also, the defaults brcm2708 are different than generic defaults because the platform's defconfig enables BLK_DEV_THROTTLING by default (in defconfig config from the patches used to match upstream's kernel, not in OpenWrt config-4.xx). Signed-off-by: Daniel F. Dickinson --- config/Config-kernel.in | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/config/Config-kernel.in b/config/Config-kernel.in index f38cc792dd..6b571368f2 100644 --- a/config/Config-kernel.in +++ b/config/Config-kernel.in @@ -519,6 +519,23 @@ if KERNEL_CGROUPS CONFIG_CFQ_GROUP_IOSCHED=y; for enabling throttling policy, set CONFIG_BLK_DEV_THROTTLING=y. + if KERNEL_BLK_CGROUP + + config KERNEL_CFQ_GROUP_IOSCHED + bool "Proportional weight of disk bandwidth in CFQ" + default n if KERNEL_BLK_DEV_THROTTLING + default y + + config KERNEL_BLK_DEV_THROTTLING + bool "Enable throttling policy" + default y if TARGET_brcm2708 + default n + + config KERNEL_BLK_DEV_THROTTLING_LOW + bool "Block throttling .low limit interface support (EXPERIMENTAL)" + default n + endif + config KERNEL_DEBUG_BLK_CGROUP bool "Enable Block IO controller debugging" default n