[U-Boot] drivers: serial: DEBUG_UART_SKIP_INIT depends on DEBUG_UART

Message ID 20190109192709.11757-1-simon.k.r.goldschmidt@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot] drivers: serial: DEBUG_UART_SKIP_INIT depends on DEBUG_UART
Related show

Commit Message

Simon Goldschmidt Jan. 9, 2019, 7:27 p.m.
DEBUG_UART_SKIP_INIT is used only by debug UART and thus should depend
on DEBUG_UART.

Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
---

 drivers/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass Jan. 10, 2019, 12:57 p.m. | #1
On Wed, 9 Jan 2019 at 12:27, Simon Goldschmidt
<simon.k.r.goldschmidt@gmail.com> wrote:
>
> DEBUG_UART_SKIP_INIT is used only by debug UART and thus should depend
> on DEBUG_UART.
>
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> ---
>
>  drivers/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 16, 2019, 2:44 a.m. | #2
On Wed, Jan 09, 2019 at 08:27:09PM +0100, Simon Goldschmidt wrote:

> DEBUG_UART_SKIP_INIT is used only by debug UART and thus should depend
> on DEBUG_UART.
> 
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

Patch

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index b7ff2960ab..e67ea52338 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -442,6 +442,7 @@  config DEBUG_UART_ANNOUNCE
 
 config DEBUG_UART_SKIP_INIT
 	bool "Skip UART initialization"
+	depends on DEBUG_UART
 	help
 	  Select this if the UART you want to use for debug output is already
 	  initialized by the time U-Boot starts its execution.