[net] selftests/txtimestamp: Fix an equals vs assign bug

Message ID 20190109105007.GA14518@kadam
State Accepted
Delegated to: David Miller
Headers show
Series
  • [net] selftests/txtimestamp: Fix an equals vs assign bug
Related show

Commit Message

Dan Carpenter Jan. 9, 2019, 10:50 a.m.
This should be == instead of =.

Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and pf_packet")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 tools/testing/selftests/networking/timestamping/txtimestamp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Willem de Bruijn Jan. 9, 2019, 1:24 p.m. | #1
On Wed, Jan 9, 2019 at 5:52 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This should be == instead of =.
>
> Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and pf_packet")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Willem de Bruijn <willemb@google.com>

Thanks for the fix, Dan.
David Miller Jan. 15, 2019, 9:45 p.m. | #2
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 9 Jan 2019 13:50:07 +0300

> This should be == instead of =.
> 
> Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and pf_packet")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

Patch

diff --git a/tools/testing/selftests/networking/timestamping/txtimestamp.c b/tools/testing/selftests/networking/timestamping/txtimestamp.c
index 2e563d17cf0c..d1bbafb16f47 100644
--- a/tools/testing/selftests/networking/timestamping/txtimestamp.c
+++ b/tools/testing/selftests/networking/timestamping/txtimestamp.c
@@ -240,7 +240,7 @@  static void __recv_errmsg_cmsg(struct msghdr *msg, int payload_len)
 			    cm->cmsg_type == IP_RECVERR) ||
 			   (cm->cmsg_level == SOL_IPV6 &&
 			    cm->cmsg_type == IPV6_RECVERR) ||
-			   (cm->cmsg_level = SOL_PACKET &&
+			   (cm->cmsg_level == SOL_PACKET &&
 			    cm->cmsg_type == PACKET_TX_TIMESTAMP)) {
 			serr = (void *) CMSG_DATA(cm);
 			if (serr->ee_errno != ENOMSG ||