[1/1] r8169: Add support for new Realtek Ethernet

Message ID 20190109061802.6714-2-kai.heng.feng@canonical.com
State New
Headers show
Series
  • [1/1] r8169: Add support for new Realtek Ethernet
Related show

Commit Message

Kai-Heng Feng Jan. 9, 2019, 6:18 a.m.
BugLink: https://bugs.launchpad.net/bugs/1811055

There are two new Realtek Ethernet devices which are re-branded r8168h.
Add the IDs to to support them.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f)
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/net/ethernet/realtek/r8169.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Po-Hsu Lin Jan. 9, 2019, 7:35 a.m. | #1
On Wed, Jan 9, 2019 at 2:18 PM Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1811055
>
> There are two new Realtek Ethernet devices which are re-branded r8168h.
> Add the IDs to to support them.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> (backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f)
(backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f linux-next)
Looks like this patch came from linux-next[1], ack with the commit message fixed as above

Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=36352991835ce99e46b4441dd0eb6980f9a83e8f

> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/net/ethernet/realtek/r8169.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 64826f4f23bc..a264f90a750c 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -324,6 +324,8 @@ enum cfg_version {
>  };
>
>  static const struct pci_device_id rtl8169_pci_tbl[] = {
> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x2502), 0, 0, RTL_CFG_1 },
> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x2600), 0, 0, RTL_CFG_1 },
>         { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8129), 0, 0, RTL_CFG_0 },
>         { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8136), 0, 0, RTL_CFG_2 },
>         { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8161), 0, 0, RTL_CFG_1 },
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kai-Heng Feng Jan. 9, 2019, 8:23 a.m. | #2
> On Jan 9, 2019, at 3:35 PM, Po-Hsu Lin <po-hsu.lin@canonical.com> wrote:
> 
> On Wed, Jan 9, 2019 at 2:18 PM Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>> 
>> BugLink: https://bugs.launchpad.net/bugs/1811055
>> 
>> There are two new Realtek Ethernet devices which are re-branded r8168h.
>> Add the IDs to to support them.
>> 
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>> (backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f)
> (backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f linux-next)

I missed that one, thanks for pointing out.

Kai-Heng

> Looks like this patch came from linux-next[1], ack with the commit message fixed as above
> 
> Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=36352991835ce99e46b4441dd0eb6980f9a83e8f
> 
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> drivers/net/ethernet/realtek/r8169.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>> index 64826f4f23bc..a264f90a750c 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -324,6 +324,8 @@ enum cfg_version {
>> };
>> 
>> static const struct pci_device_id rtl8169_pci_tbl[] = {
>> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x2502), 0, 0, RTL_CFG_1 },
>> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x2600), 0, 0, RTL_CFG_1 },
>>        { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8129), 0, 0, RTL_CFG_0 },
>>        { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8136), 0, 0, RTL_CFG_2 },
>>        { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8161), 0, 0, RTL_CFG_1 },
>> --
>> 2.17.1
>> 
>> 
>> --
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Patch

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 64826f4f23bc..a264f90a750c 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -324,6 +324,8 @@  enum cfg_version {
 };
 
 static const struct pci_device_id rtl8169_pci_tbl[] = {
+	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x2502), 0, 0, RTL_CFG_1 },
+	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x2600), 0, 0, RTL_CFG_1 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8129), 0, 0, RTL_CFG_0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8136), 0, 0, RTL_CFG_2 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8161), 0, 0, RTL_CFG_1 },