[1/1] Provides puredata package

Message ID 20190108032658.25220-1-Mitchell.Dokken@gmail.com
State New
Headers show
Series
  • [1/1] Provides puredata package
Related show

Commit Message

Mitchell Dokken Jan. 8, 2019, 3:26 a.m.
Signed-off-by: Mitchell Dokken <Mitchell.Dokken@gmail.com>
---
 package/Config.in              |  1 +
 package/puredata/Config.in     | 12 ++++++++++++
 package/puredata/puredata.hash |  2 ++
 package/puredata/puredata.mk   | 34 ++++++++++++++++++++++++++++++++++
 4 files changed, 49 insertions(+)
 create mode 100644 package/puredata/Config.in
 create mode 100644 package/puredata/puredata.hash
 create mode 100644 package/puredata/puredata.mk

Comments

Matt Weber Jan. 8, 2019, 4:20 a.m. | #1
Mitchell,

On Mon, Jan 7, 2019 at 9:49 PM Mitchell Dokken
<mitchell.dokken@gmail.com> wrote:
>
> Signed-off-by: Mitchell Dokken <Mitchell.Dokken@gmail.com>
> ---
>  package/Config.in              |  1 +
>  package/puredata/Config.in     | 12 ++++++++++++
>  package/puredata/puredata.hash |  2 ++
>  package/puredata/puredata.mk   | 34 ++++++++++++++++++++++++++++++++++

If you're up for maintaining this package, I'd suggest adding yourself
to the DEVELOPERS file.  Then you'll get emails if the build fails
when the autobuilder is testing different build configurations.

>  4 files changed, 49 insertions(+)
>  create mode 100644 package/puredata/Config.in
>  create mode 100644 package/puredata/puredata.hash
>  create mode 100644 package/puredata/puredata.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 0df9b73088..e029de53db 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -45,6 +45,7 @@ menu "Audio and video applications"
>         source "package/on2-8170-libs/Config.in"
>         source "package/opus-tools/Config.in"
>         source "package/pulseaudio/Config.in"
> +       source "package/puredata/Config.in"
>         source "package/sox/Config.in"
>         source "package/squeezelite/Config.in"
>         source "package/tovid/Config.in"
> diff --git a/package/puredata/Config.in b/package/puredata/Config.in
> new file mode 100644
> index 0000000000..c8bafe8885
> --- /dev/null
> +++ b/package/puredata/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_PUREDATA
> +       bool "puredata"
> +       select BR2_PACKAGE_TK
> +       select BR2_PACKAGE_TCL
> +       select BR2_PACKAGE_ALSA_LIB
> +       select BR2_PACKAGE_ALSA_UTILS
> +       select BR2_PACKAGE_XORG7
> +       select BR2_PACKAGE_XAPP_XAUTH

Each of these selects won't automatically assume the respective
"depends on" found in some of those package's Config.in.  Please
reflect those "depends on" dependencies and comment similar to the
example, package/policycoreutils/Config.in with all its libsemanage
depends on.

> +
> +       help
> +               Graphic realtime audio programming language
> +               http://msp.ucsd.edu/software.htm

Suggest running ./utils/check-package package/puredata/*  to check for
formatting of the new files.

> diff --git a/package/puredata/puredata.hash b/package/puredata/puredata.hash
> new file mode 100644
> index 0000000000..505dbe3679
> --- /dev/null
> +++ b/package/puredata/puredata.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +d2e04e75d22b0e41f27daacc0cd6ec6b05ae0ef214cc7315d57e5bfbeec23fa3  pd-0.49-0.src.tar.gz

Please fix the format of this hash entry, see
https://buildroot.org/downloads/manual/manual.html#adding-packages-hash
for an example.  That looks like a sha256?

Please add a license file hash as well.

> diff --git a/package/puredata/puredata.mk b/package/puredata/puredata.mk
> new file mode 100644
> index 0000000000..842970b983
> --- /dev/null
> +++ b/package/puredata/puredata.mk
> @@ -0,0 +1,34 @@
> +################################################################################
> +#
> +# puredata
> +#
> +################################################################################
> +
> +PUREDATA_VERSION =  0.49-0
> +PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
> +PUREDATA_SITE = http://msp.ucsd.edu/Software

Please add license type and file names. See
https://buildroot.org/downloads/manual/manual.html#generic-package-tutorial
for an example of the use of license variables.  Note, I understand
this is a autotools pkg type, the generic in the manual had the best
license example.

> +PUREDATA_INSTALL_STAGING = YES
> +PUREDATA_INSTALL_TARGET = YES

PUREDATA_INSTALL_TARGET is set defaultly to YES, so you can remove the line.

> +PUREDATA_AUTORECONF = YES
> +PUREDATA_CONF_OPTS = --no-recursion --disable-locales
> +
> +PUREDATA_DEPENDENCIES = alsa-utils tcl tk
> +
> +ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
> +PUREDATA_CONF_OPTS += --enable-portaudio
> +else
> +PUREDATA_CONF_OPTS += --disable-portaudio
> +endif
> +
> +ifeq ($(BR2_PACKAGE_JACK2),y)
> +PUREDATA_CONF_OPTS += --enable-jack
> +else
> +PUREDATA_CONF_OPTS += --disable-jack
> +endif
> +
> +define PUREDATA_RUN_AUTOGEN
> +       cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
> +endef
> +PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
> +
> +$(eval $(autotools-package))
> --
> 2.11.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Matt
Yann E. MORIN Jan. 8, 2019, 7:20 a.m. | #2
Mitchell, All,

Thanks for this submission. :-)

In addition to Matt's review, see a few comments below...

On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:
> Signed-off-by: Mitchell Dokken <Mitchell.Dokken@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/puredata/Config.in b/package/puredata/Config.in
> new file mode 100644
> index 0000000000..c8bafe8885
> --- /dev/null
> +++ b/package/puredata/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_PUREDATA
> +	bool "puredata"
> +	select BR2_PACKAGE_TK
> +	select BR2_PACKAGE_TCL
> +	select BR2_PACKAGE_ALSA_LIB
> +	select BR2_PACKAGE_ALSA_UTILS
> +	select BR2_PACKAGE_XORG7

Do not select Xorg, but depend on it.

> +	select BR2_PACKAGE_XAPP_XAUTH

... but you can select individual X package.

> +

No empty line before the help.

> +	help
> +		Graphic realtime audio programming language
> +		http://msp.ucsd.edu/software.htm

Indentation for the help text is TAB-space-space. As suggested by Matt,
use:

    ./utils/check-package package/puredata/*

Also, there is a better-looking homepage for Pure Data, maybe we can use
it instead: http://puredata.info/ ?

[--SNIP--]
> diff --git a/package/puredata/puredata.mk b/package/puredata/puredata.mk
> new file mode 100644
> index 0000000000..842970b983
> --- /dev/null
> +++ b/package/puredata/puredata.mk
> @@ -0,0 +1,34 @@
> +################################################################################
> +#
> +# puredata
> +#
> +################################################################################
> +
> +PUREDATA_VERSION =  0.49-0
> +PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
> +PUREDATA_SITE = http://msp.ucsd.edu/Software
> +PUREDATA_INSTALL_STAGING = YES

Why does it need to be installed in staging? Is this providing a
library?

> +PUREDATA_INSTALL_TARGET = YES
> +PUREDATA_AUTORECONF = YES
> +PUREDATA_CONF_OPTS = --no-recursion --disable-locales
> +
> +PUREDATA_DEPENDENCIES = alsa-utils tcl tk
> +
> +ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
> +PUREDATA_CONF_OPTS += --enable-portaudio
> +else
> +PUREDATA_CONF_OPTS += --disable-portaudio
> +endif
> +
> +ifeq ($(BR2_PACKAGE_JACK2),y)
> +PUREDATA_CONF_OPTS += --enable-jack
> +else
> +PUREDATA_CONF_OPTS += --disable-jack
> +endif
> +
> +define PUREDATA_RUN_AUTOGEN
> +	cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
> +endef

Why do you need to run autogen.sh since you already have
PUREDATA_AUTORECONF=YES ?

autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES
anyway. The only delta is that it also creates a directory, so your hook
should just do that: create the m4/generated directory. Also, make it a
post-extract hook.

Regards,
Yann E. MORIN.

> +PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
> +
> +$(eval $(autotools-package))
> -- 
> 2.11.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Mitchell Dokken Jan. 9, 2019, 1:35 a.m. | #3
Thank you, to both of you!

These are very helpful. I do have a question: when I fix all these issues,
should I do exactly the same thing for the next patch review, or should I
somehow reference this conversation?

On Tue, Jan 8, 2019 at 1:20 AM <yann.morin@orange.com> wrote:

> Mitchell, All,
>
> Thanks for this submission. :-)
>
> In addition to Matt's review, see a few comments below...
>
> On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:
> > Signed-off-by: Mitchell Dokken <Mitchell.Dokken@gmail.com>
> > ---
> [--SNIP--]
> > diff --git a/package/puredata/Config.in b/package/puredata/Config.in
> > new file mode 100644
> > index 0000000000..c8bafe8885
> > --- /dev/null
> > +++ b/package/puredata/Config.in
> > @@ -0,0 +1,12 @@
> > +config BR2_PACKAGE_PUREDATA
> > +     bool "puredata"
> > +     select BR2_PACKAGE_TK
> > +     select BR2_PACKAGE_TCL
> > +     select BR2_PACKAGE_ALSA_LIB
> > +     select BR2_PACKAGE_ALSA_UTILS
> > +     select BR2_PACKAGE_XORG7
>
> Do not select Xorg, but depend on it.
>
> > +     select BR2_PACKAGE_XAPP_XAUTH
>
> ... but you can select individual X package.
>
> > +
>
> No empty line before the help.
>
> > +     help
> > +             Graphic realtime audio programming language
> > +             http://msp.ucsd.edu/software.htm
>
> Indentation for the help text is TAB-space-space. As suggested by Matt,
> use:
>
>     ./utils/check-package package/puredata/*
>
> Also, there is a better-looking homepage for Pure Data, maybe we can use
> it instead: http://puredata.info/ ?
>
> [--SNIP--]
> > diff --git a/package/puredata/puredata.mk b/package/puredata/puredata.mk
> > new file mode 100644
> > index 0000000000..842970b983
> > --- /dev/null
> > +++ b/package/puredata/puredata.mk
> > @@ -0,0 +1,34 @@
> >
> +################################################################################
> > +#
> > +# puredata
> > +#
> >
> +################################################################################
> > +
> > +PUREDATA_VERSION =  0.49-0
> > +PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
> > +PUREDATA_SITE = http://msp.ucsd.edu/Software
> > +PUREDATA_INSTALL_STAGING = YES
>
> Why does it need to be installed in staging? Is this providing a
> library?
>
> > +PUREDATA_INSTALL_TARGET = YES
> > +PUREDATA_AUTORECONF = YES
> > +PUREDATA_CONF_OPTS = --no-recursion --disable-locales
> > +
> > +PUREDATA_DEPENDENCIES = alsa-utils tcl tk
> > +
> > +ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
> > +PUREDATA_CONF_OPTS += --enable-portaudio
> > +else
> > +PUREDATA_CONF_OPTS += --disable-portaudio
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_JACK2),y)
> > +PUREDATA_CONF_OPTS += --enable-jack
> > +else
> > +PUREDATA_CONF_OPTS += --disable-jack
> > +endif
> > +
> > +define PUREDATA_RUN_AUTOGEN
> > +     cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
> > +endef
>
> Why do you need to run autogen.sh since you already have
> PUREDATA_AUTORECONF=YES ?
>
> autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES
> anyway. The only delta is that it also creates a directory, so your hook
> should just do that: create the m4/generated directory. Also, make it a
> post-extract hook.
>
> Regards,
> Yann E. MORIN.
>
> > +PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
> > +
> > +$(eval $(autotools-package))
> > --
> > 2.11.0
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
>                                         ____________
> .-----------------.--------------------:       _    :------------------.
> |  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
> | +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
> | +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
> |      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |
> '--------------------------------------:______/_____:------------------'
>
>
>
> _________________________________________________________________________________________________________________________
>
> Ce message et ses pieces jointes peuvent contenir des informations
> confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez
> recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
> electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou
> falsifie. Merci.
>
> This message and its attachments may contain confidential or privileged
> information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and
> delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been
> modified, changed or falsified.
> Thank you.
>
>
<div dir="ltr">Thank you, to both of you!<div><br></div><div>These are very helpful. I do have a question: when I fix all these issues, should I do exactly the same thing for the next patch review, or should I somehow reference this conversation?</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 8, 2019 at 1:20 AM &lt;<a href="mailto:yann.morin@orange.com">yann.morin@orange.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Mitchell, All,<br>
<br>
Thanks for this submission. :-)<br>
<br>
In addition to Matt&#39;s review, see a few comments below...<br>
<br>
On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:<br>
&gt; Signed-off-by: Mitchell Dokken &lt;<a href="mailto:Mitchell.Dokken@gmail.com" target="_blank">Mitchell.Dokken@gmail.com</a>&gt;<br>
&gt; ---<br>
[--SNIP--]<br>
&gt; diff --git a/package/puredata/Config.in b/package/puredata/Config.in<br>
&gt; new file mode 100644<br>
&gt; index 0000000000..c8bafe8885<br>
&gt; --- /dev/null<br>
&gt; +++ b/package/puredata/Config.in<br>
&gt; @@ -0,0 +1,12 @@<br>
&gt; +config BR2_PACKAGE_PUREDATA<br>
&gt; +     bool &quot;puredata&quot;<br>
&gt; +     select BR2_PACKAGE_TK<br>
&gt; +     select BR2_PACKAGE_TCL<br>
&gt; +     select BR2_PACKAGE_ALSA_LIB<br>
&gt; +     select BR2_PACKAGE_ALSA_UTILS<br>
&gt; +     select BR2_PACKAGE_XORG7<br>
<br>
Do not select Xorg, but depend on it.<br>
<br>
&gt; +     select BR2_PACKAGE_XAPP_XAUTH<br>
<br>
... but you can select individual X package.<br>
<br>
&gt; +<br>
<br>
No empty line before the help.<br>
<br>
&gt; +     help<br>
&gt; +             Graphic realtime audio programming language<br>
&gt; +             <a href="http://msp.ucsd.edu/software.htm" rel="noreferrer" target="_blank">http://msp.ucsd.edu/software.htm</a><br>
<br>
Indentation for the help text is TAB-space-space. As suggested by Matt,<br>
use:<br>
<br>
    ./utils/check-package package/puredata/*<br>
<br>
Also, there is a better-looking homepage for Pure Data, maybe we can use<br>
it instead: <a href="http://puredata.info/" rel="noreferrer" target="_blank">http://puredata.info/</a> ?<br>
<br>
[--SNIP--]<br>
&gt; diff --git a/package/puredata/<a href="http://puredata.mk" rel="noreferrer" target="_blank">puredata.mk</a> b/package/puredata/<a href="http://puredata.mk" rel="noreferrer" target="_blank">puredata.mk</a><br>
&gt; new file mode 100644<br>
&gt; index 0000000000..842970b983<br>
&gt; --- /dev/null<br>
&gt; +++ b/package/puredata/<a href="http://puredata.mk" rel="noreferrer" target="_blank">puredata.mk</a><br>
&gt; @@ -0,0 +1,34 @@<br>
&gt; +################################################################################<br>
&gt; +#<br>
&gt; +# puredata<br>
&gt; +#<br>
&gt; +################################################################################<br>
&gt; +<br>
&gt; +PUREDATA_VERSION =  0.49-0<br>
&gt; +PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz<br>
&gt; +PUREDATA_SITE = <a href="http://msp.ucsd.edu/Software" rel="noreferrer" target="_blank">http://msp.ucsd.edu/Software</a><br>
&gt; +PUREDATA_INSTALL_STAGING = YES<br>
<br>
Why does it need to be installed in staging? Is this providing a<br>
library?<br>
<br>
&gt; +PUREDATA_INSTALL_TARGET = YES<br>
&gt; +PUREDATA_AUTORECONF = YES<br>
&gt; +PUREDATA_CONF_OPTS = --no-recursion --disable-locales<br>
&gt; +<br>
&gt; +PUREDATA_DEPENDENCIES = alsa-utils tcl tk<br>
&gt; +<br>
&gt; +ifeq ($(BR2_PACKAGE_PORTAUDIO),y)<br>
&gt; +PUREDATA_CONF_OPTS += --enable-portaudio<br>
&gt; +else<br>
&gt; +PUREDATA_CONF_OPTS += --disable-portaudio<br>
&gt; +endif<br>
&gt; +<br>
&gt; +ifeq ($(BR2_PACKAGE_JACK2),y)<br>
&gt; +PUREDATA_CONF_OPTS += --enable-jack<br>
&gt; +else<br>
&gt; +PUREDATA_CONF_OPTS += --disable-jack<br>
&gt; +endif<br>
&gt; +<br>
&gt; +define PUREDATA_RUN_AUTOGEN<br>
&gt; +     cd $(@D) &amp;&amp; PATH=$(BR_PATH) ./autogen.sh<br>
&gt; +endef<br>
<br>
Why do you need to run autogen.sh since you already have<br>
PUREDATA_AUTORECONF=YES ?<br>
<br>
autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES<br>
anyway. The only delta is that it also creates a directory, so your hook<br>
should just do that: create the m4/generated directory. Also, make it a<br>
post-extract hook.<br>
<br>
Regards,<br>
Yann E. MORIN.<br>
<br>
&gt; +PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN<br>
&gt; +<br>
&gt; +$(eval $(autotools-package))<br>
&gt; -- <br>
&gt; 2.11.0<br>
&gt; <br>
&gt; _______________________________________________<br>
&gt; buildroot mailing list<br>
&gt; <a href="mailto:buildroot@busybox.net" target="_blank">buildroot@busybox.net</a><br>
&gt; <a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/mailman/listinfo/buildroot</a><br>
<br>
-- <br>
                                        ____________<br>
.-----------------.--------------------:       _    :------------------.<br>
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /&quot;\ ASCII RIBBON |<br>
| +33 534.541.179 | Software  Designer |  _/ - /&#39;   | \ / CAMPAIGN     |<br>
| +33 638.411.245 &#39;--------------------: (_    `--, |  X  AGAINST      |<br>
|      yann.morin (at) <a href="http://orange.com" rel="noreferrer" target="_blank">orange.com</a>      |_=&quot;    ,--&#39; | / \ HTML MAIL    |<br>
&#39;--------------------------------------:______/_____:------------------&#39;<br>
<br>
<br>
_________________________________________________________________________________________________________________________<br>
<br>
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc<br>
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler<br>
a l&#39;expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d&#39;alteration,<br>
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.<br>
<br>
This message and its attachments may contain confidential or privileged information that may be protected by law;<br>
they should not be distributed, used or copied without authorisation.<br>
If you have received this email in error, please notify the sender and delete this message and its attachments.<br>
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.<br>
Thank you.<br>
<br>
</blockquote></div>
Matt Weber Jan. 9, 2019, 2:27 a.m. | #4
Mitchell,


On Tue, Jan 8, 2019 at 7:36 PM Mitchell Dokken
<mitchell.dokken@gmail.com> wrote:
>
> Thank you, to both of you!
>
> These are very helpful. I do have a question: when I fix all these issues, should I do exactly the same thing for the next patch review, or should I somehow reference this conversation?

No need to reference this conversation directly, patchwork has
recorded this first version of the patch
(http://patchwork.ozlabs.org/patch/1021690/) with all the
conversation.  One of the maintainers will mark it superseded once
your v2 patch is sent out.  For the new patch as it's a version 2,
it's suggested to include a change log of changes from v1 to v2
(Manual Section 21.5.4 - Patch revision changelog).  That manual
section also has examples of how to use format patch to generate your
v2.

Thanks for the submission!

>
> On Tue, Jan 8, 2019 at 1:20 AM <yann.morin@orange.com> wrote:
>>
>> Mitchell, All,
>>
>> Thanks for this submission. :-)
>>
>> In addition to Matt's review, see a few comments below...
>>
>> On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:
>> > Signed-off-by: Mitchell Dokken <Mitchell.Dokken@gmail.com>
>> > ---
>> [--SNIP--]
>> > diff --git a/package/puredata/Config.in b/package/puredata/Config.in
>> > new file mode 100644
>> > index 0000000000..c8bafe8885
>> > --- /dev/null
>> > +++ b/package/puredata/Config.in
>> > @@ -0,0 +1,12 @@
>> > +config BR2_PACKAGE_PUREDATA
>> > +     bool "puredata"
>> > +     select BR2_PACKAGE_TK
>> > +     select BR2_PACKAGE_TCL
>> > +     select BR2_PACKAGE_ALSA_LIB
>> > +     select BR2_PACKAGE_ALSA_UTILS
>> > +     select BR2_PACKAGE_XORG7
>>
>> Do not select Xorg, but depend on it.
>>
>> > +     select BR2_PACKAGE_XAPP_XAUTH
>>
>> ... but you can select individual X package.
>>
>> > +
>>
>> No empty line before the help.
>>
>> > +     help
>> > +             Graphic realtime audio programming language
>> > +             http://msp.ucsd.edu/software.htm
>>
>> Indentation for the help text is TAB-space-space. As suggested by Matt,
>> use:
>>
>>     ./utils/check-package package/puredata/*
>>
>> Also, there is a better-looking homepage for Pure Data, maybe we can use
>> it instead: http://puredata.info/ ?
>>
>> [--SNIP--]
>> > diff --git a/package/puredata/puredata.mk b/package/puredata/puredata.mk
>> > new file mode 100644
>> > index 0000000000..842970b983
>> > --- /dev/null
>> > +++ b/package/puredata/puredata.mk
>> > @@ -0,0 +1,34 @@
>> > +################################################################################
>> > +#
>> > +# puredata
>> > +#
>> > +################################################################################
>> > +
>> > +PUREDATA_VERSION =  0.49-0
>> > +PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
>> > +PUREDATA_SITE = http://msp.ucsd.edu/Software
>> > +PUREDATA_INSTALL_STAGING = YES
>>
>> Why does it need to be installed in staging? Is this providing a
>> library?
>>
>> > +PUREDATA_INSTALL_TARGET = YES
>> > +PUREDATA_AUTORECONF = YES
>> > +PUREDATA_CONF_OPTS = --no-recursion --disable-locales
>> > +
>> > +PUREDATA_DEPENDENCIES = alsa-utils tcl tk
>> > +
>> > +ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
>> > +PUREDATA_CONF_OPTS += --enable-portaudio
>> > +else
>> > +PUREDATA_CONF_OPTS += --disable-portaudio
>> > +endif
>> > +
>> > +ifeq ($(BR2_PACKAGE_JACK2),y)
>> > +PUREDATA_CONF_OPTS += --enable-jack
>> > +else
>> > +PUREDATA_CONF_OPTS += --disable-jack
>> > +endif
>> > +
>> > +define PUREDATA_RUN_AUTOGEN
>> > +     cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
>> > +endef
>>
>> Why do you need to run autogen.sh since you already have
>> PUREDATA_AUTORECONF=YES ?
>>
>> autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES
>> anyway. The only delta is that it also creates a directory, so your hook
>> should just do that: create the m4/generated directory. Also, make it a
>> post-extract hook.
>>
>> Regards,
>> Yann E. MORIN.
>>
>> > +PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
>> > +
>> > +$(eval $(autotools-package))
>> > --
>> > 2.11.0
>> >
>> > _______________________________________________
>> > buildroot mailing list
>> > buildroot@busybox.net
>> > http://lists.busybox.net/mailman/listinfo/buildroot
>>
>> --
>>                                         ____________
>> .-----------------.--------------------:       _    :------------------.
>> |  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
>> | +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
>> | +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
>> |      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |
>> '--------------------------------------:______/_____:------------------'
>>
>>
>> _________________________________________________________________________________________________________________________
>>
>> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
>> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
>> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
>> Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
>>
>> This message and its attachments may contain confidential or privileged information that may be protected by law;
>> they should not be distributed, used or copied without authorisation.
>> If you have received this email in error, please notify the sender and delete this message and its attachments.
>> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
>> Thank you.
>>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Matt Weber Jan. 9, 2019, 2:29 a.m. | #5
Mitchell,

On Tue, Jan 8, 2019 at 8:27 PM Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
>
> Mitchell,
>
>
> On Tue, Jan 8, 2019 at 7:36 PM Mitchell Dokken
> <mitchell.dokken@gmail.com> wrote:
> >
> > Thank you, to both of you!
> >
> > These are very helpful. I do have a question: when I fix all these issues, should I do exactly the same thing for the next patch review, or should I somehow reference this conversation?
>
> No need to reference this conversation directly, patchwork has
> recorded this first version of the patch
> (http://patchwork.ozlabs.org/patch/1021690/) with all the
> conversation.  One of the maintainers will mark it superseded once
> your v2 patch is sent out.  For the new patch as it's a version 2,
> it's suggested to include a change log of changes from v1 to v2
> (Manual Section 21.5.4 - Patch revision changelog).  That manual
> section also has examples of how to use format patch to generate your
> v2.
>

I forgot to mention.  I'd suggest renaming the commit title to be
"package/puredata: new package"

>
> >
> > On Tue, Jan 8, 2019 at 1:20 AM <yann.morin@orange.com> wrote:
> >>
> >> Mitchell, All,
> >>
> >> Thanks for this submission. :-)
> >>
> >> In addition to Matt's review, see a few comments below...
> >>
> >> On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:
> >> > Signed-off-by: Mitchell Dokken <Mitchell.Dokken@gmail.com>
> >> > ---
> >> [--SNIP--]
> >> > diff --git a/package/puredata/Config.in b/package/puredata/Config.in
> >> > new file mode 100644
> >> > index 0000000000..c8bafe8885
> >> > --- /dev/null
> >> > +++ b/package/puredata/Config.in
> >> > @@ -0,0 +1,12 @@
> >> > +config BR2_PACKAGE_PUREDATA
> >> > +     bool "puredata"
> >> > +     select BR2_PACKAGE_TK
> >> > +     select BR2_PACKAGE_TCL
> >> > +     select BR2_PACKAGE_ALSA_LIB
> >> > +     select BR2_PACKAGE_ALSA_UTILS
> >> > +     select BR2_PACKAGE_XORG7
> >>
> >> Do not select Xorg, but depend on it.
> >>
> >> > +     select BR2_PACKAGE_XAPP_XAUTH
> >>
> >> ... but you can select individual X package.
> >>
> >> > +
> >>
> >> No empty line before the help.
> >>
> >> > +     help
> >> > +             Graphic realtime audio programming language
> >> > +             http://msp.ucsd.edu/software.htm
> >>
> >> Indentation for the help text is TAB-space-space. As suggested by Matt,
> >> use:
> >>
> >>     ./utils/check-package package/puredata/*
> >>
> >> Also, there is a better-looking homepage for Pure Data, maybe we can use
> >> it instead: http://puredata.info/ ?
> >>
> >> [--SNIP--]
> >> > diff --git a/package/puredata/puredata.mk b/package/puredata/puredata.mk
> >> > new file mode 100644
> >> > index 0000000000..842970b983
> >> > --- /dev/null
> >> > +++ b/package/puredata/puredata.mk
> >> > @@ -0,0 +1,34 @@
> >> > +################################################################################
> >> > +#
> >> > +# puredata
> >> > +#
> >> > +################################################################################
> >> > +
> >> > +PUREDATA_VERSION =  0.49-0
> >> > +PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
> >> > +PUREDATA_SITE = http://msp.ucsd.edu/Software
> >> > +PUREDATA_INSTALL_STAGING = YES
> >>
> >> Why does it need to be installed in staging? Is this providing a
> >> library?
> >>
> >> > +PUREDATA_INSTALL_TARGET = YES
> >> > +PUREDATA_AUTORECONF = YES
> >> > +PUREDATA_CONF_OPTS = --no-recursion --disable-locales
> >> > +
> >> > +PUREDATA_DEPENDENCIES = alsa-utils tcl tk
> >> > +
> >> > +ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
> >> > +PUREDATA_CONF_OPTS += --enable-portaudio
> >> > +else
> >> > +PUREDATA_CONF_OPTS += --disable-portaudio
> >> > +endif
> >> > +
> >> > +ifeq ($(BR2_PACKAGE_JACK2),y)
> >> > +PUREDATA_CONF_OPTS += --enable-jack
> >> > +else
> >> > +PUREDATA_CONF_OPTS += --disable-jack
> >> > +endif
> >> > +
> >> > +define PUREDATA_RUN_AUTOGEN
> >> > +     cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
> >> > +endef
> >>
> >> Why do you need to run autogen.sh since you already have
> >> PUREDATA_AUTORECONF=YES ?
> >>
> >> autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES
> >> anyway. The only delta is that it also creates a directory, so your hook
> >> should just do that: create the m4/generated directory. Also, make it a
> >> post-extract hook.
> >>
> >> Regards,
> >> Yann E. MORIN.
> >>
> >> > +PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
> >> > +
> >> > +$(eval $(autotools-package))
> >> > --
> >> > 2.11.0
> >> >
> >> > _______________________________________________
> >> > buildroot mailing list
> >> > buildroot@busybox.net
> >> > http://lists.busybox.net/mailman/listinfo/buildroot
> >>
> >> --
> >>                                         ____________
> >> .-----------------.--------------------:       _    :------------------.
> >> |  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
> >> | +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
> >> | +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
> >> |      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |
> >> '--------------------------------------:______/_____:------------------'
> >>
> >>
> >> _________________________________________________________________________________________________________________________
> >>
> >> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
> >> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
> >> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
> >> Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
> >>
> >> This message and its attachments may contain confidential or privileged information that may be protected by law;
> >> they should not be distributed, used or copied without authorisation.
> >> If you have received this email in error, please notify the sender and delete this message and its attachments.
> >> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
> >> Thank you.
> >>
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
>
>
> --
>
> Matthew Weber | Pr. Software Engineer | Commercial Avionics
>
> COLLINS AEROSPACE
>
> 400 Collins Road NE, Cedar Rapids, Iowa 52498, USA
>
> Tel: +1 319 295 7349 | FAX: +1 319 263 6099
>
> matthew.weber@collins.com | collinsaerospace.com
>
>
>
> CONFIDENTIALITY WARNING: This message may contain proprietary and/or
> privileged information of Collins Aerospace and its affiliated
> companies. If you are not the intended recipient, please 1) Do not
> disclose, copy, distribute or use this message or its contents. 2)
> Advise the sender by return email. 3) Delete all copies (including all
> attachments) from your computer. Your cooperation is greatly
> appreciated.
>
>
> Any export restricted material should be shared using my
> matthew.weber@corp.rockwellcollins.com address.

Patch

diff --git a/package/Config.in b/package/Config.in
index 0df9b73088..e029de53db 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -45,6 +45,7 @@  menu "Audio and video applications"
 	source "package/on2-8170-libs/Config.in"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
+	source "package/puredata/Config.in"
 	source "package/sox/Config.in"
 	source "package/squeezelite/Config.in"
 	source "package/tovid/Config.in"
diff --git a/package/puredata/Config.in b/package/puredata/Config.in
new file mode 100644
index 0000000000..c8bafe8885
--- /dev/null
+++ b/package/puredata/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_PUREDATA
+	bool "puredata"
+	select BR2_PACKAGE_TK
+	select BR2_PACKAGE_TCL
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_ALSA_UTILS
+	select BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XAPP_XAUTH
+
+	help
+		Graphic realtime audio programming language
+		http://msp.ucsd.edu/software.htm
diff --git a/package/puredata/puredata.hash b/package/puredata/puredata.hash
new file mode 100644
index 0000000000..505dbe3679
--- /dev/null
+++ b/package/puredata/puredata.hash
@@ -0,0 +1,2 @@ 
+# Locally calculated
+d2e04e75d22b0e41f27daacc0cd6ec6b05ae0ef214cc7315d57e5bfbeec23fa3  pd-0.49-0.src.tar.gz
diff --git a/package/puredata/puredata.mk b/package/puredata/puredata.mk
new file mode 100644
index 0000000000..842970b983
--- /dev/null
+++ b/package/puredata/puredata.mk
@@ -0,0 +1,34 @@ 
+################################################################################
+#
+# puredata
+#
+################################################################################
+
+PUREDATA_VERSION =  0.49-0
+PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
+PUREDATA_SITE = http://msp.ucsd.edu/Software
+PUREDATA_INSTALL_STAGING = YES
+PUREDATA_INSTALL_TARGET = YES
+PUREDATA_AUTORECONF = YES
+PUREDATA_CONF_OPTS = --no-recursion --disable-locales
+
+PUREDATA_DEPENDENCIES = alsa-utils tcl tk
+
+ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
+PUREDATA_CONF_OPTS += --enable-portaudio
+else
+PUREDATA_CONF_OPTS += --disable-portaudio
+endif
+
+ifeq ($(BR2_PACKAGE_JACK2),y)
+PUREDATA_CONF_OPTS += --enable-jack
+else
+PUREDATA_CONF_OPTS += --disable-jack
+endif
+
+define PUREDATA_RUN_AUTOGEN
+	cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef
+PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
+
+$(eval $(autotools-package))