From patchwork Mon Jan 7 22:05:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 1021618 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l5f6mgGu"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43YTx32w0Tz9sD9 for ; Tue, 8 Jan 2019 09:05:59 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 841F485F84; Mon, 7 Jan 2019 22:05:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BrQUJEPVmi4O; Mon, 7 Jan 2019 22:05:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id DD12C85F81; Mon, 7 Jan 2019 22:05:55 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 12F311C296D for ; Mon, 7 Jan 2019 22:05:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 101E185F81 for ; Mon, 7 Jan 2019 22:05:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J7BGtfCNRfFN for ; Mon, 7 Jan 2019 22:05:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 6779E85F7E for ; Mon, 7 Jan 2019 22:05:52 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id h50so2358884ede.5 for ; Mon, 07 Jan 2019 14:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=FocLE0A/PbQdmy9ibke+caT4tjTzK/EYO4BfRJB4XbU=; b=l5f6mgGuazcRut9nXaihE11offfOprPA9+tmwmr8egA90a48TUvgNkpZpzycmSSJJl br7tGYOfTyL8xt6SPS0O8V9tmHGVbrcRVDFHxUxkLERLhr0MEoumL9n124u51CATszEW /HVXO5T12GYPutjLoNj4u8kh5slWMUEhYhSM5Q1rUfsH0sI9z4U+tyO4xJyvZP+fR0GQ 2JVG3pInK/p/JEAibDTYLQ90gbEkooXAfvg5RcEY0VupB/1wbFQzeK3jNe1jYkLmZOfi YoMgwbxFMHzUrt837sNnmG647isjH7g9BcoupyyOmuV9QXws9kZhwWpGGZxXw9rfQnHi 6wrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=FocLE0A/PbQdmy9ibke+caT4tjTzK/EYO4BfRJB4XbU=; b=SmJsf4+2Cvgl4Fb2uP8GnU3OLCCJ15VBLnz95VVUbPFwqfpg5kJNfv6VeKTHRJ+ina Zn4R5R7FQB56SAitKORAoUMdJ9UAFCAV5Kcn5UmD57KCiblr4X/dA9/dHArJpeC9T+QM 2qhAWQ7Z20l/JPxFDmvNW7grkpkuHi6zzAIhMy5RimQ3aPDDWEpPf37GuEJ9QXqm3TKK sU+ZuOlE9b+MD+1fkDUeKGogPpHY7bIyNwU5sQwn3pnu3XaCabHZ4R9RyUEDRV7W8cmO IQ/7/jCA0XrN3nxLBHSfqImKJiQwUK6dq7G0gfajHKb7AAXnwnVh3Ya0NRRN4xZZaIvk 55Ag== X-Gm-Message-State: AA+aEWb9rI1OUaGcZHGSHyjxXGEpHojqw19UhWgaMtp0nMO55nKDck6P BOE72W5jeqWf5t9rA6H+hAU5766p X-Google-Smtp-Source: AFSGD/VaqMBxqd7LmVC52eGsycghuqZAx32l/n+nnB5q2UzgCjhpaWMh2jKnEpu8FYtQ7Sf5FRjE0w== X-Received: by 2002:a17:906:4684:: with SMTP id a4-v6mr49379869ejr.24.1546898750634; Mon, 07 Jan 2019 14:05:50 -0800 (PST) Received: from scaer.home ([2a01:cb19:829a:2800:68e8:7a61:9bb9:12a]) by smtp.gmail.com with ESMTPSA id d56sm31799589ede.76.2019.01.07.14.05.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jan 2019 14:05:50 -0800 (PST) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Mon, 7 Jan 2019 23:05:28 +0100 Message-Id: <8c891d4245028f97585d0e55ab5962e6ea337659.1546898693.git.yann.morin.1998@free.fr> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: Subject: [Buildroot] [PATCH 06/19] infra/pkg-generic: only list files installed by the current package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E. MORIN" MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Since 7fb6e782542f (core/instrumentation: shave minutes off the build time), the built stampfile is used as a reference to detect files installed by a package. However, this falls short during development, when a user may want to re-install a built-early package without rebuilding it (i.e. make foo-reinstall). In this case, the built stampfile is not touched, and is still dated from way back when the package was first built. As such, almost all files in target (or staging or host) are newer than that, and so those files are all now accounted for that package, when in fact only a minor subset may be accountable to it. We fix that by limiting the search for files that have been actually touched during the install step, now that we have the proper timestamp for it. Reported-by: Nicolas Cavallari Signed-off-by: "Yann E. MORIN" Cc: Nicolas Cavallari --- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 3de8a99675..42aebeb49d 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -67,7 +67,7 @@ define step_pkg_size_inner $(SED) '/^$(1),/d' $(BUILD_DIR)/packages-file-list$(3).txt cd $(2); \ find . \( -type f -o -type l \) \ - -newer $($(PKG)_DIR)/.stamp_built \ + -newer $@_before \ -exec printf '$(1),%s\n' {} + \ >> $(BUILD_DIR)/packages-file-list$(3).txt endef