From patchwork Mon Jun 27 11:43:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: MyungJoo Ham X-Patchwork-Id: 102148 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pw0-f56.google.com (mail-pw0-f56.google.com [209.85.160.56]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id B0695B6F6B for ; Mon, 27 Jun 2011 21:43:32 +1000 (EST) Received: by pwi1 with SMTP id 1sf3127922pwi.11 for ; Mon, 27 Jun 2011 04:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:mime-version:x-beenthere:received-spf:x-auditid :date:from:subject:in-reply-to:to:cc:message-id:x-mailer:references :x-originalarrivaltime:x-brightmail-tracker:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=5S8KPPWQXxX9MKCh/XAgnmdi6aPXNEDQoun4DcV1V9k=; b=rVhjK8BBYVL3dO+Ge/q5N29ScNpkjocC+M5CRKcTSBko8QbO2uKXi9Robkt9lhPezC OWej1XAhPRzDHvaLkN8rMFshscjpzrQWYmncDkuCjm+ckTJI+o+uYBi24SIiCCME7y7n i8PV9fs5aQhgbAbsm+htROkbWjyugAIjSSNYY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:x-auditid:date:from:subject :in-reply-to:to:cc:message-id:x-mailer:references :x-originalarrivaltime:x-brightmail-tracker:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; b=04fcm6l5Sf70/Ff3YRW69DDVjajgfv7CXcegf/lwG8Y3wUeeX82g0Q66h2MmAiqVUD +laN+sLiyaVOwNXjYWcyB5p9u9q3z0PKDXc0ollDNC8GGGkFUdHoXDxpUYaKGA770b1X 57c6nBWMalCew2zWXM5TxZU0d1wzdL0z+w/ps= Received: by 10.142.211.16 with SMTP id j16mr976456wfg.69.1309175009545; Mon, 27 Jun 2011 04:43:29 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.68.59.41 with SMTP id w9ls1378903pbq.1.gmail; Mon, 27 Jun 2011 04:43:29 -0700 (PDT) Received: by 10.68.11.135 with SMTP id q7mr1278941pbb.81.1309175009009; Mon, 27 Jun 2011 04:43:29 -0700 (PDT) Received: by 10.68.11.135 with SMTP id q7mr1278940pbb.81.1309175008999; Mon, 27 Jun 2011 04:43:28 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gmr-mx.google.com with ESMTP id f8si11983614pbc.0.2011.06.27.04.43.28; Mon, 27 Jun 2011 04:43:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of myungjoo.ham@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgm1.samsung.com (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LNG001FX5WFV460@mailout4.samsung.com> for rtc-linux@googlegroups.com; Mon, 27 Jun 2011 20:43:27 +0900 (KST) X-AuditID: cbfee61a-b7c53ae000002dc1-b6-4e086cdf9a67 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (MMPCPMTA) with SMTP id 45.CD.11713.FDC680E4; Mon, 27 Jun 2011 20:43:27 +0900 (KST) Received: from TNRNDGASPAPP1.tn.corp.samsungelectronics.net ([165.213.149.150]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LNG007FO5WFLH@mmp2.samsung.com> for rtc-linux@googlegroups.com; Mon, 27 Jun 2011 20:43:27 +0900 (KST) Received: from localhost.localdomain ([165.213.219.116]) by TNRNDGASPAPP1.tn.corp.samsungelectronics.net with Microsoft SMTPSVC(6.0.3790.4675); Mon, 27 Jun 2011 20:43:42 +0900 Date: Mon, 27 Jun 2011 20:43:24 +0900 From: MyungJoo Ham Subject: [rtc-linux] [PATCH 1/3] rtc: rtc-s3c: Correct debug messages. In-reply-to: <1309175006-9218-1-git-send-email-myungjoo.ham@samsung.com> To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com Cc: Kukjin Kim , Changhwan Youn , ben-linux@fluff.org, a.zummo@towertech.it, kyungmin.park@samsung.com, dg77.kim@samsung.com, myungjoo.ham@gmail.com Message-id: <1309175006-9218-2-git-send-email-myungjoo.ham@samsung.com> X-Mailer: git-send-email 1.7.4.1 References: <1309175006-9218-1-git-send-email-myungjoo.ham@samsung.com> X-OriginalArrivalTime: 27 Jun 2011 11:43:42.0847 (UTC) FILETIME=[7719A8F0:01CC34BF] X-Brightmail-Tracker: AAAAAA== X-Original-Sender: myungjoo.ham@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of myungjoo.ham@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=myungjoo.ham@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , RTC-S3C used to print out debug messages incorrectly. This patch corrects incorrect outputs. (undecoded bcd numbers, incorrectly decoded register values) This patch affects the pr-debug messages only. Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- drivers/rtc/rtc-s3c.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 53c99b1..3c8dfa7 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -152,10 +152,6 @@ static int s3c_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm) goto retry_get_time; } - pr_debug("read time %04d.%02d.%02d %02d:%02d:%02d\n", - 1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday, - rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec); - rtc_tm->tm_sec = bcd2bin(rtc_tm->tm_sec); rtc_tm->tm_min = bcd2bin(rtc_tm->tm_min); rtc_tm->tm_hour = bcd2bin(rtc_tm->tm_hour); @@ -164,6 +160,11 @@ static int s3c_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm) rtc_tm->tm_year = bcd2bin(rtc_tm->tm_year); rtc_tm->tm_year += 100; + + pr_debug("read time %04d.%02d.%02d %02d:%02d:%02d\n", + 1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday, + rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec); + rtc_tm->tm_mon -= 1; clk_disable(rtc_clk); @@ -269,10 +270,9 @@ static int s3c_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) clk_enable(rtc_clk); pr_debug("s3c_rtc_setalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n", alrm->enabled, - 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, + 1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); - alrm_en = readb(base + S3C2410_RTCALM) & S3C2410_RTCALM_ALMEN; writeb(0x00, base + S3C2410_RTCALM); @@ -359,6 +359,7 @@ static void s3c_rtc_release(struct device *dev) free_irq(s3c_rtc_tickno, rtc_dev); } + static const struct rtc_class_ops s3c_rtcops = { .open = s3c_rtc_open, .release = s3c_rtc_release,