Patchwork net/can: activate bit-timing calculation and netlink based drivers by default

login
register
mail settings
Submitter Marc Kleine-Budde
Date June 27, 2011, 7:39 a.m.
Message ID <1309160391-22486-1-git-send-email-mkl@pengutronix.de>
Download mbox | patch
Permalink /patch/102119/
State Accepted
Delegated to: David Miller
Headers show

Comments

Marc Kleine-Budde - June 27, 2011, 7:39 a.m.
The two options "CAN bit-timing calculation" and
"Platform CAN drivers with Netlink support" have a "default Y". In order to
activate them by default, change to "default y".

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Wolfgang Grandegger - June 27, 2011, 8:02 a.m.
Hi Marc,

On 06/27/2011 09:39 AM, Marc Kleine-Budde wrote:
> The two options "CAN bit-timing calculation" and
> "Platform CAN drivers with Netlink support" have a "default Y". In order to
> activate them by default, change to "default y".
> 
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  drivers/net/can/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> index bbf06f7..f1f9fd9 100644
> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
> @@ -36,7 +36,7 @@ config CAN_SLCAN
>  config CAN_DEV
>  	tristate "Platform CAN drivers with Netlink support"
>  	depends on CAN
> -	default Y
> +	default y
>  	---help---
>  	  Enables the common framework for platform CAN drivers with Netlink
>  	  support. This is the standard library for CAN drivers.
> @@ -45,7 +45,7 @@ config CAN_DEV
>  config CAN_CALC_BITTIMING
>  	bool "CAN bit-timing calculation"
>  	depends on CAN_DEV
> -	default Y
> +	default y
>  	---help---
>  	  If enabled, CAN bit-timing parameters will be calculated for the
>  	  bit-rate specified via Netlink argument "bitrate" when the device

Acked-by: Wolfgang Grandegger <wg@grandegger.com>

Ahh, ohh, a trivial fix for a long-standing problem. Would be nice if
Kbuild would report such invalid default settings.

Thanks,

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marc Kleine-Budde - June 27, 2011, 8:04 a.m.
On 06/27/2011 10:02 AM, Wolfgang Grandegger wrote:
> Acked-by: Wolfgang Grandegger <wg@grandegger.com>
> 
> Ahh, ohh, a trivial fix for a long-standing problem. Would be nice if
> Kbuild would report such invalid default settings.

ACK, Marc

Send patches :)
Kurt Van Dijck - June 27, 2011, 3 p.m.
On Mon, Jun 27, 2011 at 09:39:51AM +0200, Marc Kleine-Budde wrote:
> The two options "CAN bit-timing calculation" and
> "Platform CAN drivers with Netlink support" have a "default Y". In order to
> activate them by default, change to "default y".
> 
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Acked-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - June 29, 2011, 12:58 p.m.
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Mon, 27 Jun 2011 09:39:51 +0200

> The two options "CAN bit-timing calculation" and
> "Platform CAN drivers with Netlink support" have a "default Y". In order to
> activate them by default, change to "default y".
> 
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index bbf06f7..f1f9fd9 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -36,7 +36,7 @@  config CAN_SLCAN
 config CAN_DEV
 	tristate "Platform CAN drivers with Netlink support"
 	depends on CAN
-	default Y
+	default y
 	---help---
 	  Enables the common framework for platform CAN drivers with Netlink
 	  support. This is the standard library for CAN drivers.
@@ -45,7 +45,7 @@  config CAN_DEV
 config CAN_CALC_BITTIMING
 	bool "CAN bit-timing calculation"
 	depends on CAN_DEV
-	default Y
+	default y
 	---help---
 	  If enabled, CAN bit-timing parameters will be calculated for the
 	  bit-rate specified via Netlink argument "bitrate" when the device