[U-Boot] sf: Add Macronix MX25R6435F SPI NOR flash to flash parameters array
diff mbox series

Message ID 1546839327-19845-1-git-send-email-ye.li@nxp.com
State Rejected
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series
  • [U-Boot] sf: Add Macronix MX25R6435F SPI NOR flash to flash parameters array
Related show

Commit Message

Ye Li Jan. 7, 2019, 5:35 a.m. UTC
On i.MX7ULP EVK board, we use MX25R6435F NOR flash, add its parameters
and IDs to flash parameter array. Otherwise, the flash probe will fails.

Signed-off-by: Ye Li <ye.li@nxp.com>
---
 drivers/mtd/spi/spi_flash_ids.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jagan Teki Feb. 14, 2019, 5:09 p.m. UTC | #1
+ Vignesh

On Mon, Jan 7, 2019 at 11:05 AM Ye Li <ye.li@nxp.com> wrote:
>
> On i.MX7ULP EVK board, we use MX25R6435F NOR flash, add its parameters
> and IDs to flash parameter array. Otherwise, the flash probe will fails.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> ---
>  drivers/mtd/spi/spi_flash_ids.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi/spi_flash_ids.c b/drivers/mtd/spi/spi_flash_ids.c
> index ad0a0c8..17f9893 100644
> --- a/drivers/mtd/spi/spi_flash_ids.c
> +++ b/drivers/mtd/spi/spi_flash_ids.c
> @@ -94,6 +94,7 @@ const struct spi_flash_info spi_flash_ids[] = {
>         {"mx25u25635f",    INFO(0xc22539, 0x0, 64 * 1024,   512, RD_FULL | WR_QPP) },
>         {"mx66u51235f",    INFO(0xc2253a, 0x0, 64 * 1024,  1024, RD_FULL | WR_QPP) },
>         {"mx66l1g45g",     INFO(0xc2201b, 0x0, 64 * 1024,  2048, RD_FULL | WR_QPP) },
> +       {"mx25r6435f",     INFO(0xc22817, 0x0, 64 * 1024,  128, RD_FULL | SECT_4K) },

Look like this would also support WR_QPP, how about updating the same?
Vignesh Raghavendra Feb. 15, 2019, 6:15 a.m. UTC | #2
On 14/02/19 10:39 PM, Jagan Teki wrote:
> + Vignesh
> 
> On Mon, Jan 7, 2019 at 11:05 AM Ye Li <ye.li@nxp.com> wrote:
>>
>> On i.MX7ULP EVK board, we use MX25R6435F NOR flash, add its parameters
>> and IDs to flash parameter array. Otherwise, the flash probe will fails.
>>
>> Signed-off-by: Ye Li <ye.li@nxp.com>
>> ---
>>  drivers/mtd/spi/spi_flash_ids.c | 1 +

This file no longer exists after recent SPI NOR migration. Could you
rebase on the latest? The capabilities flags are now same as kernel.


>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi/spi_flash_ids.c b/drivers/mtd/spi/spi_flash_ids.c
>> index ad0a0c8..17f9893 100644
>> --- a/drivers/mtd/spi/spi_flash_ids.c
>> +++ b/drivers/mtd/spi/spi_flash_ids.c
>> @@ -94,6 +94,7 @@ const struct spi_flash_info spi_flash_ids[] = {
>>         {"mx25u25635f",    INFO(0xc22539, 0x0, 64 * 1024,   512, RD_FULL | WR_QPP) },
>>         {"mx66u51235f",    INFO(0xc2253a, 0x0, 64 * 1024,  1024, RD_FULL | WR_QPP) },
>>         {"mx66l1g45g",     INFO(0xc2201b, 0x0, 64 * 1024,  2048, RD_FULL | WR_QPP) },
>> +       {"mx25r6435f",     INFO(0xc22817, 0x0, 64 * 1024,  128, RD_FULL | SECT_4K) },
> 
> Look like this would also support WR_QPP, how about updating the same?
>

Patch
diff mbox series

diff --git a/drivers/mtd/spi/spi_flash_ids.c b/drivers/mtd/spi/spi_flash_ids.c
index ad0a0c8..17f9893 100644
--- a/drivers/mtd/spi/spi_flash_ids.c
+++ b/drivers/mtd/spi/spi_flash_ids.c
@@ -94,6 +94,7 @@  const struct spi_flash_info spi_flash_ids[] = {
 	{"mx25u25635f",    INFO(0xc22539, 0x0, 64 * 1024,   512, RD_FULL | WR_QPP) },
 	{"mx66u51235f",    INFO(0xc2253a, 0x0, 64 * 1024,  1024, RD_FULL | WR_QPP) },
 	{"mx66l1g45g",     INFO(0xc2201b, 0x0, 64 * 1024,  2048, RD_FULL | WR_QPP) },
+	{"mx25r6435f",     INFO(0xc22817, 0x0, 64 * 1024,  128, RD_FULL | SECT_4K) },
 #endif
 #ifdef CONFIG_SPI_FLASH_SPANSION	/* SPANSION */
 	{"s25fl008a",	   INFO(0x010213, 0x0, 64 * 1024,    16, 0) },