Message ID | 201901060634.AA04158@tamuki.linet.gr.jp |
---|---|
State | New |
Headers | show |
Series | strftime: Improve the width of alternate representation for year [BZ #23758] | expand |
This patch is actually just a one-liner and it fixes the problem. I would prefer if the patch 5/5 was split and the documentation relating to the width of %Ey was merged with this patch and pushed together but we can also push it now and work on the documentation later. Siddhesh (CC:), are you OK to push this patch now and work on the documentation later? Other people are welcome to review the commit comment and provide feedback related with the language correctness. Regards, Rafal
On 09/01/19 3:37 PM, Rafal Luzynski wrote: > This patch is actually just a one-liner and it fixes the problem. > I would prefer if the patch 5/5 was split and the documentation > relating to the width of %Ey was merged with this patch and pushed > together but we can also push it now and work on the documentation > later. > > Siddhesh (CC:), are you OK to push this patch now and work on > the documentation later? Patch is OK for inclusion in 2.29, but please push it with the documentation; we don't want a situation where a flag is in but not the documentation. Siddhesh
9.01.2019 11:25 Siddhesh Poyarekar <siddhesh@gotplt.org> wrote: > [...] > Patch is OK for inclusion in 2.29, but please push it with the > documentation; we don't want a situation where a flag is in but not the > documentation. That means: please don't push this patch nor anything else (except the patch 1/5, as I mentioned in the previous email). We need to work on the documentation first and push only when everything is ready. Regards, Rafal
Hello Rafal, From: Rafal Luzynski <digitalfreak@lingonborough.com> Subject: Re: [PATCH v5 2/5] strftime: Set the default width of "%Ey" to 2 [BZ #23758] Date: Wed, 9 Jan 2019 11:07:32 +0100 (CET) > This patch is actually just a one-liner and it fixes the problem. > I would prefer if the patch 5/5 was split and the documentation > relating to the width of %Ey was merged with this patch and pushed > together but we can also push it now and work on the documentation > later. As Siddhesh mentioned, I will revise the patch to include the documentation. Regards, TAMUKI Shoichi
diff --git a/time/strftime_l.c b/time/strftime_l.c index 7ba4179de3e..cbe08e7afb4 100644 --- a/time/strftime_l.c +++ b/time/strftime_l.c @@ -1294,7 +1294,7 @@ __strftime_internal (CHAR_T *s, size_t maxsize, const CHAR_T *format, if (era) { int delta = tp->tm_year - era->start_date[0]; - DO_NUMBER (1, (era->offset + DO_NUMBER (2, (era->offset + delta * era->absolute_direction)); } #else