configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup")
diff mbox series

Message ID 20190101111334.3115-1-firasuke@gmail.com
State Superseded
Delegated to: stephen hemminger
Headers show
Series
  • configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup")
Related show

Commit Message

Firas Khalil Khana Jan. 1, 2019, 11:13 a.m. UTC
From: Firas Khalil Khana <firasuke@gmail.com>

Fixes: 377a09902a57 ("configure: Minor code cleanup")

Signed-off-by: Firas Khalil Khana <firasuke@gmail.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiner Kallweit Jan. 1, 2019, 2:38 p.m. UTC | #1
On 01.01.2019 12:13, firasuke@gmail.com wrote:
> From: Firas Khalil Khana <firasuke@gmail.com>
> 
> Fixes: 377a09902a57 ("configure: Minor code cleanup")
> 
I think the patch should be annotated iproute2 to make clear
it's not about the kernel. And it's missing a description
which issue was fixed.

> Signed-off-by: Firas Khalil Khana <firasuke@gmail.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index b85eb58b..45fcffb6 100755
> --- a/configure
> +++ b/configure
> @@ -115,7 +115,7 @@ EOF
>  check_xt_old_internal_h()
>  {
>      # bail if previous XT checks has already succeeded.
> -    grep -q if grep -q TC_CONFIG_XT $CONFIG && return
> +    grep -q TC_CONFIG_XT $CONFIG && return
>  
>      #check if we need our own internal.h
>      cat >$TMPDIR/ipttest.c <<EOF
>

Patch
diff mbox series

diff --git a/configure b/configure
index b85eb58b..45fcffb6 100755
--- a/configure
+++ b/configure
@@ -115,7 +115,7 @@  EOF
 check_xt_old_internal_h()
 {
     # bail if previous XT checks has already succeeded.
-    grep -q if grep -q TC_CONFIG_XT $CONFIG && return
+    grep -q TC_CONFIG_XT $CONFIG && return
 
     #check if we need our own internal.h
     cat >$TMPDIR/ipttest.c <<EOF