NEWS: Fix a minor typo ("incosistent" -> "inconsistent").

Message ID 1021853475.594941.1545948806002@poczta.nazwa.pl
State New
Headers show
Series
  • NEWS: Fix a minor typo ("incosistent" -> "inconsistent").
Related show

Commit Message

Rafal Luzynski Dec. 27, 2018, 10:13 p.m.
This looks like an obvious fix but I'm asking for confirmation
just in case.  OK for master now?

While at this, "multithread environment" or "multithreaded environment"?

Regards,

Rafal


From: Rafal Luzynski <digitalfreak@lingonborough.com>
Date: Thu, 27 Dec 2018 23:04:14 +0100

---
 NEWS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 * Support for the C-SKY ABIV2 running on Linux has been added.  This port

Comments

Florian Weimer Dec. 27, 2018, 10:46 p.m. | #1
* Rafal Luzynski:

> This looks like an obvious fix but I'm asking for confirmation
> just in case.  OK for master now?

Looks okay, thanks.

> While at this, "multithread environment" or "multithreaded environment"?

I would write “in a multi-threaded process”.
Rafal Luzynski Dec. 28, 2018, 8:06 a.m. | #2
27.12.2018 23:46 Florian Weimer <fw@deneb.enyo.de> wrote:
> 
> * Rafal Luzynski:
> 
> > This looks like an obvious fix but I'm asking for confirmation
> > just in case.  OK for master now?
> 
> Looks okay, thanks.

Thanks, pushed now as e46d7dedcfccb283f008be2900227318f314dbea.

> > While at this, "multithread environment" or "multithreaded environment"?
> 
> I would write “in a multi-threaded process”.

Perhaps we'll need another commit for this.  "I would write" sounds
to me like you are not absolutely sure.  None of us is an English
native speaker, can some native speakers (or just experts) chime in
and help us, please?

Regards,

Rafal
Paul Eggert Dec. 28, 2018, 4:56 p.m. | #3
Rafal Luzynski wrote:
>> I would write “in a multi-threaded process”.
> Perhaps we'll need another commit for this.  "I would write" sounds
> to me like you are not absolutely sure.  None of us is an English
> native speaker, can some native speakers (or just experts) chime in
> and help us, please?

Florian is right. Also, the word "a" is missing. Please change "after fork call 
in multithread environment" to "after a fork call in a multi-threaded process". 
This is the terminology used in 
<http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_atfork.html> 
except that the GNU style does not put "()" after function names. Thanks.

Patch

diff --git a/NEWS b/NEWS
index 4a24d9f..454de5b 100644
--- a/NEWS
+++ b/NEWS
@@ -43,7 +43,7 @@  Major new features:
 * The popen and system do not run atfork handlers anymore (BZ#17490).
   Although it is a possible POSIX violation, the POSIX rationale in
   pthread_atfork documentation regarding atfork handlers is to handle
-  incosistent mutex state after fork call in multithread environment.
+  inconsistent mutex state after fork call in multithread environment.
   In both popen and system there is no direct access to user-defined
mutexes.