From patchwork Wed Dec 26 16:08:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 1018696 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=mit.edu header.i=@mit.edu header.b="AI7pXpaP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43PyZC22Wsz9s6w for ; Thu, 27 Dec 2018 03:08:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbeLZQI0 (ORCPT ); Wed, 26 Dec 2018 11:08:26 -0500 Received: from mail-eopbgr710129.outbound.protection.outlook.com ([40.107.71.129]:21856 "EHLO NAM05-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725921AbeLZQI0 (ORCPT ); Wed, 26 Dec 2018 11:08:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CCOR0ph+LQKfBRHycJtdMmzmvmF6DXttVNQMXRK9YlM=; b=AI7pXpaPRO4ihoGrt7K2Po9WuCkgRHK5tRgqgHsxRfYsR11EuPWKk9b1tFR+YmOh33LmCUjfug3ako2/bIS++3SF1uwCsYX38CSO1p7h1aQ6yXACsOpRgRXTkf5uAyfMN5x2zPNpItjWcmjjGkYoOf8W4snhQtBqDYW/spG8lJg= Received: from BN6PR0101CA0023.prod.exchangelabs.com (2603:10b6:405:2a::36) by MWHPR01MB2815.prod.exchangelabs.com (2603:10b6:300:f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1446.21; Wed, 26 Dec 2018 16:08:21 +0000 Received: from CO1NAM03FT038.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e48::202) by BN6PR0101CA0023.outlook.office365.com (2603:10b6:405:2a::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.20 via Frontend Transport; Wed, 26 Dec 2018 16:08:20 +0000 Authentication-Results: spf=pass (sender IP is 18.9.28.11) smtp.mailfrom=mit.edu; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=mit.edu; Received-SPF: Pass (protection.outlook.com: domain of mit.edu designates 18.9.28.11 as permitted sender) receiver=protection.outlook.com; client-ip=18.9.28.11; helo=outgoing.mit.edu; Received: from outgoing.mit.edu (18.9.28.11) by CO1NAM03FT038.mail.protection.outlook.com (10.152.81.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13 via Frontend Transport; Wed, 26 Dec 2018 16:08:20 +0000 Received: from callcc.thunk.org (75-104-87-253.mobility.exede.net [75.104.87.253] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id wBQG88PJ017241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Dec 2018 11:08:16 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 4CCC77A4909; Wed, 26 Dec 2018 11:08:08 -0500 (EST) From: Theodore Ts'o To: CC: Ext4 Developers List , Theodore Ts'o , Liu Bo Subject: [PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034 Date: Wed, 26 Dec 2018 11:08:05 -0500 Message-ID: <20181226160805.8987-1-tytso@mit.edu> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:18.9.28.11; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(136003)(346002)(39860400002)(376002)(396003)(2980300002)(199004)(189003)(75432002)(47776003)(2351001)(246002)(476003)(51416003)(26005)(103686004)(6636002)(8936002)(106002)(186003)(305945005)(486006)(4326008)(8676002)(2616005)(50226002)(90966002)(5660300001)(126002)(2870700001)(6666004)(316002)(88552002)(2171002)(6266002)(39060400002)(52956003)(50466002)(1076003)(478600001)(26826003)(48376002)(36906005)(786003)(2906002)(6862004)(356004)(86362001)(575784001)(14444005)(106466001)(42186006)(37006003)(336012)(54906003)(36756003)(42866002); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR01MB2815; H:outgoing.mit.edu; FPR:; SPF:Pass; LANG:en; PTR:outgoing-auth-1.mit.edu; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM03FT038; 1:IhMe5mf0t2BxegczoVe4YFYXKyGM6yrOTyjZrp2g6LL/3u94VQGqZjGLHJgflN/efpE3CFKxJQyJajxB8IRNcuHtm4+hGhK8ZUNtnJHpQW4/ZpJWYFbWjZWvN7ulUi0a X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25cc0c10-5bec-4dc1-7feb-08d66b4c5adf X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4608076)(2017052603328)(7153060); SRVR:MWHPR01MB2815; X-Microsoft-Exchange-Diagnostics: 1; MWHPR01MB2815; 3:6tJN/xHKPIIHV6a5ctyRvvCUJaeJRRv2kL6xKAO5jVICVNOUiGa6O95uJeg6BVepwe3LTKF63ZL9G5elr6uQX36U/EkeZiciZDMdhaiYnSGnjsG0vNO6WAzBzIQbJt6SNjCThSnF69dVqs7KYLbqUMSp0OiOIcpaCldZm9E567jLwX3cqkStqAiG7Q+4/aCqIhlH5f9nHjZpFvKF4eL9O1tpXdBXc2uqWYncVRocYC0FE/tjoSwRB8wNk2RiC/yS7WOMy8qDQb3WMCwRmaC+nSlYIweuOfqTmHKbOgcyZ5W2Dnbx7X83tRKR7p15FwO937oqgPMzgYl74qcT0ehFIQ==; 25:tIkLvd7qBz6WobvVg65ZHMcV/ACrWA2O6sXfDc1XeAZUa1IRu4Fcr0G5cfz740WGctgSsw/Riv+D9PeNq4ubtbAFi1vajBkVOvTX0d4UqQD8sT/MInrjK7DTEaOj5rEzyww71iGcTWll4aBmq2Fs5AD6AE5NVOH9wFb02mt8BAT8NLfQobGkUL5zk/Ixw4a8YkXt02yZ085yabV3tiMqO21mTPEMTw/ABBMOQDkCInSjMbavj2s+GpP+4KMZBeN2csaYhN17onk6jmcExN2I+VgWxOUu9Jwzgp4qwISH43e+P4a0RTfdDhz6W+8Co3mjSXSJVewjsVF5X2/k/NGgIg==; 31:tcoI8s3yt2dFfYLzptj+uzVj7S3mmqpcQyAip7q394RoIpDIUsbK9zNUQ4aSx7eo+aJwsDaMqxKbaX/lBg7CHTIO7EJO6vmvoGcgNN4CnxVpYm951q/rkw2BRkTJW3/tBhrMWYrYK/9DTbPEvhsVQH7OqtR7sNlELdH/7zjSEaaO11UF+kCnWbM8Jecd+oBcO5e/0IcitdSi85JsPeNlKmrfrDcfk7jLt55q0CwVJyM= X-MS-TrafficTypeDiagnostic: MWHPR01MB2815: X-Microsoft-Exchange-Diagnostics: 1; MWHPR01MB2815; 20:TX5qavVebo6U/KEG2+467huXor1aW5uUCDeuD3wapcWd21xC9Gdxu4ZEx4lKbAr17ZEo7BPkQYoDN+dU2mxDxVrERKvIR4Ed9/uaSvkQrjgyxhoFmGd4l/5IbC+mLr277o2DQhpFqsQ2eahepABNFNSSR7/c5o+1kUzQm6UMVrXeV7Ysm9C6Mm8eH4vzvyfnt4EKaoIRMS6m4uIML27pfYoTkCz78+kUfz0tN11UmYJo1jvhzjhDZevWjyxajFicX1kljIraQ/63PYEjpFiXsr+UpzzDJdKOJFIbUtT8XfY3tOXB2jSVI6v6XE5oe2ayuQHhNZ+uPwhdf1B2i4ueMJcw08Nkck/vDF6J7avWOZmCgxalMUYtVsriIY85p7dJEO2s6cmv3yVEKp1rMZNJwcWz2TcRdATk0e795R20lkQhn7kajIVAIw0gfNXKrZkkI/IY0sXQPT7etit37v6Li3LWc4xEISoKUy+jFb57Q7RMwLGAIFWWP5fDzHuc+Ys9; 4:cxjXdnHzBbyPPRWgBQr3qjs9sECt2micYD+bn4ZA/DxkAM7dECVRAgANowLe2HTw24plhBX44HCU8F9HVvAMO02nrIqzxID9k2QeDqrafnvpoODTMaOqHWbXsSkL0P0leOssrRAFbwg9JMlVhNXMpLz5upze/tQfuzrqu56GtIrGzU+a0gRP3NXoguutzxV1659plHqOYFEmv7ZIxDaj1Zv7CVKeb90Hlj/glSwRuzMv/rZkkTDqyK/rk4raETBxHTHxixO2u2CX63db1hThDA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(93006095)(93004095)(3231475)(944501520)(52105112)(3002001)(10201501046)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(201702281529075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:MWHPR01MB2815; BCL:0; PCL:0; RULEID:; SRVR:MWHPR01MB2815; X-Forefront-PRVS: 0898A6E028 X-Microsoft-Exchange-Diagnostics: 1; MWHPR01MB2815; 23:vqrWocqBOH/8XFl29IyABO5+atplImNsJ1WbgPoqUFBZKnp18shAimPtaYNx8K3RhCXbUGX3NLB3IP6f7wCr3sNJNIC8B4MCzd2iL3ooXiLfyuagExxZDktGhkS1sSsbPHOpu8c6uDZbGCx4ZWY0hS0v+T9BUaMqK8G5L9RWzOHGAl9voJpJVMnHyRf1htLr4fueuTSBh7HH6CpnztoItXK8cliDtUL2wFOZRzxnuFbXa5/1HsQAR+mgGfMyKNmfAUOvlkEoX4yZnBT3p2B00SJigw4Q6FbeZfJWzDC53T6d2+S+aLOUjig1L8rGvZhzag64WpV9+wGJvdXp8YvvdX2gimB7tnqUs1f9LU2dM0r7mjz0Fg0S9oAWTql/GK0F7anaMg4I0nKadgYScyJVd64Riot+xfpF2gY5JvOm1N7LOElfKOFGosDiNn+nOWpiQaF3MItuWNBHE2Bkx3xhF08qJXpEqhNh7qmAtIbkE2sKLmDxMo2xCDP4lDPpG5NWf4yufIBRR4PDg2dycKgOLj2K6peyrLsusYt8lwJJ8B+gwyUiLm/9xZwgVn8CoKJEqd5EYor7JJVsuO/93kV7wzHCOl0WgPL8tuceWuye+b3D6atPY5lsRDLn6pU5bWMclltL4qEuY4pXrq5qvhf8NhqpuRr33jJjCc85IlYKX6dUgpGBYemMuoFpbQSoC3rpviUZeLHyuwZojVqzDAz3kWN6ft1Gck/UtdcfnXcGV0myHqDtsAyJBpNAbUNIHLT9CAjmUYxTMbRxFP0GazdZQDaJQ2U3XDcX6rX9a24CMGsoTGJ2vJ8ZzvuO4YcSFvX3dEbcceLrsjFaBxCRmXpqxIV7GoqxC5qqwHmTULuw+7ObLO5Po3CZKrOhoMSmOUlEm9tKZqElFTpLjXLTosKXZCyDhklVhPrxmu/6cGcMxT28DzcEa6eG4qX1q4GTlKmFXvgXq46H5BQqj05AQR3t6ZXBeu0toPi0eAIhWsi+40Ld4l0HEk5ZNRSLOcKLSkHyl6drue3DcNcWDfqena7KvRdFlcv1gj05XwdOI2cOfRB5QMNqec6z8kaCuYcIYwr5IoTPXy6wp0rwkJmN0jv8IPnbtxsWmfz70yUnWvWhTRgZXtyooe/rMpzrxzg1x1cSWJ4DBiwVcgF2kqLaj1wI034MpTFuRQ7klEqBJjh8mFpReXvMrYoXoKFMNcOqLKcL1qZRp7uULFD0EjMuX3vh+osoxds0WC3ykoU2yOdpDcWBKLvhpOrVqBkN3mBu6sg9 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: PclrZkWxDtA5BfZelWGbR6zerD+Ej9e5MzrJZCKq58W+jhCjWge0xI4VVwMDdmiTsNGGTE5mrah7CiAMnoSj6NTVpvQh7nTgW3kZ4PhZPAs1HD0XYVNYWZ2YowsdRH0zJ044ZcOpV3EaKR295MmwGXVUPwVD+3dAL+N/CIuqCsLSSpCM4gfpFFLhhOGuXxZ82kUJow0v/zctX/EyK2okQmrhP247pQbNNE7c6DVH1hXi8KsTh3cjZwziUJK857/7RJinJlARLhWpha6q4YqvrJZ31vLUlaV1VwwwHdMx2zdelfXKRyjypvzFT3I0Jt0y X-Microsoft-Exchange-Diagnostics: 1; MWHPR01MB2815; 6:bciohsyRv2C2DDdq8Ys3vBlj61/2FT6crsbCakIhG8ej5ilpV+jIKGXnQUzgsRdWwlCB6V/+xdi7j2rCB8vWOrGrJapGLRdHpTyaKMHk02wISaUyNioI6dY4o5yIsWj4Vm63tPdm+NFfLb4r2ThZgooaoMOr3H2xPz+DrXMRdzcaSw9mILpvC+H0Vikb7QWtfJrjNxNtn39y2Tjh00Hkh5DsSK3DMT3M+LYShjHqfxgzgNDyYxt8es06W2wrDeNLMA/ize7nbTp5d5fl6r0u6wEfjhFweJiHkqc7uT8lHGeYTOAoG9NK0shj0oSyzXP8Dg7cXgXiqEnPK2C7QUDSH+uvUi2WsvzIJnRc0T0ZyLh8bcQm/TC47y+GdzcEPElWjENdp5al4odfioAPQqpb2ytadgoh2IZ1otBa8qmb6RiFSKzwwAYHYLcroaxhRRKht/ueA48Y46fzWwJ/ByMG9w==; 5:obtg1w8OR7LUrV0/QvDFUQT3mLzhbllcWKtk4Wt2ViDcy8jR61T1OqObES3fezFU6N258u5JeVVYA/sPG47qSGUkApEYWe1nYv/WjODa9sul3xxDPptJL0I9WrrbizBeXCOEhZ5TOu29x2HIeRhcyCUIkAr6GPexRQUQId2ccVg=; 7:o/fWUgoFeAhTrDd+79e2YAVLsCIVJh6ele3HI+OzHWL7oauVpZbTleVfih77dkhVQlQ/xCWmueW6nIR3zrJQ6g5LPo8pWOzEQWS5pIRGcSdS8Ycbk/4lrR6tFazxHb+kGPj2IkSWsJl8vlB3O89vhw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: mit.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Dec 2018 16:08:20.2662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25cc0c10-5bec-4dc1-7feb-08d66b4c5adf X-MS-Exchange-CrossTenant-Id: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=64afd9ba-0ecf-4acf-bc36-935f6235ba8b; Ip=[18.9.28.11]; Helo=[outgoing.mit.edu] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR01MB2815 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Also add a requirment that fallocate and fiemap is supported. (Fallocate isn't the case when we are emulating ext3, for example.) Signed-off-by: Theodore Ts'o Cc: Liu Bo --- tests/ext4/034 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/ext4/034 b/tests/ext4/034 index 5c34d0d9..f9e4bfaf 100755 --- a/tests/ext4/034 +++ b/tests/ext4/034 @@ -8,7 +8,7 @@ # "-o dioread_nolock,nodelalloc" is used. # # The bug was fixed by commit -# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled" +# "ext4: make sure enough credits are reserved for dioread_nolock writes" # seq=`basename $0` seqres=$RESULT_DIR/$seq @@ -41,6 +41,8 @@ _supported_os Linux _require_scratch _require_quota _require_nobody +_require_xfs_io_command "falloc" +_require_xfs_io_command "fiemap" _require_xfs_io_command "syncfs" echo "Format and mount"