Message ID | 20181226135434.GA16510@bogon.m.sigxcpu.org |
---|---|
State | New |
Headers | show |
Series | [v2] pinctrl: scu: Depend on IMX_SCU | expand |
Hi Guido, On Wed, Dec 26, 2018 at 11:54 AM Guido Günther <agx@sigxcpu.org> wrote: > > Otherwise building fails with only PINCTRL_IMX_SCU selected: > > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': > pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': > pinctrl-scu.c:(.text+0x64): undefined reference to `imx_scu_call_rpc' > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x64): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': > pinctrl-scu.c:(.text+0x104): undefined reference to `imx_scu_call_rpc' > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x104): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > make: *** [Makefile:1038: vmlinux] Error 1 > > Signed-off-by: Guido Günther <agx@sigxcpu.org> Thanks for the fix: Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Wed, Dec 26, 2018 at 2:54 PM Guido Günther <agx@sigxcpu.org> wrote: > Otherwise building fails with only PINCTRL_IMX_SCU selected: > > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': > pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': > pinctrl-scu.c:(.text+0x64): undefined reference to `imx_scu_call_rpc' > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x64): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': > pinctrl-scu.c:(.text+0x104): undefined reference to `imx_scu_call_rpc' > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x104): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > make: *** [Makefile:1038: vmlinux] Error 1 > > Signed-off-by: Guido Günther <agx@sigxcpu.org> Patch applied with Fabio's ACK. Yours, Linus Walleij
Hi Linus, On Thu, Dec 27, 2018 at 10:38:03AM +0100, Linus Walleij wrote: > On Wed, Dec 26, 2018 at 2:54 PM Guido Günther <agx@sigxcpu.org> wrote: > > > Otherwise building fails with only PINCTRL_IMX_SCU selected: > > > > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': > > pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' > > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' > > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': > > pinctrl-scu.c:(.text+0x64): undefined reference to `imx_scu_call_rpc' > > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x64): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': > > pinctrl-scu.c:(.text+0x104): undefined reference to `imx_scu_call_rpc' > > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x104): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > > make: *** [Makefile:1038: vmlinux] Error 1 > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > Patch applied with Fabio's ACK. Thanks! Excuse my ignorance but which tree would I pull in for that? I didn't see it on https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/ Cheers, -- Guido
On Fri, Dec 28, 2018 at 5:14 PM Guido Günther <agx@sigxcpu.org> wrote: > Hi Linus, > On Thu, Dec 27, 2018 at 10:38:03AM +0100, Linus Walleij wrote: > > On Wed, Dec 26, 2018 at 2:54 PM Guido Günther <agx@sigxcpu.org> wrote: > > > > > Otherwise building fails with only PINCTRL_IMX_SCU selected: > > > > > > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': > > > pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' > > > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' > > > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': > > > pinctrl-scu.c:(.text+0x64): undefined reference to `imx_scu_call_rpc' > > > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x64): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > > > aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': > > > pinctrl-scu.c:(.text+0x104): undefined reference to `imx_scu_call_rpc' > > > aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x104): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > > > make: *** [Makefile:1038: vmlinux] Error 1 > > > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > > > Patch applied with Fabio's ACK. > > Thanks! Excuse my ignorance but which tree would I pull in for that? I > didn't see it on > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/ It's there now in the devel branch. I just didn't have time to push it out for testing yesterday. Yours, Linus Walleij
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig index f7d357910cff..d20ae4b7f996 100644 --- a/drivers/pinctrl/freescale/Kconfig +++ b/drivers/pinctrl/freescale/Kconfig @@ -7,6 +7,7 @@ config PINCTRL_IMX config PINCTRL_IMX_SCU bool + depends on IMX_SCU select PINCTRL_IMX config PINCTRL_IMX1_CORE
Otherwise building fails with only PINCTRL_IMX_SCU selected: aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': pinctrl-scu.c:(.text+0x64): undefined reference to `imx_scu_call_rpc' aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x64): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' aarch64-linux-gnu-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': pinctrl-scu.c:(.text+0x104): undefined reference to `imx_scu_call_rpc' aarch64-linux-gnu-ld: pinctrl-scu.c:(.text+0x104): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' make: *** [Makefile:1038: vmlinux] Error 1 Signed-off-by: Guido Günther <agx@sigxcpu.org> --- This is based on linux-next 2018-12-24. Changes since v1: * Use 'depends on' instead of 'select' as suggested by Dong Aisheng. drivers/pinctrl/freescale/Kconfig | 1 + 1 file changed, 1 insertion(+)