| Message ID | 20181224164755.286932-2-tmaimon77@gmail.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | iio: adc: npcm: add NPCm ADC driver | expand |
On Mon, Dec 24, 2018 at 06:47:54PM +0200, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM Analog-to-Digital Converter(ADC). > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > new file mode 100644 > index 000000000000..6f0843d837cc > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > @@ -0,0 +1,35 @@ > +Nuvoton NPCM Analog to Digital Converter (ADC) > + > +The NPCM ADC is a 10-bit converter for eight channel inputs. > + > +Required properties: > +- compatible : "nuvoton,npcm750-adc" for the NPCM7XX BMC. > +- reg : specifies physical base address and size of the registers. > +- interrupts : Contain the ADC interrupt with flags for falling edge. > + > +Optional properties: > +- clocks : phandle of ADC reference clock, in case the clock is not > + added the ADC will use the default ADC sample rate. > +- vref-supply : The regulator supply ADC reference voltage, in case the > + vref-supply is not added the ADC will use internal voltage > + reference. > + > +Required Node in the NPCM7xx BMC: > +An additional register is present in the NPCM7xx SOC which is > +assumed to be in the same device tree, with and marked as > +compatible with "nuvoton,npcm750-rst". > + > +Example: > + > +adc: adc@f000c000 { > + compatible = "nuvoton,npcm750-adc"; > + reg = <0xf000c000 0x8>; > + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk NPCM7XX_CLK_ADC>; > +}; > + > +rst: rst@f0801000 { Why is this node here? > + compatible = "nuvoton,npcm750-rst", "syscon", > + "simple-mfd"; > + reg = <0xf0801000 0x6C>; > +}; > -- > 2.14.1 >
On Mon, 24 Dec 2018 18:47:54 +0200 Tomer Maimon <tmaimon77@gmail.com> wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM Analog-to-Digital Converter(ADC). > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > new file mode 100644 > index 000000000000..6f0843d837cc > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > @@ -0,0 +1,35 @@ > +Nuvoton NPCM Analog to Digital Converter (ADC) > + > +The NPCM ADC is a 10-bit converter for eight channel inputs. > + > +Required properties: > +- compatible : "nuvoton,npcm750-adc" for the NPCM7XX BMC. > +- reg : specifies physical base address and size of the registers. Something a bit crazy with the indentation here! > +- interrupts : Contain the ADC interrupt with flags for falling edge. > + > +Optional properties: > +- clocks : phandle of ADC reference clock, in case the clock is not > + added the ADC will use the default ADC sample rate. > +- vref-supply : The regulator supply ADC reference voltage, in case the > + vref-supply is not added the ADC will use internal voltage > + reference. > + > +Required Node in the NPCM7xx BMC: > +An additional register is present in the NPCM7xx SOC which is > +assumed to be in the same device tree, with and marked as > +compatible with "nuvoton,npcm750-rst". > + > +Example: > + > +adc: adc@f000c000 { > + compatible = "nuvoton,npcm750-adc"; > + reg = <0xf000c000 0x8>; > + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk NPCM7XX_CLK_ADC>; > +}; > + > +rst: rst@f0801000 { > + compatible = "nuvoton,npcm750-rst", "syscon", > + "simple-mfd"; > + reg = <0xf0801000 0x6C>; > +};
Hi Rob, On Thu, 3 Jan 2019 at 23:14, Rob Herring <robh@kernel.org> wrote: > On Mon, Dec 24, 2018 at 06:47:54PM +0200, Tomer Maimon wrote: > > Added device tree binding documentation for Nuvoton BMC > > NPCM Analog-to-Digital Converter(ADC). > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 > ++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > > > > diff --git > a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > > new file mode 100644 > > index 000000000000..6f0843d837cc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt > > @@ -0,0 +1,35 @@ > > +Nuvoton NPCM Analog to Digital Converter (ADC) > > + > > +The NPCM ADC is a 10-bit converter for eight channel inputs. > > + > > +Required properties: > > +- compatible : "nuvoton,npcm750-adc" for the NPCM7XX BMC. > > +- reg : specifies physical base address and size > of the registers. > > +- interrupts : Contain the ADC interrupt with flags for falling edge. > > + > > +Optional properties: > > +- clocks : phandle of ADC reference clock, in case the > clock is not > > + added the ADC will use the default ADC > sample rate. > > +- vref-supply : The regulator supply ADC reference voltage, in > case the > > + vref-supply is not added the ADC will > use internal voltage > > + reference. > > + > > +Required Node in the NPCM7xx BMC: > > +An additional register is present in the NPCM7xx SOC which is > > +assumed to be in the same device tree, with and marked as > > +compatible with "nuvoton,npcm750-rst". > > + > > +Example: > > + > > +adc: adc@f000c000 { > > + compatible = "nuvoton,npcm750-adc"; > > + reg = <0xf000c000 0x8>; > > + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clk NPCM7XX_CLK_ADC>; > > +}; > > + > > +rst: rst@f0801000 { > > Why is this node here? > example for the reset node that required when using NPCM7xx SOC. (Required Node in the NPCM7xx BMC: An additional register is present in the NPCM7xx SOC which is assumed to be in the same device tree, with and marked as compatible with "nuvoton,npcm750-rst") > > > + compatible = "nuvoton,npcm750-rst", "syscon", > > + "simple-mfd"; > > + reg = <0xf0801000 0x6C>; > > +}; > > -- > > 2.14.1 > > > Thanks, Tomer <div dir="ltr"><div dir="ltr"></div>Hi Rob,<div><br></div><div><div class="gmail_quote"><div dir="ltr">On Thu, 3 Jan 2019 at 23:14, Rob Herring <<a href="mailto:robh@kernel.org">robh@kernel.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Dec 24, 2018 at 06:47:54PM +0200, Tomer Maimon wrote:<br> > Added device tree binding documentation for Nuvoton BMC<br> > NPCM Analog-to-Digital Converter(ADC).<br> > <br> > Signed-off-by: Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>><br> > ---<br> > .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 ++++++++++++++++++++++<br> > 1 file changed, 35 insertions(+)<br> > create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt<br> > <br> > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt<br> > new file mode 100644<br> > index 000000000000..6f0843d837cc<br> > --- /dev/null<br> > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt<br> > @@ -0,0 +1,35 @@<br> > +Nuvoton NPCM Analog to Digital Converter (ADC)<br> > +<br> > +The NPCM ADC is a 10-bit converter for eight channel inputs.<br> > +<br> > +Required properties:<br> > +- compatible : "nuvoton,npcm750-adc" for the NPCM7XX BMC.<br> > +- reg : specifies physical base address and size of the registers.<br> > +- interrupts : Contain the ADC interrupt with flags for falling edge.<br> > +<br> > +Optional properties:<br> > +- clocks : phandle of ADC reference clock, in case the clock is not<br> > + added the ADC will use the default ADC sample rate.<br> > +- vref-supply : The regulator supply ADC reference voltage, in case the<br> > + vref-supply is not added the ADC will use internal voltage<br> > + reference.<br> > +<br> > +Required Node in the NPCM7xx BMC:<br> > +An additional register is present in the NPCM7xx SOC which is<br> > +assumed to be in the same device tree, with and marked as<br> > +compatible with "nuvoton,npcm750-rst".<br> > +<br> > +Example:<br> > +<br> > +adc: adc@f000c000 {<br> > + compatible = "nuvoton,npcm750-adc";<br> > + reg = <0xf000c000 0x8>;<br> > + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;<br> > + clocks = <&clk NPCM7XX_CLK_ADC>;<br> > +};<br> > +<br> > +rst: rst@f0801000 {<br> <br> Why is this node here?<br></blockquote><div>example for the reset node that required when using NPCM7xx SOC.</div><div>(Required Node in the NPCM7xx BMC:</div>An additional register is present in the NPCM7xx SOC which is<br>assumed to be in the same device tree, with and marked as<br>compatible with "nuvoton,npcm750-rst")<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> > + compatible = "nuvoton,npcm750-rst", "syscon",<br> > + "simple-mfd";<br> > + reg = <0xf0801000 0x6C>;<br> > +};<br> > -- <br> > 2.14.1<br> > <br></blockquote><div><br></div><div>Thanks,</div><div><br></div><div>Tomer </div></div></div></div>
diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt new file mode 100644 index 000000000000..6f0843d837cc --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt @@ -0,0 +1,35 @@ +Nuvoton NPCM Analog to Digital Converter (ADC) + +The NPCM ADC is a 10-bit converter for eight channel inputs. + +Required properties: +- compatible : "nuvoton,npcm750-adc" for the NPCM7XX BMC. +- reg : specifies physical base address and size of the registers. +- interrupts : Contain the ADC interrupt with flags for falling edge. + +Optional properties: +- clocks : phandle of ADC reference clock, in case the clock is not + added the ADC will use the default ADC sample rate. +- vref-supply : The regulator supply ADC reference voltage, in case the + vref-supply is not added the ADC will use internal voltage + reference. + +Required Node in the NPCM7xx BMC: +An additional register is present in the NPCM7xx SOC which is +assumed to be in the same device tree, with and marked as +compatible with "nuvoton,npcm750-rst". + +Example: + +adc: adc@f000c000 { + compatible = "nuvoton,npcm750-adc"; + reg = <0xf000c000 0x8>; + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk NPCM7XX_CLK_ADC>; +}; + +rst: rst@f0801000 { + compatible = "nuvoton,npcm750-rst", "syscon", + "simple-mfd"; + reg = <0xf0801000 0x6C>; +};
Added device tree binding documentation for Nuvoton BMC NPCM Analog-to-Digital Converter(ADC). Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt