Patchwork Natty SRU (V3): UBUNTU: [Config] Add grub-efi as a recommended bootloader for server and generic

login
register
mail settings
Submitter Tim Gardner
Date June 23, 2011, 4:50 p.m.
Message ID <4E036ED7.10009@canonical.com>
Download mbox | patch
Permalink /patch/101655/
State New
Headers show

Comments

Tim Gardner - June 23, 2011, 4:50 p.m.
<cjwatson> tgardner: grub-efi should definitely never be first
<cjwatson> and "forces removal due to missing recommends" is nonsense
  an unsatisfied recommends should not force removing a package
  also, the real packages involved are grub-efi-amd64 and grub-efi-ia32 
- grub-efi is a metapackage
  good grief, that apt-get output is incredibly weird
<cjwatson> tgardner: in my book, that's an apt bug and you should give 
mvo a task for it - adding non-first grub-efi-amd64 | grub-efi-ia32 
Recommends won't hurt though
<tgardner> cjwatson, well, should I reference the meta package, or the 
underlying package (since they are somewhat arch dependent, right?)
<cjwatson> underlying
  it doesn't matter if you recommend something that's missing
  especially when it's one of several alternatives
<tgardner> cjwatson, ok, can do
<cjwatson> referring to the metapackage: consider the case where 
somebody has grub-efi-amd64 installed but not grub-efi
<tgardner> makes sense
<cjwatson> I still think it's not really your problem, but fixing apt's 
resolver in a stable release probably isn't happenng

rtg
Tim Gardner - June 23, 2011, 5:35 p.m.
On 06/23/2011 10:50 AM, Tim Gardner wrote:
>
> <cjwatson> tgardner: grub-efi should definitely never be first
> <cjwatson> and "forces removal due to missing recommends" is nonsense
> an unsatisfied recommends should not force removing a package
> also, the real packages involved are grub-efi-amd64 and grub-efi-ia32 -
> grub-efi is a metapackage
> good grief, that apt-get output is incredibly weird
> <cjwatson> tgardner: in my book, that's an apt bug and you should give
> mvo a task for it - adding non-first grub-efi-amd64 | grub-efi-ia32
> Recommends won't hurt though
> <tgardner> cjwatson, well, should I reference the meta package, or the
> underlying package (since they are somewhat arch dependent, right?)
> <cjwatson> underlying
> it doesn't matter if you recommend something that's missing
> especially when it's one of several alternatives
> <tgardner> cjwatson, ok, can do
> <cjwatson> referring to the metapackage: consider the case where
> somebody has grub-efi-amd64 installed but not grub-efi
> <tgardner> makes sense
> <cjwatson> I still think it's not really your problem, but fixing apt's
> resolver in a stable release probably isn't happenng
>
> rtg
>

The changes were simple enough that I went ahead and applied this patch 
assuming ACKs from Leann and Andy.

rtg

Patch

From 1d8aa2c6ff16ae938723b0aeb1292beb1af7c610 Mon Sep 17 00:00:00 2001
From: Tim Gardner <tim.gardner@canonical.com>
Date: Thu, 23 Jun 2011 08:55:53 -0600
Subject: [PATCH] UBUNTU: [Config] Add grub-efi as a recommended bootloader for server and generic

BugLink: http://bugs.launchpad.net/bugs/800910

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 debian.master/control.d/vars.generic |    2 +-
 debian.master/control.d/vars.server  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.master/control.d/vars.generic b/debian.master/control.d/vars.generic
index 200acfd..fd5220f 100644
--- a/debian.master/control.d/vars.generic
+++ b/debian.master/control.d/vars.generic
@@ -2,5 +2,5 @@  arch="i386 amd64"
 supported="Generic"
 target="Geared toward desktop systems."
 desc="x86/x86_64"
-bootloader="grub-pc | grub | lilo (>= 19.1)"
+bootloader="grub-pc | grub-efi-amd64 | grub-efi-ia32 | grub | lilo (>= 19.1)"
 provides="kvm-api-4, redhat-cluster-modules, ivtv-modules, ndiswrapper-modules-1.9"
diff --git a/debian.master/control.d/vars.server b/debian.master/control.d/vars.server
index 0f1e41c..b8a53a4 100644
--- a/debian.master/control.d/vars.server
+++ b/debian.master/control.d/vars.server
@@ -2,5 +2,5 @@  arch="amd64"
 supported="Server"
 target="Geared toward 64 bit server systems."
 desc="x86_64"
-bootloader="grub-pc | grub | lilo (>= 19.1)"
+bootloader="grub-pc | grub-efi-amd64 | grub | lilo (>= 19.1)"
 provides="redhat-cluster-modules, kvm-api-4, ivtv-modules, ndiswrapper-modules-1.9"
-- 
1.7.0.4