Patchwork [PATCHv2,1/2] target-arm: make VMSAv7 remapping and AP dependent on V6K

login
register
mail settings
Submitter Jamie Iles
Date June 23, 2011, 11:12 a.m.
Message ID <1308827580-5040-1-git-send-email-jamie@jamieiles.com>
Download mbox | patch
Permalink /patch/101614/
State New
Headers show

Comments

Jamie Iles - June 23, 2011, 11:12 a.m.
The VMSAv7 remapping and access permissions were introduced in ARMv6K
and not ARMv7.

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paul Brook <paul@codesourcery.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 target-arm/helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Maydell - July 6, 2011, 10:39 a.m.
On 23 June 2011 12:12, Jamie Iles <jamie@jamieiles.com> wrote:
> The VMSAv7 remapping and access permissions were introduced in ARMv6K
> and not ARMv7.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Paul Brook <paul@codesourcery.com>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Patch

diff --git a/target-arm/helper.c b/target-arm/helper.c
index 1208416..eda881b 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -945,7 +945,7 @@  static inline int check_ap(CPUState *env, int ap, int domain, int access_type,
   case 6:
       return prot_ro;
   case 7:
-      if (!arm_feature (env, ARM_FEATURE_V7))
+      if (!arm_feature (env, ARM_FEATURE_V6K))
           return 0;
       return prot_ro;
   default: