[ovs-dev] netdev-linux: Fix function argument order in sfq_tc_load().

Message ID 20181219153126.19770-1-blp@ovn.org
State Accepted
Headers show
Series
  • [ovs-dev] netdev-linux: Fix function argument order in sfq_tc_load().
Related show

Commit Message

Ben Pfaff Dec. 19, 2018, 3:31 p.m.
sfq_install__() takes quantum before perturb.

Reported-by: shaoke xi <xishaoke.xsk@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 lib/netdev-linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Justin Pettit Jan. 17, 2019, 9:48 p.m. | #1
> On Dec 19, 2018, at 7:31 AM, Ben Pfaff <blp@ovn.org> wrote:
> 
> sfq_install__() takes quantum before perturb.
> 
> Reported-by: shaoke xi <xishaoke.xsk@gmail.com>
> Signed-off-by: Ben Pfaff <blp@ovn.org>

Acked-by: Justin Pettit <jpettti@ovn.org>
Ben Pfaff Jan. 18, 2019, 12:34 a.m. | #2
On Thu, Jan 17, 2019 at 01:48:32PM -0800, Justin Pettit wrote:
> 
> > On Dec 19, 2018, at 7:31 AM, Ben Pfaff <blp@ovn.org> wrote:
> > 
> > sfq_install__() takes quantum before perturb.
> > 
> > Reported-by: shaoke xi <xishaoke.xsk@gmail.com>
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> 
> Acked-by: Justin Pettit <jpettti@ovn.org>

Thanks, applied to master and backported.

Patch

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index f86dcd06e563..25d037cb643f 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -3798,7 +3798,7 @@  sfq_tc_load(struct netdev *netdev, struct ofpbuf *nlmsg)
     error = tc_parse_qdisc(nlmsg, &kind, &nlattr);
     if (error == 0) {
         sfq = nl_attr_get(nlattr);
-        sfq_install__(netdev, sfq->perturb_period, sfq->quantum);
+        sfq_install__(netdev, sfq->quantum, sfq->perturb_period);
         return 0;
     }