Patchwork [google] fix kernel fdo booting issue (issue4627057)

login
register
mail settings
Submitter Rong Xu
Date June 23, 2011, 6:22 a.m.
Message ID <20110623062248.F1A9BC2979@rong.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/101587/
State New
Headers show

Comments

Rong Xu - June 23, 2011, 6:22 a.m.
This change removes the define of TARGET_VTABLE_USES_DESCRIPTORS in 
kernel fdo which causes kernel panic in indirect-call-profiling.

Tested with 2.6.34 kernel. This change only affects kernel code.

This is for google_main only.

-Rong

2011-06-22   Rong Xu  <xur@google.com>

	* gcc/libgcov.c: (TARGET_VTABLE_USES_DESCRIPTORS): Remove.


--
This patch is available for review at http://codereview.appspot.com/4627057
Sharad Singhai - June 23, 2011, 6:36 a.m.
Okay for google/main.

Sharad

On Wed, Jun 22, 2011 at 11:22 PM, Rong Xu <xur@google.com> wrote:
>
> This change removes the define of TARGET_VTABLE_USES_DESCRIPTORS in
> kernel fdo which causes kernel panic in indirect-call-profiling.
>
> Tested with 2.6.34 kernel. This change only affects kernel code.
>
> This is for google_main only.
>
> -Rong
>
> 2011-06-22   Rong Xu  <xur@google.com>
>
>        * gcc/libgcov.c: (TARGET_VTABLE_USES_DESCRIPTORS): Remove.
>
> Index: gcc/libgcov.c
> ===================================================================
> --- gcc/libgcov.c       (revision 175328)
> +++ gcc/libgcov.c       (working copy)
> @@ -36,7 +36,6 @@
>  # define L_gcov_average_profiler
>  # define L_gcov_ior_profiler
>
> -# define TARGET_VTABLE_USES_DESCRIPTORS 0
>  # define HAVE_CC_TLS 0
>  # define __GCOV_KERNEL__
>
>
> --
> This patch is available for review at http://codereview.appspot.com/4627057

Patch

Index: gcc/libgcov.c
===================================================================
--- gcc/libgcov.c	(revision 175328)
+++ gcc/libgcov.c	(working copy)
@@ -36,7 +36,6 @@ 
 # define L_gcov_average_profiler
 # define L_gcov_ior_profiler
 
-# define TARGET_VTABLE_USES_DESCRIPTORS 0
 # define HAVE_CC_TLS 0
 # define __GCOV_KERNEL__