Message ID | 20181218041625.24969-1-mst@redhat.com |
---|---|
State | New |
Headers | show |
On Mon, Dec 17, 2018 at 11:16:42PM -0500, Michael S. Tsirkin wrote: > The following changes since commit f163448536e5f7ae8905b14547eab37a41a75f6c: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20181216' into staging (2018-12-17 13:04:25 +0000) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 562774d542e9be84411de0233308da380256f631: > > hw/i386: Remove deprecated machines pc-0.10 and pc-0.11 (2018-12-17 22:45:59 -0500) oops issue found. Pls ignore. Will resend tomorrow. > ---------------------------------------------------------------- > pci, pc, virtio: fixes, features > > VTD fixes > ACPI refactoring > new names for virtio devices > multiple pcie link width/speeds > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > ---------------------------------------------------------------- > Alex Williamson (8): > pcie: Create enums for link speed and width > pci: Sync PCIe downstream port LNKSTA on read > qapi: Define PCIe link speed and width properties > pcie: Add link speed and width fields to PCIESlot > pcie: Fill PCIESlot link fields to support higher speeds and widths > pcie: Allow generic PCIe root port to specify link speed and width > vfio/pci: Remove PCIe Link Status emulation > pcie: Fast PCIe root ports for new machines > > Corey Minyard (1): > pc:piix4: Update smbus I/O space after a migration > > Eduardo Habkost (2): > virtio: Helper for registering virtio device types > virtio: Provide version-specific variants of virtio PCI devices > > Igor Mammedov (2): > hw: arm: acpi: Fix incorrect checksums in RSDP > hw: i386: Use correct RSDT length for checksum > > Matthias Weckbecker (1): > hw/pci-bridge: Fix invalid free() > > Peter Xu (5): > intel_iommu: dump correct iova when failed > intel_iommu: convert invalid traces into error reports > intel_iommu: dma read/write draining support > intel_iommu: remove "x-" prefix for "aw-bits" > intel_iommu: turn on IR by default > > Philippe Mathieu-Daudé (4): > tests: Remove unused include > hw/smbios: Restrict access to "hw/smbios/ipmi.h" > hw/smbios: Remove "smbios_ipmi.h" > hw/smbios: Move to the hw/firmware/ subdirectory > > Samuel Ortiz (6): > hw: acpi: The RSDP build API can return void > hw: arm: Carry RSDP specific data through AcpiRsdpData > hw: arm: Convert the RSDP build to the buid_append_foo() API > hw: arm: Support both legacy and current RSDP build > hw: acpi: Export and share the ARM RSDP build > hw: acpi: Remove AcpiRsdpDescriptor and fix tests > > Thomas Huth (1): > hw/i386: Remove deprecated machines pc-0.10 and pc-0.11 > > Zheng Xiang (1): > pcie: set link state inactive/active after hot unplug/plug > > qapi/common.json | 42 +++++ > hw/i386/intel_iommu_internal.h | 3 + > hw/smbios/smbios_build.h | 4 + > hw/virtio/virtio-pci.h | 78 +++++++-- > include/hw/acpi/acpi-defs.h | 19 +-- > include/hw/acpi/aml-build.h | 2 + > include/hw/compat.h | 10 +- > include/hw/{smbios => firmware}/smbios.h | 0 > include/hw/i386/intel_iommu.h | 1 + > include/hw/i386/pc.h | 9 + > include/hw/pci/pci.h | 13 ++ > include/hw/pci/pcie.h | 1 + > include/hw/pci/pcie_port.h | 4 + > include/hw/pci/pcie_regs.h | 23 ++- > include/hw/qdev-properties.h | 8 + > include/hw/smbios/ipmi.h | 15 -- > tests/acpi-utils.h | 4 +- > hw/acpi/aml-build.c | 68 ++++++++ > hw/acpi/piix4.c | 1 + > hw/arm/virt-acpi-build.c | 40 +---- > hw/arm/virt.c | 2 +- > hw/core/qdev-properties.c | 176 ++++++++++++++++++++ > hw/display/virtio-gpu-pci.c | 7 +- > hw/display/virtio-vga.c | 7 +- > hw/i386/acpi-build.c | 46 +++--- > hw/i386/intel_iommu.c | 66 ++++++-- > hw/i386/pc.c | 2 +- > hw/i386/pc_piix.c | 72 +------- > hw/i386/pc_q35.c | 2 +- > hw/i386/x86-iommu.c | 2 +- > hw/pci-bridge/gen_pcie_root_port.c | 4 + > hw/pci-bridge/pcie_root_port.c | 14 ++ > hw/pci/pci.c | 4 + > hw/pci/pci_bridge.c | 2 +- > hw/pci/pcie.c | 132 ++++++++++++++- > hw/smbios/smbios-stub.c | 2 +- > hw/smbios/smbios.c | 3 +- > hw/smbios/smbios_type_38-stub.c | 2 +- > hw/smbios/smbios_type_38.c | 3 +- > hw/vfio/pci.c | 9 +- > hw/virtio/virtio-crypto-pci.c | 7 +- > hw/virtio/virtio-pci.c | 271 +++++++++++++++++++++++-------- > tests/acpi-utils.c | 47 +++++- > tests/bios-tables-test.c | 24 ++- > tests/cpu-plug-test.c | 4 +- > tests/vmgenid-test.c | 8 +- > vl.c | 2 +- > MAINTAINERS | 2 +- > hw/i386/trace-events | 6 - > qemu-deprecated.texi | 2 +- > tests/acceptance/virtio_version.py | 176 ++++++++++++++++++++ > 51 files changed, 1133 insertions(+), 318 deletions(-) > rename include/hw/{smbios => firmware}/smbios.h (100%) > delete mode 100644 include/hw/smbios/ipmi.h > create mode 100644 tests/acceptance/virtio_version.py >
Patchew URL: https://patchew.org/QEMU/20181218041625.24969-1-mst@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181218041625.24969-1-mst@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/31] pci, pc, virtio: fixes, features === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' a229850 hw/i386: Remove deprecated machines pc-0.10 and pc-0.11 37f4ed6 hw: acpi: Remove AcpiRsdpDescriptor and fix tests e3d6549 hw: acpi: Export and share the ARM RSDP build 823b080 hw: arm: Support both legacy and current RSDP build ab2b3d8 hw: arm: Convert the RSDP build to the buid_append_foo() API 476ed63 hw: arm: Carry RSDP specific data through AcpiRsdpData 4f784c9 hw: i386: Use correct RSDT length for checksum 922164f hw: arm: acpi: Fix incorrect checksums in RSDP 7374154 hw: acpi: The RSDP build API can return void a542551 intel_iommu: turn on IR by default fbd376b intel_iommu: remove "x-" prefix for "aw-bits" dace78d intel_iommu: dma read/write draining support 31b4a13 intel_iommu: convert invalid traces into error reports d0ce98f intel_iommu: dump correct iova when failed 95aba03 pcie: Fast PCIe root ports for new machines 34233bd vfio/pci: Remove PCIe Link Status emulation 9734ad2 pcie: Allow generic PCIe root port to specify link speed and width b1c2b3a pcie: Fill PCIESlot link fields to support higher speeds and widths a0460df pcie: Add link speed and width fields to PCIESlot 33b6bc1 qapi: Define PCIe link speed and width properties 34b1004 pci: Sync PCIe downstream port LNKSTA on read 2f586c6 pcie: Create enums for link speed and width 50ec3b0 hw/pci-bridge: Fix invalid free() 725b6b8 hw/smbios: Move to the hw/firmware/ subdirectory 1ad07f1 hw/smbios: Remove "smbios_ipmi.h" 2c78a7e hw/smbios: Restrict access to "hw/smbios/ipmi.h" 4cb7e85 tests: Remove unused include 6d1ed7c virtio: Provide version-specific variants of virtio PCI devices 3ba33b5 virtio: Helper for registering virtio device types 4729a75 pc:piix4: Update smbus I/O space after a migration a060a84 pcie: set link state inactive/active after hot unplug/plug === OUTPUT BEGIN === Checking PATCH 1/31: pcie: set link state inactive/active after hot unplug/plug... Checking PATCH 2/31: pc:piix4: Update smbus I/O space after a migration... Checking PATCH 3/31: virtio: Helper for registering virtio device types... WARNING: line over 80 characters #498: FILE: hw/virtio/virtio-pci.h:443: + * Implements both INTERFACE_PCIE_DEVICE and INTERFACE_CONVENTIONAL_PCI_DEVICE, WARNING: line over 80 characters #507: FILE: hw/virtio/virtio-pci.h:452: + * Implements both INTERFACE_PCIE_DEVICE and INTERFACE_CONVENTIONAL_PCI_DEVICE. total: 0 errors, 2 warnings, 469 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/31: virtio: Provide version-specific variants of virtio PCI devices... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #318: new file mode 100644 ERROR: line over 90 characters #374: FILE: tests/acceptance/virtio_version.py:52: + return devtype in [d['name'] for d in vm.command('qom-list-types', implements=implements)] WARNING: line over 80 characters #429: FILE: tests/acceptance/virtio_version.py:107: + dev_1_0, nt_ifaces = self.run_device('%s-non-transitional' % (qemu_devtype)) WARNING: line over 80 characters #453: FILE: tests/acceptance/virtio_version.py:131: + dev_trans, trans_ifaces = self.run_device('%s-transitional' % (qemu_devtype)) total: 1 errors, 3 warnings, 404 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/31: tests: Remove unused include... Checking PATCH 6/31: hw/smbios: Restrict access to "hw/smbios/ipmi.h"... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: rename from include/hw/smbios/ipmi.h total: 0 errors, 1 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/31: hw/smbios: Remove "smbios_ipmi.h"... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: deleted file mode 100644 total: 0 errors, 1 warnings, 36 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 8/31: hw/smbios: Move to the hw/firmware/ subdirectory... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #124: rename from include/hw/smbios/smbios.h total: 0 errors, 1 warnings, 80 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/31: hw/pci-bridge: Fix invalid free()... Checking PATCH 10/31: pcie: Create enums for link speed and width... Checking PATCH 11/31: pci: Sync PCIe downstream port LNKSTA on read... Checking PATCH 12/31: qapi: Define PCIe link speed and width properties... Checking PATCH 13/31: pcie: Add link speed and width fields to PCIESlot... Checking PATCH 14/31: pcie: Fill PCIESlot link fields to support higher speeds and widths... Checking PATCH 15/31: pcie: Allow generic PCIe root port to specify link speed and width... Checking PATCH 16/31: vfio/pci: Remove PCIe Link Status emulation... Checking PATCH 17/31: pcie: Fast PCIe root ports for new machines... Checking PATCH 18/31: intel_iommu: dump correct iova when failed... Checking PATCH 19/31: intel_iommu: convert invalid traces into error reports... Checking PATCH 20/31: intel_iommu: dma read/write draining support... Checking PATCH 21/31: intel_iommu: remove "x-" prefix for "aw-bits"... Checking PATCH 22/31: intel_iommu: turn on IR by default... Checking PATCH 23/31: hw: acpi: The RSDP build API can return void... Checking PATCH 24/31: hw: arm: acpi: Fix incorrect checksums in RSDP... WARNING: Block comments use a leading /* on a separate line #42: FILE: hw/arm/virt-acpi-build.c:393: + (char *)rsdp - rsdp_table->data, 20 /* ACPI rev 1.0 RSDP size */, WARNING: Block comments use a leading /* on a separate line #47: FILE: hw/arm/virt-acpi-build.c:398: + (char *)rsdp - rsdp_table->data, 36 /* ACPI rev 2.0 RSDP size */, total: 0 errors, 2 warnings, 14 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 25/31: hw: i386: Use correct RSDT length for checksum... WARNING: Block comments use a leading /* on a separate line #36: FILE: hw/i386/acpi-build.c:2553: + /* AcpiRsdpDescriptor describes revision 2 RSDP table and as result we WARNING: Block comments use a leading /* on a separate line #49: FILE: hw/i386/acpi-build.c:2575: + (char *)rsdp - rsdp_table->data, 20 /* ACPI rev 1.0 RSDP size */, total: 0 errors, 2 warnings, 19 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 26/31: hw: arm: Carry RSDP specific data through AcpiRsdpData... Checking PATCH 27/31: hw: arm: Convert the RSDP build to the buid_append_foo() API... Checking PATCH 28/31: hw: arm: Support both legacy and current RSDP build... Checking PATCH 29/31: hw: acpi: Export and share the ARM RSDP build... WARNING: Block comments use a leading /* on a separate line #49: FILE: hw/acpi/aml-build.c:1616: + true /* fseg memory */); WARNING: Block comments use a leading /* on a separate line #226: FILE: hw/i386/acpi-build.c:2715: + /* We used to allocate some extra space for RSDP revision 2 but total: 0 errors, 2 warnings, 214 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 30/31: hw: acpi: Remove AcpiRsdpDescriptor and fix tests... WARNING: Block comments use a leading /* on a separate line #61: FILE: tests/acpi-utils.c:58: + memcpy(&rsdt_physical_address, &rsdp_table[16 /* RsdtAddress offset */], 4); WARNING: Block comments use a leading /* on a separate line #68: FILE: tests/acpi-utils.c:65: + uint8_t revision = rsdp_table[15 /* Revision offset */]; WARNING: Block comments use a leading /* on a separate line #73: FILE: tests/acpi-utils.c:70: + memcpy(&xsdt_physical_address, &rsdp_table[24 /* XsdtAddress offset */], 8); WARNING: Block comments use a leading /* on a separate line #83: FILE: tests/acpi-utils.c:80: + revision = rsdp_table[15 /* Revision offset */]; WARNING: Block comments use a leading /* on a separate line #121: FILE: tests/bios-tables-test.c:30: + uint8_t rsdp_table[36 /* ACPI 2.0+ RSDP size */]; WARNING: Block comments use a leading /* on a separate line #134: FILE: tests/bios-tables-test.c:92: + revision = rsdp_table[15 /* Revision offset */]; WARNING: Block comments use a leading /* on a separate line #170: FILE: tests/vmgenid-test.c:38: + uint8_t rsdp_table[36 /* ACPI 2.0+ RSDP size */]; total: 0 errors, 7 warnings, 144 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 31/31: hw/i386: Remove deprecated machines pc-0.10 and pc-0.11... === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20181218041625.24969-1-mst@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
The following changes since commit f163448536e5f7ae8905b14547eab37a41a75f6c: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20181216' into staging (2018-12-17 13:04:25 +0000) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 562774d542e9be84411de0233308da380256f631: hw/i386: Remove deprecated machines pc-0.10 and pc-0.11 (2018-12-17 22:45:59 -0500) ---------------------------------------------------------------- pci, pc, virtio: fixes, features VTD fixes ACPI refactoring new names for virtio devices multiple pcie link width/speeds Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Alex Williamson (8): pcie: Create enums for link speed and width pci: Sync PCIe downstream port LNKSTA on read qapi: Define PCIe link speed and width properties pcie: Add link speed and width fields to PCIESlot pcie: Fill PCIESlot link fields to support higher speeds and widths pcie: Allow generic PCIe root port to specify link speed and width vfio/pci: Remove PCIe Link Status emulation pcie: Fast PCIe root ports for new machines Corey Minyard (1): pc:piix4: Update smbus I/O space after a migration Eduardo Habkost (2): virtio: Helper for registering virtio device types virtio: Provide version-specific variants of virtio PCI devices Igor Mammedov (2): hw: arm: acpi: Fix incorrect checksums in RSDP hw: i386: Use correct RSDT length for checksum Matthias Weckbecker (1): hw/pci-bridge: Fix invalid free() Peter Xu (5): intel_iommu: dump correct iova when failed intel_iommu: convert invalid traces into error reports intel_iommu: dma read/write draining support intel_iommu: remove "x-" prefix for "aw-bits" intel_iommu: turn on IR by default Philippe Mathieu-Daudé (4): tests: Remove unused include hw/smbios: Restrict access to "hw/smbios/ipmi.h" hw/smbios: Remove "smbios_ipmi.h" hw/smbios: Move to the hw/firmware/ subdirectory Samuel Ortiz (6): hw: acpi: The RSDP build API can return void hw: arm: Carry RSDP specific data through AcpiRsdpData hw: arm: Convert the RSDP build to the buid_append_foo() API hw: arm: Support both legacy and current RSDP build hw: acpi: Export and share the ARM RSDP build hw: acpi: Remove AcpiRsdpDescriptor and fix tests Thomas Huth (1): hw/i386: Remove deprecated machines pc-0.10 and pc-0.11 Zheng Xiang (1): pcie: set link state inactive/active after hot unplug/plug qapi/common.json | 42 +++++ hw/i386/intel_iommu_internal.h | 3 + hw/smbios/smbios_build.h | 4 + hw/virtio/virtio-pci.h | 78 +++++++-- include/hw/acpi/acpi-defs.h | 19 +-- include/hw/acpi/aml-build.h | 2 + include/hw/compat.h | 10 +- include/hw/{smbios => firmware}/smbios.h | 0 include/hw/i386/intel_iommu.h | 1 + include/hw/i386/pc.h | 9 + include/hw/pci/pci.h | 13 ++ include/hw/pci/pcie.h | 1 + include/hw/pci/pcie_port.h | 4 + include/hw/pci/pcie_regs.h | 23 ++- include/hw/qdev-properties.h | 8 + include/hw/smbios/ipmi.h | 15 -- tests/acpi-utils.h | 4 +- hw/acpi/aml-build.c | 68 ++++++++ hw/acpi/piix4.c | 1 + hw/arm/virt-acpi-build.c | 40 +---- hw/arm/virt.c | 2 +- hw/core/qdev-properties.c | 176 ++++++++++++++++++++ hw/display/virtio-gpu-pci.c | 7 +- hw/display/virtio-vga.c | 7 +- hw/i386/acpi-build.c | 46 +++--- hw/i386/intel_iommu.c | 66 ++++++-- hw/i386/pc.c | 2 +- hw/i386/pc_piix.c | 72 +------- hw/i386/pc_q35.c | 2 +- hw/i386/x86-iommu.c | 2 +- hw/pci-bridge/gen_pcie_root_port.c | 4 + hw/pci-bridge/pcie_root_port.c | 14 ++ hw/pci/pci.c | 4 + hw/pci/pci_bridge.c | 2 +- hw/pci/pcie.c | 132 ++++++++++++++- hw/smbios/smbios-stub.c | 2 +- hw/smbios/smbios.c | 3 +- hw/smbios/smbios_type_38-stub.c | 2 +- hw/smbios/smbios_type_38.c | 3 +- hw/vfio/pci.c | 9 +- hw/virtio/virtio-crypto-pci.c | 7 +- hw/virtio/virtio-pci.c | 271 +++++++++++++++++++++++-------- tests/acpi-utils.c | 47 +++++- tests/bios-tables-test.c | 24 ++- tests/cpu-plug-test.c | 4 +- tests/vmgenid-test.c | 8 +- vl.c | 2 +- MAINTAINERS | 2 +- hw/i386/trace-events | 6 - qemu-deprecated.texi | 2 +- tests/acceptance/virtio_version.py | 176 ++++++++++++++++++++ 51 files changed, 1133 insertions(+), 318 deletions(-) rename include/hw/{smbios => firmware}/smbios.h (100%) delete mode 100644 include/hw/smbios/ipmi.h create mode 100644 tests/acceptance/virtio_version.py