[v2,4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

Message ID 20181217200405.2904551-4-vijaykhemka@fb.com
State Not Applicable, archived
Headers show
Series
  • [v2,1/4] ARM: dts: aspeed: Add sensors devices for Facebook
Related show

Commit Message

Vijay Khemka Dec. 17, 2018, 8:04 p.m.
Added lpc ctrl device to enable LPC clock in Facebook
Tiogapass device tree.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
 .../boot/dts/aspeed-bmc-facebook-tiogapass.dts  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Vijay Khemka Dec. 20, 2018, 6:05 p.m. | #1
Joel, Can you please take care of these patches merge.

On 12/17/18, 12:04 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:

    Added lpc ctrl device to enable LPC clock in Facebook
    Tiogapass device tree.
    
    Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    ---
     .../boot/dts/aspeed-bmc-facebook-tiogapass.dts  | 17 +++++++++++++++++
     1 file changed, 17 insertions(+)
    
    diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    index 73e58a821613..ef7875b54562 100644
    --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    @@ -22,6 +22,17 @@
     		reg = <0x80000000 0x20000000>;
     	};
     
    +	reserved-memory {
    +		#address-cells = <1>;
    +		#size-cells = <1>;
    +		ranges;
    +
    +		flash_memory: region@98000000 {
    +			no-map;
    +			reg = <0x98000000 0x00001000>; /* 4K */
    +		};
    +	};
    +
     	iio-hwmon {
     		compatible = "iio-hwmon";
     		io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
    @@ -54,6 +65,12 @@
     	};
     };
     
    +&lpc_ctrl {
    +	status = "okay";
    +	memory-region = <&flash_memory>;
    +	flash = <&spi1>;
    +};
    +
     &uart1 {
     	// Host Console
     	status = "okay";
    -- 
    2.17.1
Joel Stanley Jan. 17, 2019, 2:48 a.m. | #2
On Fri, 21 Dec 2018 at 05:06, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> On 12/17/18, 12:04 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:
>
>     Added lpc ctrl device to enable LPC clock in Facebook
>     Tiogapass device tree.
>
>     Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
>
> Joel, Can you please take care of these patches merge.

I did not apply this one as I think the description will change once
we've merged your aspeed-lpc-ctrl patch.

Cheers,

Joel
Vijay Khemka Jan. 17, 2019, 6:53 p.m. | #3
On 1/16/19, 6:49 PM, "Joel Stanley" <joel@jms.id.au> wrote:

    On Fri, 21 Dec 2018 at 05:06, Vijay Khemka <vijaykhemka@fb.com> wrote:
    >
    > On 12/17/18, 12:04 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:
    >
    >     Added lpc ctrl device to enable LPC clock in Facebook
    >     Tiogapass device tree.
    >
    >     Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    >
    > Joel, Can you please take care of these patches merge.
    
    I did not apply this one as I think the description will change once
    we've merged your aspeed-lpc-ctrl patch.

Yes I will update and send new one.
    
    Cheers,
    
    Joel

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
index 73e58a821613..ef7875b54562 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
@@ -22,6 +22,17 @@ 
 		reg = <0x80000000 0x20000000>;
 	};
 
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		flash_memory: region@98000000 {
+			no-map;
+			reg = <0x98000000 0x00001000>; /* 4K */
+		};
+	};
+
 	iio-hwmon {
 		compatible = "iio-hwmon";
 		io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
@@ -54,6 +65,12 @@ 
 	};
 };
 
+&lpc_ctrl {
+	status = "okay";
+	memory-region = <&flash_memory>;
+	flash = <&spi1>;
+};
+
 &uart1 {
 	// Host Console
 	status = "okay";