Patchwork [libgcc] : Prototype __enable_execute_stack

login
register
mail settings
Submitter Uros Bizjak
Date June 22, 2011, 8:17 a.m.
Message ID <BANLkTikLAvA32HbxLPLosReOUiND4Ap+cA@mail.gmail.com>
Download mbox | patch
Permalink /patch/101406/
State New
Headers show

Comments

Uros Bizjak - June 22, 2011, 8:17 a.m.
Hello!

This patch avoids a bunch of:

enable-execute-stack.c:5:1: warning: no previous prototype for
‘__enable_execute_stack’ [-Wmissing-prototypes]

warnings during gcc bootstrap.

2011-06-22  Uros Bizjak  <ubizjak@gmail.com>

	* enable-execute-stack-empty.c (__enable_execute_stack): Add prototype.

Bootstrapped on x86_64-pc-linux-gnu.

OK for mainline/4.6?

Uros.
Rainer Orth - June 22, 2011, 8:23 a.m.
Hi Uros,

> This patch avoids a bunch of:
>
> enable-execute-stack.c:5:1: warning: no previous prototype for
> ‘__enable_execute_stack’ [-Wmissing-prototypes]
>
> warnings during gcc bootstrap.

I'd say this is obvious.

> 2011-06-22  Uros Bizjak  <ubizjak@gmail.com>
>
> 	* enable-execute-stack-empty.c (__enable_execute_stack): Add prototype.
>
> Bootstrapped on x86_64-pc-linux-gnu.
>
> OK for mainline/4.6?

This code only lives on mainline, not 4.6.

	Rainer
Uros Bizjak - June 22, 2011, 11:20 a.m.
On Wed, Jun 22, 2011 at 10:23 AM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:

>> This patch avoids a bunch of:
>>
>> enable-execute-stack.c:5:1: warning: no previous prototype for
>> ‘__enable_execute_stack’ [-Wmissing-prototypes]
>>
>> warnings during gcc bootstrap.
>
> I'd say this is obvious.

Agreed.  Committed to mainline SVN.

Uros.

Patch

Index: enable-execute-stack-empty.c
===================================================================
--- enable-execute-stack-empty.c	(revision 175285)
+++ enable-execute-stack-empty.c	(working copy)
@@ -1,6 +1,9 @@ 
 /* Dummy implementation of __enable_execute_stack.  */

+extern void __enable_execute_stack (void *);
+
 /* Attempt to turn on execute permission for the stack.  */
+
 void
 __enable_execute_stack (void *addr __attribute__((__unused__)))
 {