| Message ID | 20181216083417.19100-1-boris.brezillon@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd: rawnand: sunxi: Write pageprog related opcodes to WCMD_SET | expand |
Hi Boris, Boris Brezillon <boris.brezillon@bootlin.com> wrote on Sun, 16 Dec 2018 09:34:17 +0100: > The opcodes used by the controller when doing batched page prog should > be written in NFC_REG_WCMD_SET not FC_REG_RCMD_SET. Luckily, the > default NFC_REG_WCMD_SET value matches the one we set in the driver > which explains why we didn't notice the problem. > > Fixes: 614049a8d904 ("mtd: nand: sunxi: add support for DMA assisted operations") > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > --- > drivers/mtd/nand/raw/sunxi_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c > index a5c83cbe4897..e828ee50a201 100644 > --- a/drivers/mtd/nand/raw/sunxi_nand.c > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > @@ -1393,7 +1393,7 @@ static int sunxi_nfc_hw_ecc_write_page_dma(struct nand_chip *chip, > sunxi_nfc_randomizer_enable(mtd); > > writel((NAND_CMD_RNDIN << 8) | NAND_CMD_PAGEPROG, > - nfc->regs + NFC_REG_RCMD_SET); > + nfc->regs + NFC_REG_WCMD_SET); > > dma_async_issue_pending(nfc->dmac); > Applied to nand/next. Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c index a5c83cbe4897..e828ee50a201 100644 --- a/drivers/mtd/nand/raw/sunxi_nand.c +++ b/drivers/mtd/nand/raw/sunxi_nand.c @@ -1393,7 +1393,7 @@ static int sunxi_nfc_hw_ecc_write_page_dma(struct nand_chip *chip, sunxi_nfc_randomizer_enable(mtd); writel((NAND_CMD_RNDIN << 8) | NAND_CMD_PAGEPROG, - nfc->regs + NFC_REG_RCMD_SET); + nfc->regs + NFC_REG_WCMD_SET); dma_async_issue_pending(nfc->dmac);
The opcodes used by the controller when doing batched page prog should be written in NFC_REG_WCMD_SET not FC_REG_RCMD_SET. Luckily, the default NFC_REG_WCMD_SET value matches the one we set in the driver which explains why we didn't notice the problem. Fixes: 614049a8d904 ("mtd: nand: sunxi: add support for DMA assisted operations") Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- drivers/mtd/nand/raw/sunxi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)