Patchwork [testsuite] ARM: require arm_thumb2_ok, drop -march

login
register
mail settings
Submitter Janis Johnson
Date June 21, 2011, 9:06 p.m.
Message ID <4E0107D3.1020502@codesourcery.com>
Download mbox | patch
Permalink /patch/101371/
State New
Headers show

Comments

Janis Johnson - June 21, 2011, 9:06 p.m.
Modify three tests that require thumb2 support to check for that rather
than specifying an arch value that might be overridden by multilib flags.

OK for trunk, and later for 4.6?
2011-06-21  Janis Johnson  <janisjo@codesourcery.com>
	
	* gcc.target/arm/ctz.c: Don't specify -march, require thumb2.
	* gcc.target/arm/pr42879.c: Likewise.
	* gcc.target/arm/pr45701-3.c: Likewise.
Ramana Radhakrishnan - June 21, 2011, 9:40 p.m.
On 21 June 2011 22:06, Janis Johnson <janisjo@codesourcery.com> wrote:
> Modify three tests that require thumb2 support to check for that rather
> than specifying an arch value that might be overridden by multilib flags.
>
> OK for trunk, and later for 4.6?

OK - this is a nice cleanup.

Ramana
>

Patch

Index: gcc.target/arm/ctz.c
===================================================================
--- gcc.target/arm/ctz.c	(revision 175269)
+++ gcc.target/arm/ctz.c	(working copy)
@@ -1,6 +1,6 @@ 
 /* { dg-do compile } */
-/* { dg-require-effective-target arm32 } */
-/* { dg-options "-O2 -march=armv6t2" } */
+/* { dg-require-effective-target arm_thumb2_ok } */
+/* { dg-options "-O2" } */
 
 unsigned int functest(unsigned int x)
 {
Index: gcc.target/arm/pr42879.c
===================================================================
--- gcc.target/arm/pr42879.c	(revision 175269)
+++ gcc.target/arm/pr42879.c	(working copy)
@@ -1,4 +1,5 @@ 
-/* { dg-options "-march=armv7-a -mthumb -Os" }  */
+/* { dg-require-effective-target arm_thumb2_ok } */
+/* { dg-options "-mthumb -Os" }  */
 /* { dg-final { scan-assembler "lsls" } } */
 
 struct A
Index: gcc.target/arm/pr45701-3.c
===================================================================
--- gcc.target/arm/pr45701-3.c	(revision 175269)
+++ gcc.target/arm/pr45701-3.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do compile } */
-/* { dg-options "-march=armv7-a -mthumb -Os" }  */
+/* { dg-require-effective-target arm_thumb2_ok } */
+/* { dg-options "-mthumb -Os" }  */
 /* { dg-final { scan-assembler "push\t.*r8" } } */
 /* { dg-final { scan-assembler-not "push\t*r3" } } */