| Message ID | 20181214084754.23854-1-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | build: Remake config-host.mak when VERSION changes | expand |
On 12/14/18 2:47 AM, Markus Armbruster wrote: > configure gets the version number from VERSION, and writes it to > config-host.mak. The make dependency for that is missing. Because of > that, a rebuild after a VERSION change may not pick up the change. > Fix that. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/Makefile b/Makefile > index c8b9efdad4..038780c6d0 100644 > --- a/Makefile > +++ b/Makefile > @@ -67,7 +67,7 @@ CONFIG_ALL=y > -include config-all-devices.mak > -include config-all-disas.mak > > -config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios > +config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VERSION > @echo $@ is out-of-date, running configure > @# TODO: The next lines include code which supports a smooth > @# transition from old configurations without config.status. >
diff --git a/Makefile b/Makefile index c8b9efdad4..038780c6d0 100644 --- a/Makefile +++ b/Makefile @@ -67,7 +67,7 @@ CONFIG_ALL=y -include config-all-devices.mak -include config-all-disas.mak -config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios +config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VERSION @echo $@ is out-of-date, running configure @# TODO: The next lines include code which supports a smooth @# transition from old configurations without config.status.
configure gets the version number from VERSION, and writes it to config-host.mak. The make dependency for that is missing. Because of that, a rebuild after a VERSION change may not pick up the change. Fix that. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)